From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F487C35247 for ; Tue, 4 Feb 2020 21:14:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D3E821744 for ; Tue, 4 Feb 2020 21:14:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oRSdIwhJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727412AbgBDVOo (ORCPT ); Tue, 4 Feb 2020 16:14:44 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:51736 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727389AbgBDVOo (ORCPT ); Tue, 4 Feb 2020 16:14:44 -0500 Received: by mail-pj1-f65.google.com with SMTP id fa20so1967142pjb.1 for ; Tue, 04 Feb 2020 13:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sJ6dt4IAx4lLUXsNXyTvXPa3oissv4BK7c1F70A7bh8=; b=oRSdIwhJN0CghtS9RntV6TwOsdvFrxSFJjT6YQdAQnM2F+VX+syfEAu3ehPlGD1jWf BRSf1W4q4aBPpwq14CYmdOrmUNcI4nkmCgB/IHekGeVgTR/XKpWfVyoo7nO1MoauhY/3 UoqObmqt9o+bSi8pbgkIT7OQF2qPX2omMb1FvlHsasHZU1S8yRbs+AVgeD3fr/1+lzKt t9cEQd9Gud35qSLkVw5cogBK30lPAUZ2dWD1a/3a9ZTE0VIoFYwSu7/wItIUMyaGXOZb os2Y2ITzMrVQics/jxxFQHM55f70Y/ISAv+mvHEz9jJ7m1JLJ9BJIyRU+qrwIqkkvajG Z3jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sJ6dt4IAx4lLUXsNXyTvXPa3oissv4BK7c1F70A7bh8=; b=WjS/RN+01ynGMozzEBA6xci+KAST8Sl41Pbb1fXo6pClvxoIzg8UxIXHUxcSBqeE6A zWsVmaAm+f9U00lX9woZuPVlnzMS8BefokqZLPMlQs/Cx3rXJq6KCbF54mpps6DnyYg7 ni2qWEoRLAVwiou6hUFzLNQx0tXmJa8g16kN3h1nQ8Kyipm4xsL2n1b5bYNbPbofCYYW 3qn+MynKl3p7FUOu6EgOsdoXYJ6UAzcy2Zsp5AKxA5I0GGyG2afP22YNo40pfwQBiECC gbOAMydvxhoiQXzxABGi67V+3yAYblftiRV/VIz7W1ISnVdCgkPD/T9MYhwOpU9vUVUD QJxw== X-Gm-Message-State: APjAAAV8YGhZbHjRvU5ihjqU94EWmgChfC/hLD5v2zjFcaq9X2jLPFW2 b0mQvb8BzUvJaKV/SZLWQ60+XyKLdObabb9K7KlRBg== X-Google-Smtp-Source: APXvYqxlNPmkXWAk4ntFo8+j7vPZz1JM/Js336XATIdIxno0pMF0BYtKzho9m+KZys/drne1OuHaScjgbBxZP4jx/Sg= X-Received: by 2002:a17:90a:c390:: with SMTP id h16mr1318164pjt.131.1580850883761; Tue, 04 Feb 2020 13:14:43 -0800 (PST) MIME-Version: 1.0 References: <20200204193152.124980-1-swboyd@chromium.org> <20200204193152.124980-3-swboyd@chromium.org> In-Reply-To: <20200204193152.124980-3-swboyd@chromium.org> From: Brendan Higgins Date: Tue, 4 Feb 2020 13:14:31 -0800 Message-ID: Subject: Re: [PATCH 2/3] i2c: qcom-geni: Grow a dev pointer to simplify code To: Stephen Boyd Cc: Wolfram Sang , Linux Kernel Mailing List , Andy Gross , Bjorn Andersson , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Girish Mahadevan , Dilip Kota , Alok Chauhan , Douglas Anderson Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Feb 4, 2020 at 11:32 AM Stephen Boyd wrote: > > Some lines are long here. Use a struct dev pointer to shorten lines and > simplify code. The clk_get() call can fail because of EPROBE_DEFER > problems too, so just remove the error print message because it isn't > useful. > > Cc: Girish Mahadevan > Cc: Dilip Kota > Cc: Alok Chauhan > Cc: Douglas Anderson > Signed-off-by: Stephen Boyd I personally am indifferent to &pdev->dev vs. just dev, but not printing an error in the case of a defer is a definite improvement. Reviewed-by: Brendan Higgins