From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE37C35247 for ; Tue, 4 Feb 2020 21:05:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC2702084E for ; Tue, 4 Feb 2020 21:05:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TbyZS2bz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727446AbgBDVFk (ORCPT ); Tue, 4 Feb 2020 16:05:40 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:46753 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727441AbgBDVFk (ORCPT ); Tue, 4 Feb 2020 16:05:40 -0500 Received: by mail-pl1-f194.google.com with SMTP id y8so7770415pll.13 for ; Tue, 04 Feb 2020 13:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D4n97ove0a7U6N3IS1aQ2vAxrDe154szNKA6jAhkdMo=; b=TbyZS2bztW3/Ni9l0vkFs9C+yhK/6c5krjjIMTRhDNBsGG1tX8810Lj+BoF8UXuDcO a/3+4s2aHxbBkIA69OsqZm5vb9+G2A/c9ApnDoz/zYnkjEeCv/ZQI+HvLDKrMP1gUabl Q7OeZX4vzWOienIvjsidNHxzLFvqTaa2Bd22dWXCKmIEW/ksl/86SU1FE+XJbSXffnvE yczKot6tDwKhTKMxstmRsF9VYd2ZJWo4OvS0P0RBG2XHB5hkbw0H6RfrQ2sL3fZHgtyV bhiN+L/g3IcqWALGO4Abp+tEHnSwqiEBCmD/YKHNCZDq1FQTUvsU9q/57oXC4OI39fDG ShVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D4n97ove0a7U6N3IS1aQ2vAxrDe154szNKA6jAhkdMo=; b=e8J3Tmb0jjGrfGc/jYC/83c+whmjD+psEtDoHDr7mhH9T3Xmv/JXN6rwuuUXvgmsb2 j3lDgy1RnvnH/k+zKx7fdoXCClrKc5HB8tqRCHi1EjfqYSqJUHIBxl+lpTK223PrzGHE z3PH+7ZvWlrEg/u/hl4hZizcXD5wPiaxHKPyN/G18i4k1tNDGrbYAv5zhudlptaozo6F 5gITie3bQ2p2NTKMfRjOwvJ153kGMNjwM/CurnhpN79YY9TL/Sb0XD13fGxH0adpxg1z /uqb6XD08Z1iRLMCnC9z51R3MLeh5i17kqWv+vsWuPoESDGT5T/iYqrcYYR9cbUD6eU8 w9iw== X-Gm-Message-State: APjAAAXlg1GPFtbCmYKp41qEmiKjYv18yFAHQhVi2HNCagyhkh0bIWrC qc7AQrszxSSbyw8bfuUPcgARQtuYbirZJ/USkKYBag== X-Google-Smtp-Source: APXvYqzgRC3LpUpsV7bDuumUM2fd8cz2P/cb1FukLOm/VuFeIrTAXDU5BVFfOtS6u7Fgfqgqty0o0xN6Arf4tkVcHUM= X-Received: by 2002:a17:902:fe8d:: with SMTP id x13mr32325551plm.232.1580850339164; Tue, 04 Feb 2020 13:05:39 -0800 (PST) MIME-Version: 1.0 References: <20200204193152.124980-1-swboyd@chromium.org> <20200204193152.124980-2-swboyd@chromium.org> In-Reply-To: <20200204193152.124980-2-swboyd@chromium.org> From: Brendan Higgins Date: Tue, 4 Feb 2020 13:05:27 -0800 Message-ID: Subject: Re: [PATCH 1/3] i2c: qcom-geni: Let firmware specify irq trigger flags To: Stephen Boyd Cc: Wolfram Sang , Linux Kernel Mailing List , Andy Gross , Bjorn Andersson , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Girish Mahadevan , Dilip Kota , Alok Chauhan , Douglas Anderson Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Feb 4, 2020 at 11:32 AM Stephen Boyd wrote: > > We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables > should take care of this for us. Just use 0 instead so that we use the > flags from the firmware. Also, remove specify dev_name() for the irq > name so that we can get better information in /proc/interrupts about > which device is generating interrupts. > > Cc: Girish Mahadevan > Cc: Dilip Kota > Cc: Alok Chauhan > Cc: Douglas Anderson > Signed-off-by: Stephen Boyd Reviewed-by: Brendan Higgins Seems pretty straightforward to me.