From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C04AC433F5 for ; Mon, 31 Jan 2022 19:25:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359789AbiAaTZv (ORCPT ); Mon, 31 Jan 2022 14:25:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359630AbiAaTZr (ORCPT ); Mon, 31 Jan 2022 14:25:47 -0500 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D13AC06173D for ; Mon, 31 Jan 2022 11:25:46 -0800 (PST) Received: by mail-pg1-x52f.google.com with SMTP id p125so13154753pga.2 for ; Mon, 31 Jan 2022 11:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eXGf5WCTdRujs8c3iA+q8x9yw63xl/p7dIlJ18j1g0k=; b=ViXsl44S7dZb5JWKzVTj8IGlfi04XDzigxkaEgZXxp0J1OA6KHZAH4XcM+XtwbQUv7 IhLtdQ2eDQmm67OwyiJNE3ndCZIKWV+lXNQcdNyDH5jQ9/MFI+TXWQUHFv5v8eL/PHlW 6kIL2/4tXvMtyQS7HPfovb5wBAUE061JG/E8gnHwCPLRzgOG8G2uDGGkZn8tI475nECo 5z4MtIjG8/TkTg17A625vsqxlNSbwmBf01dUfnu3jX3doz0l1kFNfflZcK9UJITMzjno BwZf9ai7avQe2WTDzCHwSf13n3qTjTLbhBTs1VcSyicyzB9jiA+7K3+KSNH7AXb63SFH 0R1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eXGf5WCTdRujs8c3iA+q8x9yw63xl/p7dIlJ18j1g0k=; b=nluURAtUUhwf8T802Sq06a8BvKykmrx+4CQrqyzpTD9Wl+koeaa6i6cSFlNrTBv7Oh 4GEq8qgCgKkDKPlg4HtlNVpRQslhPTkReR98FQDnVcFYF1R4gbRs7hJc0v6Cn5hKIEPH pqdRitzyFx82CXeT7zgPTqKyw30RaBzm5I1J3GbIgXwzAk2Gy2JecTXoeBU02+aggJDy 6gSsyLoPYlS+8wCHoVf3xFgnLUVYcVYAqH/xgqmSbtYU0HG4WjG/Vg/D3qoRxj3bfp23 co20QL3IlZ2sGD3YlICM+EfukTZw00Q5p9bS78kZ0Ljdsk9hXfE2ySNjVj7Vskb7knw/ s0/Q== X-Gm-Message-State: AOAM532Y6NgJHsikijJljBtiwZsYCEjZkz+naOuJLPByBwImayUgaaY0 kWmF5vbv3R4iVHf+8mTIStK3hKTSTDo7FcKwBtiddg== X-Google-Smtp-Source: ABdhPJw1vhNusZ1GU768T+2P42NMgdzvrqkQF9yGWmPGojl/h4JYNENm9wG9shwRx4UMfimo1130MnYsuRfSPPVeWfw= X-Received: by 2002:aa7:8a14:: with SMTP id m20mr21629811pfa.63.1643657145867; Mon, 31 Jan 2022 11:25:45 -0800 (PST) MIME-Version: 1.0 References: <20220127221710.165733-1-dlatypov@google.com> In-Reply-To: <20220127221710.165733-1-dlatypov@google.com> From: Brendan Higgins Date: Mon, 31 Jan 2022 14:25:34 -0500 Message-ID: Subject: Re: [PATCH] kunit: fix missing f in f-string in run_checks.py To: Daniel Latypov Cc: davidgow@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 5:17 PM Daniel Latypov wrote: > > We're missing the `f` prefix to have python do string interpolation, so > we'd never end up printing what the actual "unexpected" error is. > > Fixes: ee92ed38364e ("kunit: add run_checks.py script to validate kunit changes") > Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins