From: Brendan Higgins <brendanhiggins@google.com>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Richard Weinberger <richard@nod.at>,
davidgow <davidgow@google.com>, Jeff Dike <jdike@addtoit.com>,
linux-um <linux-um@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [RFC v1 1/2] um: drivers: remove support for UML_NET_PCAP
Date: Tue, 10 Dec 2019 14:40:24 -0800 [thread overview]
Message-ID: <CAFd5g46osmFBka0X60A+_mmetpreG+abnh_+GQmVrr+PPxrqxg@mail.gmail.com> (raw)
In-Reply-To: <87f182c6-82a3-d696-72e4-ddaa781a655b@cambridgegreys.com>
On Mon, Dec 9, 2019 at 11:14 PM Anton Ivanov
<anton.ivanov@cambridgegreys.com> wrote:
>
> On 10/12/2019 00:02, Richard Weinberger wrote:
> > ----- Ursprüngliche Mail -----
> >> Von: "Brendan Higgins" <brendanhiggins@google.com>
> >>> IMHO we should at least mark them as "obsolete" and start preparing to
> >>> remove them.
> >>
> >> Alright, I will send a patch out which marks the other network drivers
> >> as "obsolete".
> >>
> >> Clarification: Should I mark all UML network devices as "obsolete"
> >> except for NET_VECTOR? Daemon and MCAST looked to me (I am not a
> >> networking expert), like they might not be covered by vector.
> >
> > No. Why?
> >
> > Thanks,
> > //richard
> >
> > _______________________________________________
> > linux-um mailing list
> > linux-um@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-um
> >
> At least pcap and vde are maintenance issues. They do not even build today.
>
> Off the top of my head, daemon needs fixes to the switch - it has an
> O(n) performance hit for n="number of ports" as well as a few other issues.
>
> Tap has a fully functional replacement
>
> Pcap has a fully functional replacement
>
> mcast for 2 instances is functionally equivalent to running l2tp or gre
> back-to-back.
>
> IMHO we can start marking some of them as obsolete.
It looked to me like this discussion is ongoing; however, it seemed
like the discussion might be boiling down to *which* drivers should be
marked obsolete, so I decided to go ahead and send a patch which marks
everything as deprecated. I figured it would make it easier to focus
the conversation on what, if anything, should be marked obsolete:
https://lore.kernel.org/lkml/20191210223403.244842-1-brendanhiggins@google.com/T/#u
Also, Anton, I flat out stole a bunch of your comments on this thread
to make my commit message. Just respond with the appropriate tags
(co-developed-by, etc) if you want to be credited for them. As it is,
I marked you as "suggested-by".
Cheers!
WARNING: multiple messages have this Message-ID
From: Brendan Higgins <brendanhiggins@google.com>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Johannes Berg <johannes.berg@intel.com>,
Richard Weinberger <richard@nod.at>,
Jeff Dike <jdike@addtoit.com>,
linux-um <linux-um@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
davidgow <davidgow@google.com>
Subject: Re: [RFC v1 1/2] um: drivers: remove support for UML_NET_PCAP
Date: Tue, 10 Dec 2019 14:40:24 -0800 [thread overview]
Message-ID: <CAFd5g46osmFBka0X60A+_mmetpreG+abnh_+GQmVrr+PPxrqxg@mail.gmail.com> (raw)
In-Reply-To: <87f182c6-82a3-d696-72e4-ddaa781a655b@cambridgegreys.com>
On Mon, Dec 9, 2019 at 11:14 PM Anton Ivanov
<anton.ivanov@cambridgegreys.com> wrote:
>
> On 10/12/2019 00:02, Richard Weinberger wrote:
> > ----- Ursprüngliche Mail -----
> >> Von: "Brendan Higgins" <brendanhiggins@google.com>
> >>> IMHO we should at least mark them as "obsolete" and start preparing to
> >>> remove them.
> >>
> >> Alright, I will send a patch out which marks the other network drivers
> >> as "obsolete".
> >>
> >> Clarification: Should I mark all UML network devices as "obsolete"
> >> except for NET_VECTOR? Daemon and MCAST looked to me (I am not a
> >> networking expert), like they might not be covered by vector.
> >
> > No. Why?
> >
> > Thanks,
> > //richard
> >
> > _______________________________________________
> > linux-um mailing list
> > linux-um@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-um
> >
> At least pcap and vde are maintenance issues. They do not even build today.
>
> Off the top of my head, daemon needs fixes to the switch - it has an
> O(n) performance hit for n="number of ports" as well as a few other issues.
>
> Tap has a fully functional replacement
>
> Pcap has a fully functional replacement
>
> mcast for 2 instances is functionally equivalent to running l2tp or gre
> back-to-back.
>
> IMHO we can start marking some of them as obsolete.
It looked to me like this discussion is ongoing; however, it seemed
like the discussion might be boiling down to *which* drivers should be
marked obsolete, so I decided to go ahead and send a patch which marks
everything as deprecated. I figured it would make it easier to focus
the conversation on what, if anything, should be marked obsolete:
https://lore.kernel.org/lkml/20191210223403.244842-1-brendanhiggins@google.com/T/#u
Also, Anton, I flat out stole a bunch of your comments on this thread
to make my commit message. Just respond with the appropriate tags
(co-developed-by, etc) if you want to be credited for them. As it is,
I marked you as "suggested-by".
Cheers!
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2019-12-10 22:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 2:01 [RFC v1 0/2] um: drop broken features to fix allyesconfig Brendan Higgins
2019-12-06 2:01 ` Brendan Higgins
2019-12-06 2:01 ` [RFC v1 1/2] um: drivers: remove support for UML_NET_PCAP Brendan Higgins
2019-12-06 2:01 ` Brendan Higgins
2019-12-06 7:23 ` Anton Ivanov
2019-12-06 7:23 ` Anton Ivanov
2019-12-07 0:32 ` Brendan Higgins
2019-12-07 0:32 ` Brendan Higgins
2019-12-07 1:21 ` Brendan Higgins
2019-12-07 1:21 ` Brendan Higgins
2019-12-07 9:14 ` Anton Ivanov
2019-12-07 9:14 ` Anton Ivanov
2019-12-09 23:40 ` Brendan Higgins
2019-12-09 23:40 ` Brendan Higgins
2019-12-10 0:02 ` Richard Weinberger
2019-12-10 0:02 ` Richard Weinberger
2019-12-10 7:14 ` Anton Ivanov
2019-12-10 7:14 ` Anton Ivanov
2019-12-10 22:40 ` Brendan Higgins [this message]
2019-12-10 22:40 ` Brendan Higgins
2019-12-10 7:08 ` Anton Ivanov
2019-12-10 7:08 ` Anton Ivanov
2019-12-06 2:01 ` [RFC v1 2/2] uml: remove support for CONFIG_STATIC_LINK Brendan Higgins
2019-12-06 2:01 ` Brendan Higgins
2019-12-06 7:41 ` Anton Ivanov
2019-12-06 7:41 ` Anton Ivanov
2019-12-06 22:49 ` Brendan Higgins
2019-12-06 22:49 ` Brendan Higgins
2019-12-06 7:45 ` [RFC v1 0/2] um: drop broken features to fix allyesconfig Anton Ivanov
2019-12-06 7:45 ` Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFd5g46osmFBka0X60A+_mmetpreG+abnh_+GQmVrr+PPxrqxg@mail.gmail.com \
--to=brendanhiggins@google.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=davidgow@google.com \
--cc=jdike@addtoit.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.