From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbeBUSWE (ORCPT ); Wed, 21 Feb 2018 13:22:04 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:32972 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbeBUSWB (ORCPT ); Wed, 21 Feb 2018 13:22:01 -0500 X-Google-Smtp-Source: AG47ELspmRHIHfE7Y5ctWCGjlAC1iVPu8LoRm4ZfDi6hb3uMx5mwzkcBrCi+I+qGaX+ii90YkTCbW0/qfnMrzMGnvQk= MIME-Version: 1.0 In-Reply-To: References: <1518701959-22899-1-git-send-email-tali.perry1@gmail.com> <1518701959-22899-2-git-send-email-tali.perry1@gmail.com> <20180219144905.bfrycjnas7dcuo34@rob-hp-laptop>

From: Brendan Higgins Date: Wed, 21 Feb 2018 10:22:00 -0800 Message-ID: Subject: Re: [PATCH v2 1/1] clk: npcm750: update text with fixed clocks To: Rob Herring Cc: Tali Perry , Mark Rutland , Russell King , Avi Fishman , Tomer Maimon , Rick Altherr , devicetree , Linux Kernel Mailing List , Linux ARM , OpenBMC Maillist , Nancy Yuen , Patrick Venture Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 21, 2018 at 5:23 AM, Rob Herring wrote: > On Tue, Feb 20, 2018 at 10:47 PM, Brendan Higgins > wrote: >> On Mon, Feb 19, 2018 at 6:49 AM, Rob Herring wrote: >>> On Thu, Feb 15, 2018 at 02:38:12PM -0800, Brendan Higgins wrote: >>>> On Thu, Feb 15, 2018 at 5:39 AM, Tali Perry wrote: >>>> > >>>> > Signed-off-by: Tali Perry >>>> > >>>> >>>> >>>> I think this should probably be rolled into [PATCH v2 1/1] npcm750: add fixed >>>> clocks (moved from drivers/clk/clk-npcm7xx.c): >>>> https://www.spinics.net/lists/arm-kernel/msg634678.html >>> >>> No, binding docs, dts files and driver code should all be separate >>> patches. >> >> My mistake. This patch has a dt-bindings include file; should the include file >> go in here, with the dtsi changes, or in its own separate patch? > > It defines the binding, so with the binding documentation. > So two things, first off, the include file I was asking about is not a dtsi, but a file that defines a bunch of macros for referencing clocks. I don't know if that makes a difference. Second, the patch that I referenced above, "[PATCH v2 1/1] npcm750: add fixed clocks (moved from drivers/clk/clk-npcm7xx.c): https://www.spinics.net/lists/arm-kernel/msg634678.html", *does* contain a dtsi and nothing else, and defines these bindings, which is why I thought it went in with the binding docs. Cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Higgins Subject: Re: [PATCH v2 1/1] clk: npcm750: update text with fixed clocks Date: Wed, 21 Feb 2018 10:22:00 -0800 Message-ID: References: <1518701959-22899-1-git-send-email-tali.perry1@gmail.com> <1518701959-22899-2-git-send-email-tali.perry1@gmail.com> <20180219144905.bfrycjnas7dcuo34@rob-hp-laptop>

Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , devicetree , Tomer Maimon , Avi Fishman , Linux Kernel Mailing List , OpenBMC Maillist , Russell King , Tali Perry , Nancy Yuen , Patrick Venture , Rick Altherr , Linux ARM List-Id: devicetree@vger.kernel.org On Wed, Feb 21, 2018 at 5:23 AM, Rob Herring wrote: > On Tue, Feb 20, 2018 at 10:47 PM, Brendan Higgins > wrote: >> On Mon, Feb 19, 2018 at 6:49 AM, Rob Herring wrote: >>> On Thu, Feb 15, 2018 at 02:38:12PM -0800, Brendan Higgins wrote: >>>> On Thu, Feb 15, 2018 at 5:39 AM, Tali Perry wrote: >>>> > >>>> > Signed-off-by: Tali Perry >>>> > >>>> >>>> >>>> I think this should probably be rolled into [PATCH v2 1/1] npcm750: add fixed >>>> clocks (moved from drivers/clk/clk-npcm7xx.c): >>>> https://www.spinics.net/lists/arm-kernel/msg634678.html >>> >>> No, binding docs, dts files and driver code should all be separate >>> patches. >> >> My mistake. This patch has a dt-bindings include file; should the include file >> go in here, with the dtsi changes, or in its own separate patch? > > It defines the binding, so with the binding documentation. > So two things, first off, the include file I was asking about is not a dtsi, but a file that defines a bunch of macros for referencing clocks. I don't know if that makes a difference. Second, the patch that I referenced above, "[PATCH v2 1/1] npcm750: add fixed clocks (moved from drivers/clk/clk-npcm7xx.c): https://www.spinics.net/lists/arm-kernel/msg634678.html", *does* contain a dtsi and nothing else, and defines these bindings, which is why I thought it went in with the binding docs. Cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:400d:c09::244; helo=mail-qk0-x244.google.com; envelope-from=brendanhiggins@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="W826oKj7"; dkim-atps=neutral Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com [IPv6:2607:f8b0:400d:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zmm6N2RDWzF0qm for ; Thu, 22 Feb 2018 05:22:03 +1100 (AEDT) Received: by mail-qk0-x244.google.com with SMTP id s188so3180070qkb.2 for ; Wed, 21 Feb 2018 10:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=F9V2zSnu8Y9wJDIRAbD+74m1WekztcLCmZCoEIPwKWo=; b=W826oKj7TCcXCLiGOTj5vckpFbAKT/bbN1R6Um/NtSfEPvn+sdsddfmWn5weltQQfx UEGnAtCdgCyTn+L9lUHIY9P6gFMUYabXiCBFdsRXp6MprK8MS1DvTcNNxZISHhXCTXhD jtnyf5euiwwjPsVu2MnJZcKanmk3uVHAC1snepzyHxtjrtuCEFf0FJN93T+2gOW0I7kR m3CiydQfcm/ce9hvUASahbyR5ipX0emXNJELpYRTOmd1BhXIDdIZzxOanAF6LnwH3OOQ wYHReLxq6dlB9Q6WRruZ7Oe7UU8cadV/qUL6hnL1re8fsF4daWqeK/YQboGnuUYwdATn vBfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=F9V2zSnu8Y9wJDIRAbD+74m1WekztcLCmZCoEIPwKWo=; b=eXFESdf/9bwJqohY7Zht03DmwBvOm176V2G8wyEx2j+3qxzXe1iDzMVJzek9e2GtI6 c3ZhbQRjxYtiWimx+KyRPt1FH+GY7GAQJpiu31ErikxVexNOKRwHTNtmV23tSLxycmd0 J8ZFNgoWaXinKQ7GfXsZsSu99t9HzJHyNpB40rOylsV+KnADSV8Ad26BUYoBzDNp4Ng1 z2brR3VD4WRtNRZFdXPua1b/8FmN72jszHM+J/r3X4zIOrOyki4uDtyxILmGsHxZ8R9g n9neoiqwI9AOK8MWvVsYfHRYtUsebLbebPq8TfIEIM+Hz/VK0jEdZ9Z5rUxr+e4Mun2Z oeTA== X-Gm-Message-State: APf1xPDFkmaBrcdNgI4piKQGdkyUrR/0BIxpNl2KzScnlVMjWCz0Ao4T 8nkrXgayOFdH5YTF9wuog92/MODjY046WSvNNF3o6w== X-Google-Smtp-Source: AG47ELspmRHIHfE7Y5ctWCGjlAC1iVPu8LoRm4ZfDi6hb3uMx5mwzkcBrCi+I+qGaX+ii90YkTCbW0/qfnMrzMGnvQk= X-Received: by 10.55.65.81 with SMTP id o78mr1269574qka.274.1519237320727; Wed, 21 Feb 2018 10:22:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.34.104 with HTTP; Wed, 21 Feb 2018 10:22:00 -0800 (PST) In-Reply-To: References: <1518701959-22899-1-git-send-email-tali.perry1@gmail.com> <1518701959-22899-2-git-send-email-tali.perry1@gmail.com> <20180219144905.bfrycjnas7dcuo34@rob-hp-laptop>

From: Brendan Higgins Date: Wed, 21 Feb 2018 10:22:00 -0800 Message-ID: Subject: Re: [PATCH v2 1/1] clk: npcm750: update text with fixed clocks To: Rob Herring Cc: Tali Perry , Mark Rutland , Russell King , Avi Fishman , Tomer Maimon , Rick Altherr , devicetree , Linux Kernel Mailing List , Linux ARM , OpenBMC Maillist , Nancy Yuen , Patrick Venture Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 18:22:05 -0000 On Wed, Feb 21, 2018 at 5:23 AM, Rob Herring wrote: > On Tue, Feb 20, 2018 at 10:47 PM, Brendan Higgins > wrote: >> On Mon, Feb 19, 2018 at 6:49 AM, Rob Herring wrote: >>> On Thu, Feb 15, 2018 at 02:38:12PM -0800, Brendan Higgins wrote: >>>> On Thu, Feb 15, 2018 at 5:39 AM, Tali Perry wrote: >>>> > >>>> > Signed-off-by: Tali Perry >>>> > >>>> >>>> >>>> I think this should probably be rolled into [PATCH v2 1/1] npcm750: add fixed >>>> clocks (moved from drivers/clk/clk-npcm7xx.c): >>>> https://www.spinics.net/lists/arm-kernel/msg634678.html >>> >>> No, binding docs, dts files and driver code should all be separate >>> patches. >> >> My mistake. This patch has a dt-bindings include file; should the include file >> go in here, with the dtsi changes, or in its own separate patch? > > It defines the binding, so with the binding documentation. > So two things, first off, the include file I was asking about is not a dtsi, but a file that defines a bunch of macros for referencing clocks. I don't know if that makes a difference. Second, the patch that I referenced above, "[PATCH v2 1/1] npcm750: add fixed clocks (moved from drivers/clk/clk-npcm7xx.c): https://www.spinics.net/lists/arm-kernel/msg634678.html", *does* contain a dtsi and nothing else, and defines these bindings, which is why I thought it went in with the binding docs. Cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: brendanhiggins@google.com (Brendan Higgins) Date: Wed, 21 Feb 2018 10:22:00 -0800 Subject: [PATCH v2 1/1] clk: npcm750: update text with fixed clocks In-Reply-To: References: <1518701959-22899-1-git-send-email-tali.perry1@gmail.com> <1518701959-22899-2-git-send-email-tali.perry1@gmail.com> <20180219144905.bfrycjnas7dcuo34@rob-hp-laptop>

Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 21, 2018 at 5:23 AM, Rob Herring wrote: > On Tue, Feb 20, 2018 at 10:47 PM, Brendan Higgins > wrote: >> On Mon, Feb 19, 2018 at 6:49 AM, Rob Herring wrote: >>> On Thu, Feb 15, 2018 at 02:38:12PM -0800, Brendan Higgins wrote: >>>> On Thu, Feb 15, 2018 at 5:39 AM, Tali Perry wrote: >>>> > >>>> > Signed-off-by: Tali Perry >>>> > >>>> >>>> >>>> I think this should probably be rolled into [PATCH v2 1/1] npcm750: add fixed >>>> clocks (moved from drivers/clk/clk-npcm7xx.c): >>>> https://www.spinics.net/lists/arm-kernel/msg634678.html >>> >>> No, binding docs, dts files and driver code should all be separate >>> patches. >> >> My mistake. This patch has a dt-bindings include file; should the include file >> go in here, with the dtsi changes, or in its own separate patch? > > It defines the binding, so with the binding documentation. > So two things, first off, the include file I was asking about is not a dtsi, but a file that defines a bunch of macros for referencing clocks. I don't know if that makes a difference. Second, the patch that I referenced above, "[PATCH v2 1/1] npcm750: add fixed clocks (moved from drivers/clk/clk-npcm7xx.c): https://www.spinics.net/lists/arm-kernel/msg634678.html", *does* contain a dtsi and nothing else, and defines these bindings, which is why I thought it went in with the binding docs. Cheers