* [Buildroot] [PATCH 1/1] jack2: Added staging
@ 2014-08-06 7:55 Pieter De Gendt
2014-08-06 8:04 ` Thomas De Schampheleire
0 siblings, 1 reply; 6+ messages in thread
From: Pieter De Gendt @ 2014-08-06 7:55 UTC (permalink / raw)
To: buildroot
Signed-off-by: Pieter De Gendt <pieter.degendt@gmail.com>
---
package/jack2/jack2.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
index 68f6e42..e1c3197 100644
--- a/package/jack2/jack2.mk
+++ b/package/jack2/jack2.mk
@@ -8,6 +8,7 @@ JACK2_VERSION = ab409a65df95bc261ff72b52d6b3f4a65cf3266a
JACK2_SITE = $(call github,jackaudio,jack2,$(JACK2_VERSION))
JACK2_LICENSE = GPLv2+ (jack server), LGPLv2.1+ (jack library)
JACK2_DEPENDENCIES = libsamplerate libsndfile alsa-lib host-python
+JACK2_INSTALL_STAGING = YES
define JACK2_CONFIGURE_CMDS
(cd $(@D); \
@@ -27,4 +28,10 @@ define JACK2_INSTALL_TARGET_CMDS
install)
endef
+define JACK2_INSTALL_STAGING_CMDS
+ $(INSTALL) -m 0755 -d $(STAGING_DIR)/usr/include/jack
+ $(INSTALL) -m 0644 $(@D)/common/jack/*.h \
+ $(STAGING_DIR)/usr/include/jack
+endef
+
$(eval $(generic-package))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] jack2: Added staging
2014-08-06 7:55 [Buildroot] [PATCH 1/1] jack2: Added staging Pieter De Gendt
@ 2014-08-06 8:04 ` Thomas De Schampheleire
2014-08-06 8:08 ` Pieter De Gendt
0 siblings, 1 reply; 6+ messages in thread
From: Thomas De Schampheleire @ 2014-08-06 8:04 UTC (permalink / raw)
To: buildroot
Pieter De Gendt <pieter.degendt@gmail.com> schreef:
>
>Signed-off-by: Pieter De Gendt <pieter.degendt@gmail.com>
>---
> package/jack2/jack2.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
>index 68f6e42..e1c3197 100644
>--- a/package/jack2/jack2.mk
>+++ b/package/jack2/jack2.mk
>@@ -8,6 +8,7 @@ JACK2_VERSION = ab409a65df95bc261ff72b52d6b3f4a65cf3266a
> JACK2_SITE = $(call github,jackaudio,jack2,$(JACK2_VERSION))
> JACK2_LICENSE = GPLv2+ (jack server), LGPLv2.1+ (jack library)
> JACK2_DEPENDENCIES = libsamplerate libsndfile alsa-lib host-python
>+JACK2_INSTALL_STAGING = YES
>
> define JACK2_CONFIGURE_CMDS
> (cd $(@D); \
>@@ -27,4 +28,10 @@ define JACK2_INSTALL_TARGET_CMDS
> install)
> endef
>
>+define JACK2_INSTALL_STAGING_CMDS
>+ $(INSTALL) -m 0755 -d $(STAGING_DIR)/usr/include/jack
>+ $(INSTALL) -m 0644 $(@D)/common/jack/*.h \
>+ $(STAGING_DIR)/usr/include/jack
>+endef
Is there a particular reason why you did manual copies here instead of just running 'make install'?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] jack2: Added staging
2014-08-06 8:04 ` Thomas De Schampheleire
@ 2014-08-06 8:08 ` Pieter De Gendt
2014-08-06 8:31 ` Thomas De Schampheleire
0 siblings, 1 reply; 6+ messages in thread
From: Pieter De Gendt @ 2014-08-06 8:08 UTC (permalink / raw)
To: buildroot
No, I'm just not that familiar yet with the makefile mechanism, I looked at
other packages for examples, this seemed to be the easiest solution.
On Wed, Aug 6, 2014 at 10:04 AM, Thomas De Schampheleire <
patrickdepinguin@gmail.com> wrote:
> Pieter De Gendt <pieter.degendt@gmail.com> schreef:
> >
> >Signed-off-by: Pieter De Gendt <pieter.degendt@gmail.com>
> >---
> > package/jack2/jack2.mk | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> >diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
> >index 68f6e42..e1c3197 100644
> >--- a/package/jack2/jack2.mk
> >+++ b/package/jack2/jack2.mk
> >@@ -8,6 +8,7 @@ JACK2_VERSION = ab409a65df95bc261ff72b52d6b3f4a65cf3266a
> > JACK2_SITE = $(call github,jackaudio,jack2,$(JACK2_VERSION))
> > JACK2_LICENSE = GPLv2+ (jack server), LGPLv2.1+ (jack library)
> > JACK2_DEPENDENCIES = libsamplerate libsndfile alsa-lib host-python
> >+JACK2_INSTALL_STAGING = YES
> >
> > define JACK2_CONFIGURE_CMDS
> > (cd $(@D); \
> >@@ -27,4 +28,10 @@ define JACK2_INSTALL_TARGET_CMDS
> > install)
> > endef
> >
> >+define JACK2_INSTALL_STAGING_CMDS
> >+ $(INSTALL) -m 0755 -d $(STAGING_DIR)/usr/include/jack
> >+ $(INSTALL) -m 0644 $(@D)/common/jack/*.h \
> >+ $(STAGING_DIR)/usr/include/jack
> >+endef
>
> Is there a particular reason why you did manual copies here instead of
> just running 'make install'?
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140806/bc083c95/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] jack2: Added staging
2014-08-06 8:08 ` Pieter De Gendt
@ 2014-08-06 8:31 ` Thomas De Schampheleire
2014-08-06 8:53 ` Pieter De Gendt
0 siblings, 1 reply; 6+ messages in thread
From: Thomas De Schampheleire @ 2014-08-06 8:31 UTC (permalink / raw)
To: buildroot
(Please don't top post)
Pieter De Gendt <pieter.degendt@gmail.com> schreef:
>No, I'm just not that familiar yet with the makefile mechanism, I looked at
>other packages for examples, this seemed to be the easiest solution.
I think you should try using the same kind of rule as the INSTALL_TARGET_CMDS, and see if the right files are installed...
This is more future proof...
Best regards,
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] jack2: Added staging
2014-08-06 8:31 ` Thomas De Schampheleire
@ 2014-08-06 8:53 ` Pieter De Gendt
2014-08-06 11:19 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Pieter De Gendt @ 2014-08-06 8:53 UTC (permalink / raw)
To: buildroot
On Wed, Aug 6, 2014 at 10:31 AM, Thomas De Schampheleire <
patrickdepinguin@gmail.com> wrote:
> (Please don't top post)
>
> Pieter De Gendt <pieter.degendt@gmail.com> schreef:
> >No, I'm just not that familiar yet with the makefile mechanism, I looked
> at
> >other packages for examples, this seemed to be the easiest solution.
>
> I think you should try using the same kind of rule as the
> INSTALL_TARGET_CMDS, and see if the right files are installed...
> This is more future proof...
>
> Best regards,
> Thomas
>
>
Ok but from the waf build system help I don't see the option to copy the
header files.. Would this mean that the manual copy is still valid?
./waf --help
waf [commands] [options]
Main commands (example: ./waf build -j4)
build : executes the build
clean : cleans the project
configure: configures the project
dist : makes a tarball for redistributing the sources
distcheck: checks if the project compiles (tarball from 'dist')
distclean: removes the build directory
install : installs the targets on the system
list : lists the targets to execute
step : executes tasks in a step-by-step fashion, for debugging
uninstall: removes the targets installed
update : updates the plugins from the *waflib/extras* directory
Options:
--version show program's version number and exit
-h, --help show this help message and exit
-j JOBS, --jobs=JOBS amount of parallel jobs (8)
-k, --keep keep running happily even if errors are found
-v, --verbose verbosity level -v -vv or -vvv [default: 0]
--nocache ignore the WAFCACHE (if set)
--zones=ZONES debugging zones (task_gen, deps, tasks, etc)
--libdir=LIBDIR Library directory [Default: <prefix>/lib]
--libdir32=LIBDIR32 32bit Library directory [Default: <prefix>/lib32]
--mandir=MANDIR Manpage directory [Default: <prefix>/share/man/man1]
--dbus Enable D-Bus JACK (jackdbus)
--dist-target=DIST_TARGET
Specify the target for cross-compiling [auto,mingw]
--classic Force enable standard JACK (jackd) even if D-Bus
JACK (jackdbus) is enabled too
--doxygen Enable build of doxygen documentation
--profile Build with engine profiling
--mixed Build with 32/64 bits mixed mode
--clients=CLIENTS Maximum number of JACK clients
--ports-per-application=APPLICATION_PORTS
Maximum number of ports per application
--debug Build debuggable binaries
--firewire Enable FireWire driver (FFADO)
--freebob Enable FreeBob driver
--alsa Enable ALSA driver
--iio Enable IIO driver
--autostart=AUTOSTART
Autostart method. Possible values: "default",
"classic", "dbus", "none"
--portaudio Enable Portaudio driver
--winmme Enable WinMME driver
--enable-pkg-config-dbus-service-dir
force D-Bus service install dir to be one returned
by pkg-config
configure options:
-o OUT, --out=OUT build dir for the project
-t TOP, --top=TOP src dir for the project
--prefix=PREFIX installation prefix [default: '/usr/local/']
--download try to download the tools if missing
build and install options:
-p, --progress -p: progress bar; -pp: ide output
--targets=TARGETS task generators, e.g. "target1,target2"
step options:
--files=FILES files to process, by regexp, e.g.
"*/main.c,*/test/main.o"
install/uninstall options:
--destdir=DESTDIR installation root [default: '']
-f, --force force file installation
C++ Compiler Options:
--check-cxx-compiler=CHECK_CXX_COMPILER
On this platform (linux) the following C++ Compiler
will be checked by default: "g++ icpc"
C Compiler Options:
--check-c-compiler=CHECK_C_COMPILER
On this platform (linux) the following C-Compiler
will be checked by default: "gcc icc"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140806/073ec7bd/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] jack2: Added staging
2014-08-06 8:53 ` Pieter De Gendt
@ 2014-08-06 11:19 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2014-08-06 11:19 UTC (permalink / raw)
To: buildroot
Dear Pieter De Gendt,
On Wed, 6 Aug 2014 10:53:32 +0200, Pieter De Gendt wrote:
> Ok but from the waf build system help I don't see the option to copy the
> header files.. Would this mean that the manual copy is still valid?
Just do the installation, as done in JACK2_INSTALL_TARGET_CMDS. I.e, do:
define JACK2_INSTALL_STAGING_CMDS
(cd $(@D); $(HOST_DIR)/usr/bin/python2 ./waf --destdir=$(STAGING_DIR) install)
endef
Most likely waf is installing the header files. You simply don't seem
them at the end of the target because Buildroot removes all header
files from the target directory at the end of the build.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-06 11:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-06 7:55 [Buildroot] [PATCH 1/1] jack2: Added staging Pieter De Gendt
2014-08-06 8:04 ` Thomas De Schampheleire
2014-08-06 8:08 ` Pieter De Gendt
2014-08-06 8:31 ` Thomas De Schampheleire
2014-08-06 8:53 ` Pieter De Gendt
2014-08-06 11:19 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.