From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 In-Reply-To: <57E5DA11.3020204@quarksecurity.com> References: <1474664152-18727-1-git-send-email-william.c.roberts@intel.com> <57E5D285.5080709@quarksecurity.com> <57E5DA11.3020204@quarksecurity.com> From: William Roberts Date: Fri, 23 Sep 2016 18:51:16 -0700 Message-ID: Subject: Re: Libsepol Mac Build Errors To: Joshua Brindle Cc: William Roberts , Stephen Smalley , "selinux@tycho.nsa.gov" Content-Type: text/plain; charset=UTF-8 List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: On Fri, Sep 23, 2016 at 6:42 PM, Joshua Brindle wrote: > William Roberts wrote: >> >> On Fri, Sep 23, 2016 at 6:10 PM, Joshua Brindle >> wrote: >>> >>> william.c.roberts@intel.com wrote: >>>> >>>> The patches below fix some warnings reported by Josh Brindle on >>>> the libsepol build. >>>> >>>> Josh can you test these and see if those three warning go away >>>> and give an ack if they are ok? >>>> >>>> [PATCH 1/3] libsepol: fix unused variable 'size' on mac build >>>> [PATCH 2/3] libsepol: fix unused variable 'len' on mac build >>>> [PATCH 3/3] libsepol: fix unitialized variable 'nread' on mac build >>> >>> >>> That fixed the build errors. The linker does not like the soname, version >>> map, etc stuff though so I still don't get a sofile out. >> >> >> FYI I managed to set up macincloud today, so I have an el capitain >> instance >> with 8 cores and 16GB ram I can use for testing. I'm currently syncing the >> source tree, so ill be able to test on mac. > > > Well that is neat. > > FWIW I have an Android tree but I was building your selinux repo outside of > Android. I personally keep around darwin libsepol.so files built out of > Android for use with setools 4 since it works on Mac's now so I appreciate > any work to make it work better on Mac :) I cant believe that code was actually working, nread was used uninitialized for accessing memory locations within an array.