From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D37F5C433ED for ; Mon, 19 Apr 2021 14:13:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DC7C61090 for ; Mon, 19 Apr 2021 14:13:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DC7C61090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NlhfzPF0KqTRLiWpd32q2u7yjwUfKTuZCmCeWKGpdo0=; b=SGeZMZoftWnLlQMMUC4BG74Zg vEt7pztlF/85WmlL+DSlFciQSHOY7LtKhE4aJ+Ke4POUwyF3MsZ9wZ/ZgvRFEl4b7urLyZmABl7F9 BiyXQL08nV3GbQddPd0DixAE1ph1G0izT9l9cDIZzLEDXMghW1D3SO7uTdKi1nuKHC6SZwZWy53V7 Tea5YlGJLwwNI/+vXZyGGQoDQ9HvKOgFQhtiRQAnR2H20kVgq5rSr34S+OGPY27QXm+lrSY7dKODF u+1DJY37j4M5gS/wiZ8IBsia41pgcTksjtTdJQ3xuqJV7F5pga/jBvQFlzM2JvKePaO7AoZ4bSziJ Wn20ud0yw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYUcQ-00A3ry-6g; Mon, 19 Apr 2021 14:11:18 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYUcO-00A3rp-Fr for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 14:11:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bdzLwtt3efq4i09u78eH4/hKo6SmeavDEDRrKlqLero=; b=HmDtvPe2GGl5X76KocDx6ZMHAX hQ6wFA1vOO2lXHEh9QAmHhb41e5ja5mM/uhPHE3jmEtlHNwjyVzUBeQf2wMqYji/LOi+lEUj58T6K wTJHszhCAhhEcy1SnYUwWqmyoMCjVUckzfjxRPfsCmBmG6qeERBjQXMHPVBSoWl427w0hUufpQXeS 1RuZndADl/+UtCpk7MYLXdshapSdVInbB56yzuvmCMY/oTRDggDGUYcqBz2X86w2pxliIldfIJN8P 8QtxF10EUMZNuWDgtXbU5AEgDNQglqEJMkuBY44g4Nr3hhypumKbt918AkBpB2bnLidJzLEMDaJxm 1MZOzuvw==; Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYUcI-00BR15-FZ for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 14:11:15 +0000 Received: by mail-il1-x134.google.com with SMTP id c4so2646021ilq.9 for ; Mon, 19 Apr 2021 07:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bdzLwtt3efq4i09u78eH4/hKo6SmeavDEDRrKlqLero=; b=I0sV1+kiY4DvEEmPoRmiNsC1pm+lWCZ9RpT8S+XXVDe/uSQcwdZFfn+db4uUVQm3c4 fR4BjhwAACyKKr4gWXDEYF7j/VBSa1H7oLNFvleVvD/pAP3oVotioA3s2yOAbUgS4NlR 7gpNlh7PqwZzRWSXgc3NXl8soiV37IIapyXqeyEO8PwrJvvEdVjpyeqvNlO75qnfroCg r95M61MzJqPrDcyn1bNmc5CGtUyZvNsh8xWlZIzIaWDGFPX5AFxIAsVjsoyQHP5Fm+aF 270kR8H80vZ9JpB2UjakZRx6YNvcXwD3EQkFjP1x5QpbVTGWPr4My4S0wOCAJM7yMek5 odNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bdzLwtt3efq4i09u78eH4/hKo6SmeavDEDRrKlqLero=; b=HeB+h3Q29kTv349YNvxm3gK9dd++E+ALNPN2HHC5UlHsjbfFvJOB/4l7jAQwCkrVSV w6MIn0/znXQtwZxK5zGhcYGow5g+P8OwdJDYUwpPhnILur4uNX8K1lRN6rnQrOnTUvvh vEmJjA3UEI4mYth6Cyk/cZa1LZVH58On6WNd4W874/KFh08XF7ZijNJFNX070diu5Z4P XxDIghujRf5bke54hLGKnn/cgOSKAX/APEo0YGK4RF+6oEGs+7ZyQbZK0u3M3djnpCin P7SPWXVrmUeYAnN6i3Lb849g7iQ4OyXuyrTXELXwIQvBYmpNR76ZjsS/oApZXeEEhcB+ SaKg== X-Gm-Message-State: AOAM530irZX6h8xe49VRJRl7eVMa3xfMCkl4YxYnYbTeJ+y6nOtztpvO AXYVSNVpNz0KdkduzEOYe0tArr4xkdHjvqU/y2MSUIvUAQ== X-Google-Smtp-Source: ABdhPJwbwHUFmajjzS3Ek2k6IhVXEvVkrt+O1fOkuGX99WWJr2VIlxHhHiFCn/K1goVzcicYykgDFZvrHh7cFKuabPQ= X-Received: by 2002:a05:6e02:1e01:: with SMTP id g1mr17368531ila.83.1618841468016; Mon, 19 Apr 2021 07:11:08 -0700 (PDT) MIME-Version: 1.0 References: <20210410095654.24102-1-kernelfans@gmail.com> <20210410095654.24102-9-kernelfans@gmail.com> In-Reply-To: <20210410095654.24102-9-kernelfans@gmail.com> From: Pingfan Liu Date: Mon, 19 Apr 2021 22:10:57 +0800 Message-ID: Subject: Re: [RFC 8/8] arm64/head: convert idmap_pg_dir and init_pg_dir to __create_pgd_mapping() To: Linux ARM Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Kristina Martsenko , James Morse , Steven Price , Jonathan Cameron , Pavel Tatashin , Anshuman Khandual , Atish Patra , Mike Rapoport , Logan Gunthorpe , Mark Brown X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210419_071110_579139_0841AE23 X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 10, 2021 at 5:57 PM Pingfan Liu wrote: > [...] > /* > * Map the kernel image (starting with PHYS_OFFSET). > */ > adrp x0, init_pg_dir > - mov_q x5, KIMAGE_VADDR // compile time __va(_text) > - add x5, x5, x23 // add KASLR displacement > - mov x4, PTRS_PER_PGD > - adrp x6, _end // runtime __pa(_end) > - adrp x3, _text // runtime __pa(_text) > - sub x6, x6, x3 // _end - _text > - add x6, x6, x5 // runtime __va(_end) > + adrp x1, init_pg_end > + sub x1, x1, x0 > + bl set_cur_mempool > > - map_memory x0, x1, x5, x6, x7, x3, x4, x10, x11, x12, x13, x14 > + mov x1, PTRS_PER_PGD > + adrp x3, _text // runtime __pa(_text) > + mov_q x4, KIMAGE_VADDR // compile time __va(_text) > + add x4, x4, x23 // add KASLR displacement > + adrp x5, _end // runtime __pa(_end) > + sub x5, x5, x3 // _end - _text > + > + ldr x3, =PAGE_KERNEL_EXEC > + adr_l x4, head_pgtable_alloc > + mov x5, #0 > + mov x6, #NO_FIXMAP > + > + bl create_init_pgd_mapping This calling convention is wrong, should be changed as the following ( will be updated in v2) adrp x0, init_pg_dir adrp x1, init_pg_end sub x1, x1, x0 bl set_cur_mempool mov x0, #0 mov x0, #0 bl head_pgtable_alloc // x0 is init_pg_dir adrp x1, _text // runtime __pa(_text) mov_q x2, KIMAGE_VADDR // compile time __va(_text) add x2, x2, x23 // add KASLR displacement adrp x3, _end // runtime __pa(_end) sub x3, x3, x1 // _end - _text ldr x4, =PAGE_KERNEL_EXEC adr_l x5, head_pgtable_alloc mov x6, #0 mov x7, #(NO_FIXMAP | NO_PRINTK | BOOT_HEAD) bl create_init_pgd_mapping Thanks, Pingfan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel