From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6741AC433FE for ; Tue, 8 Dec 2020 09:44:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B69523A9B for ; Tue, 8 Dec 2020 09:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728990AbgLHJoY (ORCPT ); Tue, 8 Dec 2020 04:44:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727961AbgLHJoX (ORCPT ); Tue, 8 Dec 2020 04:44:23 -0500 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EF85C0613D6 for ; Tue, 8 Dec 2020 01:43:37 -0800 (PST) Received: by mail-io1-xd44.google.com with SMTP id q137so16291814iod.9 for ; Tue, 08 Dec 2020 01:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zOfSXZUZHFJ0/IMjArCSIU3fFYQ+AgSZyhk4SA6mvo8=; b=TURij3foAEti0mrje6JLTCEE3aN72QYT63E09q6MeQ1zqxm3dsKZao3Ot6C0mRnuKR f8Xg8CNH/AdX05HE1SF3OUZIYkbn8GRFyAYgaKrJziOyJRGu+my5MKdzw3ueT3yAdS84 a9QKCvlrroKrK0tdC35re585Rgl3XVqUfas8ayW5qO76FjHfUzx0eVTI0D9Ha6AOE+Lr C5xypVLohQ9OyKRzRMZTUIZzn8EJABqz3I+P1CPDN4TQrAtTI1UU1qAEDDBf70CFaDrf 1mJnX/RCZl44lixvN1KlX5vuGELgix8pCppYtXR0Y8wdLhwm2hRQcOlSAh7aQ8s8t5eQ F5mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zOfSXZUZHFJ0/IMjArCSIU3fFYQ+AgSZyhk4SA6mvo8=; b=r5LZ8aN94Hgibi6seVvq6vofDoA8lXfKfaRLNQUC/qYJquq0EeD1WBgg4/eL14hd9A HXaS6PhHtuIyfAJ+iPBVi95YS5uX/UtfqpaD2n3nCS9e14uMN5GOmxkKmblKUKuDaEjj tJqi00fXwr9W9l1eDAEJPK122NaDeqKWyJZbLMLxxBx6j7rq/usCIJ+DCGHnXwbQXfAk rcoBKqzvRVDMAI+ABaLyzm8E28BwCJNh/ZFX13NWklq12yylCGyQgCYO41c28adrcDUu Fju3G6NYCNA/xFrQOs3/OkdmzgXuydlAEppRkP6uh9787uKwC4MiHRJPXP9cnLGF6NRR A6rg== X-Gm-Message-State: AOAM533ygjUUYLW+N18WBRonv1t4aiyCnB0+gSIlXVIWG11kAJAFS8TX 5hwwoioEwOV524ymCvNTaOjwfBORokb8CgYZPA== X-Google-Smtp-Source: ABdhPJybwfILFe99lXBifqW5iw2cLCWEzWjRS0cwJ+NP2ueNhNCk6av7UDI29nA9alC0A/gvVVvSsPzjZnimDM/y9ZE= X-Received: by 2002:a5e:c609:: with SMTP id f9mr23831527iok.41.1607420616820; Tue, 08 Dec 2020 01:43:36 -0800 (PST) MIME-Version: 1.0 References: <1607419304-26140-1-git-send-email-kernelfans@gmail.com> <0f230af42ff4c6e4cf763b9145fb9487@kernel.org> In-Reply-To: <0f230af42ff4c6e4cf763b9145fb9487@kernel.org> From: Pingfan Liu Date: Tue, 8 Dec 2020 17:43:25 +0800 Message-ID: Subject: Re: [PATCH] arm64/irq: report bug if NR_IPI greater than max SGI during compile time To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Thomas Gleixner , Jason Cooper , Mark Rutland , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 8, 2020 at 5:31 PM Marc Zyngier wrote: > > On 2020-12-08 09:21, Pingfan Liu wrote: > > Although there is a runtime WARN_ON() when NR_IPR > max SGI, it had > > better > > do the check during built time, and associate these related code > > together. > > > > Signed-off-by: Pingfan Liu > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Thomas Gleixner > > Cc: Jason Cooper > > Cc: Marc Zyngier > > Cc: Mark Rutland > > To: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > --- > > arch/arm64/kernel/smp.c | 2 ++ > > drivers/irqchip/irq-gic-v3.c | 2 +- > > drivers/irqchip/irq-gic.c | 2 +- > > include/linux/irqchip/arm-gic-common.h | 2 ++ > > 4 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > > index 18e9727..9fc383c 100644 > > --- a/arch/arm64/kernel/smp.c > > +++ b/arch/arm64/kernel/smp.c > > @@ -33,6 +33,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -76,6 +77,7 @@ enum ipi_msg_type { > > IPI_WAKEUP, > > NR_IPI > > }; > > +static_assert(NR_IPI <= MAX_SGI_NUM); > > I am trying *very hard* to remove dependencies between the architecture > code and random drivers, so this kind of check really is > counter-productive. > > Driver code should not have to know the number of IPIs, because there is > no requirement that all IPIs should map 1:1 to SGIs. Conflating the two Just curious about this. Is there an IPI which is not implemented by SGI? Or mapping several IPIs to a single SGI, and scatter out due to a global variable value? Thanks, Pingfan > is already wrong, and I really don't want to add more of that. > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 231B8C433FE for ; Tue, 8 Dec 2020 09:44:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98E0A23A82 for ; Tue, 8 Dec 2020 09:44:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98E0A23A82 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hdza03sG/TvnpEBQKru6zwXjBTmHBdLGEiUaZVWez50=; b=LYuybw5pn2MASsfNJAE4zbArz b7Gdzq9+OZPg7DeEM6FkkhKjD+kME9NZ4dWFOsCmzVPVIaYED5TbJUxz0L7rAwqBXsfSSXnZ03FCT ojMnqspa40kan+CWKC6JA5/9t7NRGG0HGashejwBcanVjqCxJWRB5V1ONJUTo8t0jhsqhnfTvB7Vv +Ve5LQEm4YxYmCxoHNtXU1ZUElINmBRXdEW3XvRr8I/qIII5b86L0/FVAWwJiMSyTUuRbA/g/n3PZ GSAYWn/2PslGP5H3duLDMhf6pa81+a8wzI2IGAzyl4IsT3ZVEL/seZfK9LHZLuVStY+DfzWvqI3I3 gHHTPfGHA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmZX2-0003Fq-Vf; Tue, 08 Dec 2020 09:43:41 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmZX1-0003FC-2c for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 09:43:39 +0000 Received: by mail-io1-xd43.google.com with SMTP id t8so16296559iov.8 for ; Tue, 08 Dec 2020 01:43:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zOfSXZUZHFJ0/IMjArCSIU3fFYQ+AgSZyhk4SA6mvo8=; b=TURij3foAEti0mrje6JLTCEE3aN72QYT63E09q6MeQ1zqxm3dsKZao3Ot6C0mRnuKR f8Xg8CNH/AdX05HE1SF3OUZIYkbn8GRFyAYgaKrJziOyJRGu+my5MKdzw3ueT3yAdS84 a9QKCvlrroKrK0tdC35re585Rgl3XVqUfas8ayW5qO76FjHfUzx0eVTI0D9Ha6AOE+Lr C5xypVLohQ9OyKRzRMZTUIZzn8EJABqz3I+P1CPDN4TQrAtTI1UU1qAEDDBf70CFaDrf 1mJnX/RCZl44lixvN1KlX5vuGELgix8pCppYtXR0Y8wdLhwm2hRQcOlSAh7aQ8s8t5eQ F5mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zOfSXZUZHFJ0/IMjArCSIU3fFYQ+AgSZyhk4SA6mvo8=; b=fFA8fo7deY+CaQVr7pyUCn5mEgdkdNVxkNQWTiZOGsKbz9Ewa+DBxP9E2WNxgSqrgE vgmywIXFol58Z5f6HaR6wAsy747z4g93+IYHYb1ro702a5JGoG2OmPrRXNiGk6WcG+8Y BJS3zzqlIMRcbTXGExlF2YkHk24QSxEfwVJjV30jCtBxZSgePdoO5AKrilT+oEN9AnXR xYrbq43KyspHrZVH9mZfMKSCQixjzDRn2JHlIuEZkNHHkKFJptSC39M6Aed2H/9H8K2e lpdpaukiAHBfSA0o3PkN9BBp+55Iuo+M7FciP34tfwftIw/v4/gamY0EorG4MgOEAZbW 9J5g== X-Gm-Message-State: AOAM532nsuB6+mNCAwHeQGfsUs0lvfzYN7h2Lv7S0TXzBTs4ytNtdb6F h/nbVlGdqew6283fdIlX8FwYDCJslGKWXgt/KQ== X-Google-Smtp-Source: ABdhPJybwfILFe99lXBifqW5iw2cLCWEzWjRS0cwJ+NP2ueNhNCk6av7UDI29nA9alC0A/gvVVvSsPzjZnimDM/y9ZE= X-Received: by 2002:a5e:c609:: with SMTP id f9mr23831527iok.41.1607420616820; Tue, 08 Dec 2020 01:43:36 -0800 (PST) MIME-Version: 1.0 References: <1607419304-26140-1-git-send-email-kernelfans@gmail.com> <0f230af42ff4c6e4cf763b9145fb9487@kernel.org> In-Reply-To: <0f230af42ff4c6e4cf763b9145fb9487@kernel.org> From: Pingfan Liu Date: Tue, 8 Dec 2020 17:43:25 +0800 Message-ID: Subject: Re: [PATCH] arm64/irq: report bug if NR_IPI greater than max SGI during compile time To: Marc Zyngier X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_044339_140133_D67C1EA2 X-CRM114-Status: GOOD ( 22.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Jason Cooper , Catalin Marinas , LKML , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 8, 2020 at 5:31 PM Marc Zyngier wrote: > > On 2020-12-08 09:21, Pingfan Liu wrote: > > Although there is a runtime WARN_ON() when NR_IPR > max SGI, it had > > better > > do the check during built time, and associate these related code > > together. > > > > Signed-off-by: Pingfan Liu > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Thomas Gleixner > > Cc: Jason Cooper > > Cc: Marc Zyngier > > Cc: Mark Rutland > > To: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > --- > > arch/arm64/kernel/smp.c | 2 ++ > > drivers/irqchip/irq-gic-v3.c | 2 +- > > drivers/irqchip/irq-gic.c | 2 +- > > include/linux/irqchip/arm-gic-common.h | 2 ++ > > 4 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > > index 18e9727..9fc383c 100644 > > --- a/arch/arm64/kernel/smp.c > > +++ b/arch/arm64/kernel/smp.c > > @@ -33,6 +33,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -76,6 +77,7 @@ enum ipi_msg_type { > > IPI_WAKEUP, > > NR_IPI > > }; > > +static_assert(NR_IPI <= MAX_SGI_NUM); > > I am trying *very hard* to remove dependencies between the architecture > code and random drivers, so this kind of check really is > counter-productive. > > Driver code should not have to know the number of IPIs, because there is > no requirement that all IPIs should map 1:1 to SGIs. Conflating the two Just curious about this. Is there an IPI which is not implemented by SGI? Or mapping several IPIs to a single SGI, and scatter out due to a global variable value? Thanks, Pingfan > is already wrong, and I really don't want to add more of that. > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel