From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2305C433E0 for ; Mon, 3 Aug 2020 02:08:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 717DF206E9 for ; Mon, 3 Aug 2020 02:08:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tS8scoNn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rFungbdR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 717DF206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0zoYyo4QSXVKiaq664BB5Cf57oSFj3ed5vRmzvRcBAk=; b=tS8scoNnWA+X7mX1+eBuppMk/ G2nKjELdSIgC4EObBzpCRmVNYWAs4EPnvsQEN0Op1RnCRdwwptOLTxfXoluwIVks1RPxcaxK9AR+t wBRIowwtH1SHySMdV9cBLUC6g+eMqwOkRnaRF5CVAiGtg68gpyu2x0NXoHSMEWBiyARTZdGZivSyB JWfY6f3e6M3eBDaJ2YDtIdpAmXyyFY0gwuiPKDvWPzTzdiHzhrMW62qikXHwcxQIa2XqO2mhavuNm vZvyTOlg4cyrabUj1HXo/kxb+lh6ERiyaqTd6a/XEyKvUagXWZtrm7ltrCIVyDXj6SA+zA+zV1+uf /paAXnmlA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2Pt0-0008Io-Cv; Mon, 03 Aug 2020 02:07:34 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2Psx-0008IE-RH for linux-arm-kernel@lists.infradead.org; Mon, 03 Aug 2020 02:07:32 +0000 Received: by mail-io1-xd41.google.com with SMTP id w12so23427490iom.4 for ; Sun, 02 Aug 2020 19:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gHzCSIEPE1vFIodPVDO3yCO34ai8roWeSPngsq6jlGw=; b=rFungbdRIqvE/QRSv4sKMOYke1dMFK+Qv/643E0+XXg+vtIVjiYbYbUE0gq1mPfLf9 jeSYsP1znGZ5ckZZPPzKkcqsIWeLg8VbxK6lDCdydkiQp8kXaFEqQuyyJhlNReqNdz8p uLKEfjuIDVXVAK4VGadyCetqypIRIEBm3pW40EyG/Hm0y5ybBW7t5xbaETFNVFZpxp2C iJaiykJRl9Ql2xdzeHQ3KWR6X9a7fVeKKTShgwvuN/Hr9YibUM/orF4VFrtwAG758Vmb izGdj6FZYBfPUCCVkuF/GT7C/ArPP4Q4anFW0IkQJBhV7ZID24bjSnTCi2sElBS+XZNM 7BxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gHzCSIEPE1vFIodPVDO3yCO34ai8roWeSPngsq6jlGw=; b=YPdSYq7jaC85wYjy6VFZ6vNFHzHM14J+Jm8p8n2Tc4e3fslFHJJJz4qSilRHB1SBUn paP1Uc2N0nEsWj8m6ANo3Ov53R4kuClRrMDd00jUTlmamgjnLCrjHvkhG/6i+KUQA45o xwhLkMSdyUTvI0U7w/9Sb6SUJ+YLzjPFkmJ1w/fd03XphRkzaSCiLhekvEhJRuX2U+CU B6oUvE/7voD/gW/4KU7QYH5qLYZnx13LVYwYfywlsoT3/OAg74HpFmSx+fVaD9KhWakK 0oMiVpL59FDmAeu+ztu/Boq++mEQKRy410457ZXl4nUfXgERIlip6p34tojgPEU2BvUk i3IQ== X-Gm-Message-State: AOAM531DU6r2tJT9fNjHzl+jyuRbogfbOTOMdsE9jSdy6kayJFFn+sVq /H8oFO+gb+poDvb+lJP3gmmXa6g4sZrnjWGhKg== X-Google-Smtp-Source: ABdhPJzY7BjrcWlq1RGsJ4An9zyOr9wvuxUPzvDFvXEZdTPGHrCPu8e7/Jcx9fAmqI52QswhzRzOOVaDEL1/gd5hzyU= X-Received: by 2002:a02:95ab:: with SMTP id b40mr17263695jai.14.1596420448013; Sun, 02 Aug 2020 19:07:28 -0700 (PDT) MIME-Version: 1.0 References: <1594388602-17790-1-git-send-email-kernelfans@gmail.com> <20200730110937.GH25149@gaia> <20200731121334.GC29569@gaia> In-Reply-To: <20200731121334.GC29569@gaia> From: Pingfan Liu Date: Mon, 3 Aug 2020 10:07:16 +0800 Message-ID: Subject: Re: [PATCH] arm64/fixmap: make notes of fixed_addresses more precisely To: Catalin Marinas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200802_220731_983973_90C51035 X-CRM114-Status: GOOD ( 24.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 31, 2020 at 8:13 PM Catalin Marinas wrote: > > On Fri, Jul 31, 2020 at 10:47:13AM +0800, Pingfan Liu wrote: > > On Thu, Jul 30, 2020 at 7:09 PM Catalin Marinas wrote: > > > On Fri, Jul 10, 2020 at 09:43:22PM +0800, Pingfan Liu wrote: > > > > These 'compile-time allocated' memory buffers can occupy more than one > > > > page. So improve the note about it. > > > > > > > > Signed-off-by: Pingfan Liu > > > > Cc: Catalin Marinas > > > > Cc: Will Deacon > > > > To: linux-arm-kernel@lists.infradead.org > > > > --- > > > > arch/arm64/include/asm/fixmap.h | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h > > > > index f987b8a..318aee1 100644 > > > > --- a/arch/arm64/include/asm/fixmap.h > > > > +++ b/arch/arm64/include/asm/fixmap.h > > > > @@ -29,7 +29,8 @@ > > > > * in the boot process. > > > > * > > > > * These 'compile-time allocated' memory buffers are > > > > - * page-sized. Use set_fixmap(idx,phys) to associate > > > > + * page-sized (or larger if used with an increment > > > > + * higher than 1). Use set_fixmap(idx,phys) to associate > > > > * physical memory with fixmap indices. > > > > > > I don't get this. set_fixmap() only maps a page. Also, what's > > > "increment" in this context? > > > > I refer to the notes in the counterpart in x86. And for the time > > being, it is the case for the ranges (FIX_FDT, FIX_FDT_END), which may > > cost more than one page size. > > OK, so increment refers to the enum increment. But if we update this, we > also need to state that set_fixmap() only maps page-size buffers, > otherwise one may think that set_fixmap(FIX_FDT, phys) maps the whole > FDT. We could say that each enum increment represents a page-sized > buffer. What about description like: diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h index f987b8a..4335800 100644 --- a/arch/arm64/include/asm/fixmap.h +++ b/arch/arm64/include/asm/fixmap.h @@ -28,10 +28,9 @@ * compile time, but to set the physical address only * in the boot process. * - * These 'compile-time allocated' memory buffers are - * page-sized. Use set_fixmap(idx,phys) to associate - * physical memory with fixmap indices. - * + * Each enum increment in these 'compile-time allocated' + * memory buffers is page-sized. Use set_fixmap(idx,phys) + * to associate physical memory with a fixmap index. */ Thanks, Pingfan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel