All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ley Foon Tan <lftan.linux@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 05/19] arm: socfpga: Add A10 macros
Date: Fri, 7 Apr 2017 08:32:52 +0800	[thread overview]
Message-ID: <CAFiDJ5_vb0EDXXst3M8HG7=45t0OiBiEBuWoAwP6xk7MshBxNQ@mail.gmail.com> (raw)
In-Reply-To: <CADhT+wfgpgUpVuQ6C5QFsqFN6oS-n+ymA_4GWU++Ma56BxgAeA@mail.gmail.com>

On Thu, Apr 6, 2017 at 10:10 PM, Dinh Nguyen <dinh.linux@gmail.com> wrote:
> On Wed, Apr 5, 2017 at 4:32 AM, Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>> Add i2c, timer and other A10 macros.
>>
>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>> ---
>>  arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
>> index a7056d4..448fbdc 100644
>> --- a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
>> +++ b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
>> @@ -1,5 +1,5 @@
>>  /*
>> - * Copyright (C) 2014 Altera Corporation <www.altera.com>
>> + * Copyright (C) 2014-2017 Altera Corporation <www.altera.com>
>>   *
>>   * SPDX-License-Identifier:    GPL-2.0+
>>   */
>> @@ -29,14 +29,20 @@
>>  #define SOCFPGA_MPUL2_ADDRESS                  0xfffff000
>>  #define SOCFPGA_I2C0_ADDRESS                   0xffc02200
>>  #define SOCFPGA_I2C1_ADDRESS                   0xffc02300
>> +#define SOCFPGA_I2C2_ADDRESS                   0xffc02400
>> +#define SOCFPGA_I2C3_ADDRESS                   0xffc02500
>> +#define SOCFPGA_I2C4_ADDRESS                   0xffc02600
>
> I made this comment in V3, and I'll make it again. Do we need to add
> these when we can use DTS for the I2C driver?
>
We haven't enable CONFIG_DM_I2C for i2c in this patch series, so it
still using older device model and these macros are still required in
socfpga_common.h (#define CONFIG_SYS_I2C_BASE
SOCFPGA_I2C0_ADDRESS).

Regards
Ley Foon

  reply	other threads:[~2017-04-07  0:32 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05  9:32 [U-Boot] [PATCH v4 00/19] Add Intel Arria 10 SoC support Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 01/19] arm: socfpga: Restructure clock manager driver Ley Foon Tan
2017-04-05 19:12   ` Dinh Nguyen
2017-04-06  8:31     ` Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 02/19] arm: socfpga: Restructure reset " Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 03/19] arm: socfpga: Restructure system manager Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 04/19] arm: socfpga: Restructure misc driver Ley Foon Tan
2017-04-05 10:39   ` Marek Vasut
2017-04-06  5:37     ` Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 05/19] arm: socfpga: Add A10 macros Ley Foon Tan
2017-04-06 14:10   ` Dinh Nguyen
2017-04-07  0:32     ` Ley Foon Tan [this message]
2017-04-05  9:32 ` [U-Boot] [PATCH v4 06/19] arm: socfpga: Add reset driver support for Arria 10 Ley Foon Tan
2017-04-06 19:37   ` Dinh Nguyen
2017-04-07  7:43     ` Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 07/19] arm: socfpga: Add clock driver " Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 08/19] arm: socfpga: Add system manager " Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 09/19] arm: socfpga: Add sdram header file " Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 10/19] arm: socfpga: Add misc support " Ley Foon Tan
2017-04-05 10:40   ` Marek Vasut
2017-04-06  3:20     ` Ley Foon Tan
2017-04-06 10:17       ` Marek Vasut
2017-04-07  0:33         ` Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 11/19] arm: socfpga: Add pinmux " Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 12/19] fdt: Add compatible strings " Ley Foon Tan
2017-04-05 10:41   ` Marek Vasut
2017-04-15 16:06   ` Simon Glass
2017-04-05  9:32 ` [U-Boot] [PATCH v4 13/19] arm: dts: Add dts and dtsi " Ley Foon Tan
2017-04-10 14:50   ` Dinh Nguyen
2017-04-11  5:50     ` Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 14/19] arm: socfpga: Add SPL support " Ley Foon Tan
2017-04-10 20:43   ` Dinh Nguyen
2017-04-10 22:05     ` Dinh Nguyen
2017-04-11  3:42       ` Dinh Nguyen
2017-04-11  5:48         ` Ley Foon Tan
2017-04-11 12:28           ` Dinh Nguyen
2017-04-11 10:35         ` Marek Vasut
2017-04-11  5:45     ` Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 15/19] drivers: fpga: Add compile switch for Gen5 only registers Ley Foon Tan
2017-04-07 14:26   ` Dinh Nguyen
2017-04-10  7:44     ` Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 16/19] arm: socfpga: Convert Altera DDR SDRAM driver to use Kconfig Ley Foon Tan
2017-04-05 10:44   ` Marek Vasut
2017-04-05  9:32 ` [U-Boot] [PATCH v4 17/19] arm: socfpga: Add config and defconfig for Arria 10 Ley Foon Tan
2017-04-07 14:17   ` Dinh Nguyen
2017-04-10  7:40     ` Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 18/19] arm: socfpga: Add board files for the Arria10 Ley Foon Tan
2017-04-05  9:32 ` [U-Boot] [PATCH v4 19/19] arm: socfpga: Enable build for Arria 10 Ley Foon Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFiDJ5_vb0EDXXst3M8HG7=45t0OiBiEBuWoAwP6xk7MshBxNQ@mail.gmail.com' \
    --to=lftan.linux@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.