From: "Douglas" <douglas.royds@taitradio.com>
To: Jose Quaresma <quaresma.jose@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/3] Revert "icecc: Don't use icecc when INHIBIT_DEFAULT_DEPS is set"
Date: Thu, 27 May 2021 11:26:14 +1200 [thread overview]
Message-ID: <CAFimOt4dFtpWBu0c0a9-qCU6g+wQ2_2LgmBJvFyNf_0SZs0_vQ@mail.gmail.com> (raw)
In-Reply-To: <CANPvuRkM5FqLWRFAeWpi9ckhwcL-tcmur7OjW5bQwhcAPxCUug@mail.gmail.com>
Yes, we could, but it's quite a long list, and I'm reluctant to start
naming specific packages.
I only did the INHIBIT_DEFAULT_DEPS test (that I'm reverting here) in
the first place to silence the warnings. I think demoting these
warnings to notes is a better solution.
On Wed, 26 May 2021 at 20:52, Jose Quaresma <quaresma.jose@gmail.com> wrote:
>
> Hi,
>
> Instead of reverting we can add an exception for the packages you mentioned:
> gcc-cross and friends, binutils-cross, and importantly, the linux kernel.
>
> Douglas via lists.openembedded.org
> <douglas.royds=taitradio.com@lists.openembedded.org> escreveu no dia
> quarta, 26/05/2021 à(s) 01:28:
> >
> > Although this silenced the warnings, it also turned off icecc for
> > gcc-cross and friends, binutils-cross, and importantly, the linux
> > kernel.
> >
> > This reverts commit 0315aabeff8e6483b737d0e23d6841f1394ad3c8.
> >
> > [YOCTO #13863]
> >
> > Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> > ---
> > meta/classes/icecc.bbclass | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
> > index d095305ed8..0dde960e7a 100644
> > --- a/meta/classes/icecc.bbclass
> > +++ b/meta/classes/icecc.bbclass
> > @@ -138,10 +138,6 @@ def use_icecc(bb,d):
> > if icecc_is_cross_canadian(bb, d):
> > return "no"
> >
> > - if d.getVar('INHIBIT_DEFAULT_DEPS', False):
> > - # We don't have a compiler, so no icecc
> > - return "no"
> > -
> > pn = d.getVar('PN')
> > bpn = d.getVar('BPN')
> >
> > --
> > 2.25.1
> >
> >
> >
> >
>
>
> --
> Best regards,
>
> José Quaresma
--
This Communication is Confidential. We only send and receive email on the
basis of the terms set out at www.taitradio.com/email_disclaimer
<http://www.taitradio.com/email_disclaimer>
next prev parent reply other threads:[~2021-05-26 23:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 0:27 [PATCH 0/3] icecc: Silence warnings Douglas
2021-05-26 0:27 ` [PATCH 1/3] Revert "icecc: Don't use icecc when INHIBIT_DEFAULT_DEPS is set" Douglas
2021-05-26 8:51 ` [OE-core] " Jose Quaresma
2021-05-26 23:26 ` Douglas [this message]
2021-05-27 9:45 ` Jose Quaresma
2021-05-26 0:27 ` [PATCH 2/3] icecc: Demote "could not get ICECC_CC" warning to note Douglas
2021-05-26 0:27 ` [PATCH 3/3] icecc-create-env: Silence warning: invalid ICECC_ENV_EXEC Douglas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFimOt4dFtpWBu0c0a9-qCU6g+wQ2_2LgmBJvFyNf_0SZs0_vQ@mail.gmail.com \
--to=douglas.royds@taitradio.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=quaresma.jose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.