From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45ED5C4743F for ; Fri, 4 Jun 2021 20:36:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 299E4613F9 for ; Fri, 4 Jun 2021 20:36:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231343AbhFDUht (ORCPT ); Fri, 4 Jun 2021 16:37:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46402 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230256AbhFDUhr (ORCPT ); Fri, 4 Jun 2021 16:37:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622838960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y6Thexy0S9yAdfMWlPeLLADSbYeQgKUJsnhXYbRk/4M=; b=XhS0Br0O+o0blnT7o3ulVnwPwfgJD7netfTE2epzrL41F0gAsKz+nepOOSeHokqc+boWY8 yjmv57YuZbcm3X7MJz6rJjcZIDpVkQpKSSWOZqbrgmQY8Ay5s09gruRE4T1T1UsmxwxCt7 n37bbkGUNX6bB2noViH5nSqIHOV1NzI= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-xnlAssCDNUKLJfODn021xw-1; Fri, 04 Jun 2021 16:35:59 -0400 X-MC-Unique: xnlAssCDNUKLJfODn021xw-1 Received: by mail-lj1-f200.google.com with SMTP id q18-20020a05651c0552b02900ef6822c5fdso4777056ljp.3 for ; Fri, 04 Jun 2021 13:35:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y6Thexy0S9yAdfMWlPeLLADSbYeQgKUJsnhXYbRk/4M=; b=iFFhjbUc8UCFN/m1mgJLWCxGaHDQUpSq9k2SzeD0qof4sMMJ4pKYdTBKAG0zniPyGw HhzMsov5FqqK62/toB1B5WNFPBoKpGLHHJlp79ZGHieZ6tzJT2Ax9MTcPqrEaI7ENW/G dILmQTfWdZqZcSxUgtsLaLcSIP0CRb30ziMtBiDv8dPFXaum3VydELWrKh76iFCma+IZ KVmqQZSWm/cacERe9dOirxMSw9aHSGY074Yz/DTf2iUD1LaLwMcUYdByYQAeYWRP4NPX bfzFt3mmceExJEsqbjIHDs+xw4Oulbghb94B32BybkG7j70MFMfCbW9rJUGHaoS8esFa kTIg== X-Gm-Message-State: AOAM530LRNleYHyQtqEdHKH8IeLiDX8qNpYlttEWL4xXlMKxUmuZtBWD 6v2vpQ5eue9uvEVfHKi6iWcBi5Z6xRtQA0/4tN6HuKSEnBxKycfQwfkU3sOWmaXeUZi5Xn5SDzA Dn/gyAogF3kA3iPd6Sf+ZIPiQmckBmkO/yTVODbc4 X-Received: by 2002:a2e:83ce:: with SMTP id s14mr4802974ljh.30.1622838957647; Fri, 04 Jun 2021 13:35:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyA8sfpDISd7W3a8IsW6/YiM57Zw+/p+NaHoiuAPg8X6bW9cLXRUw/b5biIXrpjtTnIR6xsL3IgHzsQtEI3hbs= X-Received: by 2002:a2e:83ce:: with SMTP id s14mr4802957ljh.30.1622838957476; Fri, 04 Jun 2021 13:35:57 -0700 (PDT) MIME-Version: 1.0 References: <20210504092340.00006c61@intel.com> <87pmxpdr32.ffs@nanos.tec.linutronix.de> <87im3gewlu.ffs@nanos.tec.linutronix.de> <87zgwo9u79.ffs@nanos.tec.linutronix.de> <87wnrs9tvp.ffs@nanos.tec.linutronix.de> <87bl93ahc4.ffs@nanos.tec.linutronix.de> In-Reply-To: <87bl93ahc4.ffs@nanos.tec.linutronix.de> From: Nitesh Lal Date: Fri, 4 Jun 2021 16:35:45 -0400 Message-ID: Subject: Re: [PATCH] genirq: Provide new interfaces for affinity hints To: Thomas Gleixner Cc: Jesse Brandeburg , Robin Murphy , Marcelo Tosatti , Ingo Molnar , linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, jbrandeb@kernel.org, "frederic@kernel.org" , "juri.lelli@redhat.com" , Alex Belits , "linux-api@vger.kernel.org" , "bhelgaas@google.com" , "linux-pci@vger.kernel.org" , "rostedt@goodmis.org" , "peterz@infradead.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "sfr@canb.auug.org.au" , "stephen@networkplumber.org" , "rppt@linux.vnet.ibm.com" , "jinyuqi@huawei.com" , "zhangshaokun@hisilicon.com" , netdev@vger.kernel.org, chris.friesen@windriver.com, Marc Zyngier , Neil Horman , pjwaskiewicz@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 5:48 PM Thomas Gleixner wrote: > > On Fri, May 21 2021 at 12:13, Nitesh Lal wrote: > > On Fri, May 21, 2021 at 8:03 AM Thomas Gleixner wrote: > >> Provide new interfaces: > >> > >> irq_update_affinity_hint() - Only sets the affinity hint pointer > >> irq_apply_affinity_hint() - Set the pointer and apply the affinity to > >> the interrupt > >> > > > > Any reason why you ruled out the usage of irq_set_affinity_and_hint()? > > IMHO the latter makes it very clear what the function is meant to do. > > You're right. I was trying to phase the existing hint setter out, but > that's probably pointless overengineering for no real value. Let me redo > that. > Thomas, are you planning to send a v2 for this soon or did I somehow miss it? Since your other patch "genirq: Export affinity setter for modules" is already in linux-next, I have started looking into the drivers where we can use that. On thinking about this whole chunk a little more, I do wonder about the reason why we are still sticking with the hints. The two reasons that I could come up with are: - We are not entirely sure if irqbalance still consumes this or not - For future use by some other userspace daemon (?) Does that sound right? -- Thanks Nitesh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nitesh Lal Date: Fri, 4 Jun 2021 16:35:45 -0400 Subject: [Intel-wired-lan] [PATCH] genirq: Provide new interfaces for affinity hints In-Reply-To: <87bl93ahc4.ffs@nanos.tec.linutronix.de> References: <20210504092340.00006c61@intel.com> <87pmxpdr32.ffs@nanos.tec.linutronix.de> <87im3gewlu.ffs@nanos.tec.linutronix.de> <87zgwo9u79.ffs@nanos.tec.linutronix.de> <87wnrs9tvp.ffs@nanos.tec.linutronix.de> <87bl93ahc4.ffs@nanos.tec.linutronix.de> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Fri, May 21, 2021 at 5:48 PM Thomas Gleixner wrote: > > On Fri, May 21 2021 at 12:13, Nitesh Lal wrote: > > On Fri, May 21, 2021 at 8:03 AM Thomas Gleixner wrote: > >> Provide new interfaces: > >> > >> irq_update_affinity_hint() - Only sets the affinity hint pointer > >> irq_apply_affinity_hint() - Set the pointer and apply the affinity to > >> the interrupt > >> > > > > Any reason why you ruled out the usage of irq_set_affinity_and_hint()? > > IMHO the latter makes it very clear what the function is meant to do. > > You're right. I was trying to phase the existing hint setter out, but > that's probably pointless overengineering for no real value. Let me redo > that. > Thomas, are you planning to send a v2 for this soon or did I somehow miss it? Since your other patch "genirq: Export affinity setter for modules" is already in linux-next, I have started looking into the drivers where we can use that. On thinking about this whole chunk a little more, I do wonder about the reason why we are still sticking with the hints. The two reasons that I could come up with are: - We are not entirely sure if irqbalance still consumes this or not - For future use by some other userspace daemon (?) Does that sound right? -- Thanks Nitesh