From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbeBEXtU (ORCPT ); Mon, 5 Feb 2018 18:49:20 -0500 Received: from mail-vk0-f66.google.com ([209.85.213.66]:33626 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbeBEXtN (ORCPT ); Mon, 5 Feb 2018 18:49:13 -0500 X-Google-Smtp-Source: AH8x2274HpmX3IkkYv1dV8AFOJbUgSsrWzpV09Oon/APOG1hKjpD7wLPtzRgACGcGbjkQ9NH7fbvXTVCqR7lQf6iHEE= MIME-Version: 1.0 In-Reply-To: References: <20180205012146.23981-1-ulfalizer@gmail.com> <20180205012146.23981-8-ulfalizer@gmail.com> From: Ulf Magnusson Date: Tue, 6 Feb 2018 00:49:11 +0100 Message-ID: Subject: Re: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select To: Linus Walleij Cc: "linux-kernel@vger.kernel.org" , linux-kbuild , tfiga@chromium.org, paul.burton@mips.com, Marek Szyprowski , Hans-Christian Egtvedt , Vineet Gupta , mgorman@techsingularity.net, Christoph Hellwig , mina86@mina86.com, Rob Herring , Stephen Boyd , Paul Mackerras , Will Deacon , ext Tony Lindgren , Nicholas Piggin , Masahiro Yamada , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 6, 2018 at 12:38 AM, Ulf Magnusson wrote: > On Tue, Feb 6, 2018 at 12:25 AM, Linus Walleij wrote: >> On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson wrote: >> >>> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 >>> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should >>> just be selected explicitly if needed. >>> >>> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. >>> >>> See commit 0145071b3314 ("x86: Do away with >>> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do >>> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. >>> >>> Discovered with the >>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >>> script. >>> >>> Signed-off-by: Ulf Magnusson >> >> This should probaly be replaced with >> select GPIOLIB >> >> Yours, >> Linus Walleij > > That'd make more sense if GPIOLIB is actually used. The select has > been a no-op since mid-2016 at least, but maybe something else selects > GPIOLIB. > > Cheers, > Ulf Just replace it with your own patch once you've figured out the proper fix. More efficient than having a middle man making (sometimes poor) guesses. Cheers, Ulf From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulfalizer@gmail.com (Ulf Magnusson) Date: Tue, 6 Feb 2018 00:49:11 +0100 Subject: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select In-Reply-To: References: <20180205012146.23981-1-ulfalizer@gmail.com> <20180205012146.23981-8-ulfalizer@gmail.com> Message-ID: To: linux-riscv@lists.infradead.org List-Id: linux-riscv.lists.infradead.org On Tue, Feb 6, 2018 at 12:38 AM, Ulf Magnusson wrote: > On Tue, Feb 6, 2018 at 12:25 AM, Linus Walleij wrote: >> On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson wrote: >> >>> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743 >>> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should >>> just be selected explicitly if needed. >>> >>> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV. >>> >>> See commit 0145071b3314 ("x86: Do away with >>> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do >>> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well. >>> >>> Discovered with the >>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >>> script. >>> >>> Signed-off-by: Ulf Magnusson >> >> This should probaly be replaced with >> select GPIOLIB >> >> Yours, >> Linus Walleij > > That'd make more sense if GPIOLIB is actually used. The select has > been a no-op since mid-2016 at least, but maybe something else selects > GPIOLIB. > > Cheers, > Ulf Just replace it with your own patch once you've figured out the proper fix. More efficient than having a middle man making (sometimes poor) guesses. Cheers, Ulf