From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Fan Date: Fri, 27 Apr 2018 12:05:57 +0000 Subject: [Buildroot] [PATCH] package/ncurses: enable widechar for host build In-Reply-To: <20180426190845.21415-1-arnout@mind.be> References: <20180426190845.21415-1-arnout@mind.be> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi, Arnout: I suggest you to adjust your patch from HOST_NCURSES_CONF_OPTS = \ --with-shared \ --without-gpm \ --without-manpages \ --without-cxx \ --without-cxx-binding \ --without-ada \ --enable-widec \ --without-normal to HOST_NCURSES_CONF_OPTS = \ --enable-widec \ --with-shared \ --without-gpm \ --without-manpages \ --without-cxx \ --without-cxx-binding \ --without-ada \ --without-normal just for more cleanly. Thanks. Scott Fan On Fri, Apr 27, 2018 at 3:08 AM Arnout Vandecappelle (Essensium/Mind) < arnout@mind.be> wrote: > Kconfig uses pkg-config to find the ncurses or ncursesw library. If the > ncursesw package is found with pkg-config, it will #include . > Since Buildroot's host-ncurses doesn't install a .pc file, and linux.mk > anyway doesn't pass the pkg-config options to find the host pkg-config > files, Kconfig will always find the system's ncursesw.h. > > However, since commit dde090c299 (linux: fix passing of host CFLAGS and > LDFLAGS) HOST_LDFLAGS is passed to the linux build system. Thus, if > host-ncurses was already built before 'make linux-menuconfig' is called, > the build will pick up libncurses from the host directory, which is NOT > widechar. Thus, two different ncurses configurations are mixed into the > final mconf program. This will result in serious breakage in the > rendering of the menus (lots of @ and question mark characters). > > As a workaround, just build host-ncurses with widechar support. That > makes it compatible with ncursesw.h picked up from the host. Clearly, > this is not a robust solution. But it's simple, it works, and it > shouldn't hurt to build host-ncurses with widechar support (we can > safely assume that the system doesn't have a non-widechare uClibc > library...). > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) > Cc: David De Grave > --- > package/ncurses/ncurses.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk > index 90cf4a4dc5..9942d3f0bd 100644 > --- a/package/ncurses/ncurses.mk > +++ b/package/ncurses/ncurses.mk > @@ -153,6 +153,7 @@ HOST_NCURSES_CONF_OPTS = \ > --without-cxx \ > --without-cxx-binding \ > --without-ada \ > + --enable-widec \ > --without-normal > > $(eval $(autotools-package)) > -- > 2.17.0 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > -------------- next part -------------- An HTML attachment was scrubbed... URL: