From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A19ECC433FE for ; Fri, 13 May 2022 16:17:25 +0000 (UTC) Received: from localhost ([::1]:58966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npXym-0004sn-Pv for qemu-devel@archiver.kernel.org; Fri, 13 May 2022 12:17:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXqj-0006D1-Cd for qemu-devel@nongnu.org; Fri, 13 May 2022 12:09:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:52800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXqg-0003zK-7Y for qemu-devel@nongnu.org; Fri, 13 May 2022 12:09:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652458141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WDaNB/QH2wnHiKI0SZWj6ImFauccrghhRHvvENTyj+w=; b=eOQ6cQKA3BAPYLTZ9rsDw02h3DKspT5/WtIbqEhLvz7jh70iORNoRfKq3EkBXcTTthN/n7 iCksC3IAOPn7wjUKrW4eORkKU9r1upzG9faTGGy1KsZsnlem3pUmBayUNNWfIpjVmKqF3n JNPE9syGhOD+M7N5gi5fiNsSIPoQ/oQ= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-675-mAifF2n9NPqAEtUGvURN_g-1; Fri, 13 May 2022 12:09:00 -0400 X-MC-Unique: mAifF2n9NPqAEtUGvURN_g-1 Received: by mail-vk1-f199.google.com with SMTP id y198-20020a1f32cf000000b00351f84dc320so1210732vky.23 for ; Fri, 13 May 2022 09:08:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WDaNB/QH2wnHiKI0SZWj6ImFauccrghhRHvvENTyj+w=; b=JvInizNuE0IBZOOuGHWgbc6s+/LwONQ8Ze699el068gb/fQhz3XTwReY1dJ5S72Ogf +KaGTh/5794D3cjvR3rvKCnaYxJivguKO9wtwfG3rSmvPoIdhBDp+oxBCeNcRB1WfBGs yPdqf9h41ft4OWxCJGB2yGUWoHF7HdZKr8gE0Lffyy5Yibsmo22MB6BlbPyKr4nYdIkK UWqDUm1pKGPGma3ppmzsENj6N0Y4bSTxBOntvR84q2Klenz/BI+SRxhpV4JXz2VILCsm GMHdv4FvtdxPcgn35fYbxP983rF4x0DvTqwBLWuSdIeSZIJOEr1wLS25jqOYN1j6qhnk ZOmQ== X-Gm-Message-State: AOAM533v+lrKDKcWbU9GOSwR6fCNdrDjlHWk2vk6Du+NVZ8QTlddyWRu XhOXZTxcE47WZbkmbb8fGdJnvX6mm/xcHVQGFwKn1RxilNszDlBmgEY5Z8hWyKpBXIhB98z+URW R7N+B34juKdJQFrMM642jvVRCNBgUoXQ= X-Received: by 2002:a9f:3193:0:b0:35d:21ec:4ae1 with SMTP id v19-20020a9f3193000000b0035d21ec4ae1mr2438709uad.100.1652458139346; Fri, 13 May 2022 09:08:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbJl8erNGWvDWzKlclN7PdwMzcBwh4KPgyXHu6EO+wahO7gxUSHbnNwXygsOiyhvD3TRaXblbn9YNZgpQEQHY= X-Received: by 2002:a9f:3193:0:b0:35d:21ec:4ae1 with SMTP id v19-20020a9f3193000000b0035d21ec4ae1mr2438682uad.100.1652458139078; Fri, 13 May 2022 09:08:59 -0700 (PDT) MIME-Version: 1.0 References: <20220513000609.197906-1-jsnow@redhat.com> <20220513000609.197906-7-jsnow@redhat.com> In-Reply-To: From: John Snow Date: Fri, 13 May 2022 12:08:48 -0400 Message-ID: Subject: Re: [RFC PATCH 6/9] tests: add check-venv as a dependency of check and check-block To: Paolo Bonzini Cc: qemu-devel , Qemu-block , Cleber Rosa , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Hanna Reitz , Thomas Huth , Daniel Berrange , Kevin Wolf , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Content-Type: multipart/alternative; boundary="00000000000062e75105dee6e4d6" Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000062e75105dee6e4d6 Content-Type: text/plain; charset="UTF-8" On Fri, May 13, 2022, 11:34 AM Paolo Bonzini wrote: > On 5/13/22 16:12, John Snow wrote: > > > > I think you need instead: > > > > # The do-meson-check and do-meson-bench targets are defined in > > Makefile.mtest > > do-meson-check do-meson-bench: check-venv > > > > and I would even add "all" to the targets that create the virtual > > environment. > > > > Paolo > > > > > > Great, thanks! I'll try that out today. > > Well, check out the other suggestion of creating the venv at configure > time, because that would remove all these complications/annoyances. > > Paolo > They also raise new annoyances and questions for me, so it might be worth updating this "branch" of the patchset to have a basis of comparison for what's the least annoying in the end. (Or maybe even to serve as a basis while transitioning to the "better" solution. It's quick to try, at least.) Config script ideas are gonna take me a bit longer to work through. (I'm not against developing a minimum viable patchset and having you tweak it to your desire afterwards, if you have the time/interest. We can chat on irc if you'd like. Otherwise, I'll just push forward.) --js > --00000000000062e75105dee6e4d6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, May 13, 2022, 11:34 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
On 5/13/22 16:12, John Snow wrote:
>
>=C2=A0 =C2=A0 =C2=A0I think you need instead:
>
>=C2=A0 =C2=A0 =C2=A0# The do-meson-check and do-meson-bench targets are= defined in
>=C2=A0 =C2=A0 =C2=A0Makefile.mtest
>=C2=A0 =C2=A0 =C2=A0do-meson-check do-meson-bench: check-venv
>
>=C2=A0 =C2=A0 =C2=A0and I would even add "all" to the targets= that create the virtual
>=C2=A0 =C2=A0 =C2=A0environment.
>
>=C2=A0 =C2=A0 =C2=A0Paolo
>
>
> Great, thanks! I'll try that out today.

Well, check out the other suggestion of creating the venv at configure
time, because that would remove all these complications/annoyances.

Paolo

They also raise new annoyances and questions for me, so it might be wo= rth updating this "branch" of the patchset to have a basis of com= parison for what's the least annoying in the end.

(Or maybe even to serve as a basis while tran= sitioning to the "better" solution. It's quick to try, at lea= st.)

Config script ideas= are gonna take me a bit longer to work through.
(I'm not against developing a minimum viable p= atchset and having you tweak it to your desire afterwards, if you have the = time/interest. We can chat on irc if you'd like. Otherwise, I'll ju= st push forward.)

--js
--00000000000062e75105dee6e4d6--