From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E1FCC433EF for ; Wed, 22 Sep 2021 20:43:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33ACC60F12 for ; Wed, 22 Sep 2021 20:43:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 33ACC60F12 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT954-0001ql-87 for qemu-devel@archiver.kernel.org; Wed, 22 Sep 2021 16:43:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT93W-0000Tu-Qt for qemu-devel@nongnu.org; Wed, 22 Sep 2021 16:41:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:40295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT93R-0006MA-6Y for qemu-devel@nongnu.org; Wed, 22 Sep 2021 16:41:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632343280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9oelikejYOqj3gjikOoDhLNQ+YssP9xCdxMHWMwWk8U=; b=AkzN2wyGnpz1k2QaqgxOgnanXrAAXeC3XcC8IeuGytwPL2h4m7eV7nelffH0L4XbAqmZsR vrB8TUZsnbmlVZeKj2cEEDzXMx+OyxLxqu36giZIJ5v4J3A3tmu+rB7FPW4QHlEqZ1uVWp iNgEqn0HER3rlpVBrjiMGRQ2km+HAU0= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-sa5_hYQyMsClWqg6GIxrCw-1; Wed, 22 Sep 2021 16:41:18 -0400 X-MC-Unique: sa5_hYQyMsClWqg6GIxrCw-1 Received: by mail-ot1-f71.google.com with SMTP id t26-20020a9d749a000000b00547047a5594so1863582otk.0 for ; Wed, 22 Sep 2021 13:41:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9oelikejYOqj3gjikOoDhLNQ+YssP9xCdxMHWMwWk8U=; b=WiBjVyZpz6xnD39+uM6PoR4d0oYwemFye41B0nX4YIZoGq9KJ4MDzC8pFW7dOjbfDS 6sy43/vAb3z1Wd+doEbxEjBhEYDWKTww13kQ6v4qjoqNKrZVZvtxpNp+jzYPwljFSula Ixi4U9ssBC4M1MFcvwxN08COultRLH74pX0tI8/T/PjV52oEeZz/lU1Nn4voiuGkktfn mS0Cyb1liz04AnXa8PdUOVoaebSRdLd+iqjMw3tgwDTiqOTjXI84ieJ5pwPjIiar36/b fCYiFpIQCX1HQb4pprJ8Bi/KTsL2QkcxddgHQJaZcGyykqOgTwWqA0RzpOKPscLvytE9 CyzA== X-Gm-Message-State: AOAM530iKjqBArphbumuDIulIk0/i0XJpn31XbXT6I4zSOkRip+nV7ho qSOQF7Xujak0i+NEXstzV/5ihbms26IfAXMuCpg0ECqQ8eknIHmtDbj8AKs5gRPx7XnNhSF0zYJ j9HnH6usH14ZYF67OkoUvkZ5x4eH4o5M= X-Received: by 2002:a9d:7281:: with SMTP id t1mr996384otj.129.1632343277973; Wed, 22 Sep 2021 13:41:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1GyUEE58bK/I7g3VaM3Dj3Lu/2Bbu+V03jSBrIL3KuVnoUBLWXK7xx2QVz2IUonXbW8TGSIM1WsVK3Bmzg2k= X-Received: by 2002:a9d:7281:: with SMTP id t1mr996371otj.129.1632343277820; Wed, 22 Sep 2021 13:41:17 -0700 (PDT) MIME-Version: 1.0 References: <20210916040955.628560-1-jsnow@redhat.com> <20210916040955.628560-17-jsnow@redhat.com> <2235c3ee-0987-c6e2-1929-7785c74db286@redhat.com> In-Reply-To: <2235c3ee-0987-c6e2-1929-7785c74db286@redhat.com> From: John Snow Date: Wed, 22 Sep 2021 16:41:07 -0400 Message-ID: Subject: Re: [PATCH v3 16/16] iotests/linters: check mypy files all at once To: Hanna Reitz Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000039f1c005cc9b899b" Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.472, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-block@nongnu.org, qemu-devel , Markus Armbruster , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000039f1c005cc9b899b Content-Type: text/plain; charset="UTF-8" On Fri, Sep 17, 2021 at 7:23 AM Hanna Reitz wrote: > On 16.09.21 06:09, John Snow wrote: > > We can circumvent the '__main__' redefinition problem by passing > > --scripts-are-modules. Take mypy out of the loop per-filename and check > > everything in one go: it's quite a bit faster. > > Is it possible to pull this to the beginning of the series? Just > because patch 14 has to make everything quite slow (which might be a > tiny nuisance in bisecting some day?). > > Reasonable. Yes. --js > > > Signed-off-by: John Snow > > --- > > tests/qemu-iotests/linters.py | 62 ++++++++++++++++------------------- > > 1 file changed, 29 insertions(+), 33 deletions(-) > > Reviewed-by: Hanna Reitz > > --00000000000039f1c005cc9b899b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Sep 17, 2021 at 7:23 AM Hanna= Reitz <hreitz@redhat.com> w= rote:
On 16.09.2= 1 06:09, John Snow wrote:
> We can circumvent the '__main__' redefinition problem by passi= ng
> --scripts-are-modules. Take mypy out of the loop per-filename and chec= k
> everything in one go: it's quite a bit faster.

Is it possible to pull this to the beginning of the series?=C2=A0 Just
because patch 14 has to make everything quite slow (which might be a
tiny nuisance in bisecting some day?).


Reasonable. Yes.
=C2=A0<= /div>
--js

>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>=C2=A0 =C2=A0tests/qemu-iotests/linters.py | 62 ++++++++++++++++-------= ------------
>=C2=A0 =C2=A01 file changed, 29 insertions(+), 33 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>

--00000000000039f1c005cc9b899b--