From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D3DBC11F67 for ; Tue, 29 Jun 2021 15:47:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE38961D69 for ; Tue, 29 Jun 2021 15:47:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE38961D69 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyFxI-0004hJ-Sq for qemu-devel@archiver.kernel.org; Tue, 29 Jun 2021 11:47:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyFvw-0003M3-0V for qemu-devel@nongnu.org; Tue, 29 Jun 2021 11:46:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28707) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyFvs-00009F-8Z for qemu-devel@nongnu.org; Tue, 29 Jun 2021 11:45:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624981551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=scVq77QxvaEYHxEgUr6WCTtpcCYd/AQjdtIytflm8yE=; b=IO1DsxBvJZPn2AwdxR+xURKoCwdfqQpFd4cul15B+RM88qIZ7kILH4GgZh2NT2sCHsEJ1i NVXmyy8CFFkPmFqhdvqylJs7ZS6X7noRKsBs+4qQS1Z7oO1bTGGuW+nJrwRIQOQ7fo0rII q1+MEBAQypQm22JSEdkGis0dfueas7A= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-109-5jkIiQLVNtiF7NUMQsvGvw-1; Tue, 29 Jun 2021 11:45:48 -0400 X-MC-Unique: 5jkIiQLVNtiF7NUMQsvGvw-1 Received: by mail-oo1-f71.google.com with SMTP id r26-20020a4acb1a0000b029024c388a4835so10208285ooq.7 for ; Tue, 29 Jun 2021 08:45:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=scVq77QxvaEYHxEgUr6WCTtpcCYd/AQjdtIytflm8yE=; b=TszMfN5e3cAXfBpZFGyjLea9jOwrLb2v9my+gKV45wwdntj30s4VtpRYdSKBbGnm96 ZalpAw6s7IBVo66bLhIkO1Qp+lueEFotCyJHaafLiRFZfQr2ZHVJRTQIrgYp4OMbJzOV koj7+tfHxSvuG6ZYRku4NkQTEczJ4CX67aJ1EIZXMZGO9+mR1sUukrEY5mBbP3AnSL3D Bh3Uge8Lqq1a0eC8HOPVmskQ7EOo8AvMGjDtKTx/+zUpgZ0DvXqd6F6762iG66XoAhfm yewXU0ShlAzkFqzD01lv+roxEaXZH1o/741A5/8r5yz091L6qp2qK/Ld7v3M+RAcX8Fx O54w== X-Gm-Message-State: AOAM530rwbiF8OwI8f21KvzZs06wqCr6xmcrMlHhfnJ2RMP+sRLqxiXC S3xQg84cb7aEYf/wq3CoMjudUj4jcLYF15rRUcK3lXb79mU7h/kFPRYoJ5TMCDgHtTcUPXmgqm5 aBz+3pn5h4vAzAagEc3Z0tl0HxPRotbo= X-Received: by 2002:a05:6808:83:: with SMTP id s3mr8567934oic.168.1624981548170; Tue, 29 Jun 2021 08:45:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyG9+7lTwFpEg/pwe6O5SzVvWPTot9USf1wk9Aujv18qccVuIdNPA+gjmWwMcXWbTlg1CgWvMzgDLpDmDMG6Y= X-Received: by 2002:a05:6808:83:: with SMTP id s3mr8567922oic.168.1624981547989; Tue, 29 Jun 2021 08:45:47 -0700 (PDT) MIME-Version: 1.0 References: <20210625154540.783306-1-jsnow@redhat.com> <20210625154540.783306-9-jsnow@redhat.com> In-Reply-To: From: John Snow Date: Tue, 29 Jun 2021 11:45:37 -0400 Message-ID: Subject: Re: [PATCH 08/11] python: add 'make check-venv' invocation To: wainersm@redhat.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000ef533205c5e97f97" Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.435, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , qemu-devel@nongnu.org, Willian Rampazzo , Cleber Rosa , =?UTF-8?B?QWxleCBCZW5uw6ll?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000ef533205c5e97f97 Content-Type: text/plain; charset="UTF-8" On Mon, Jun 28, 2021 at 5:40 PM Wainer dos Santos Moschetta < wainersm@redhat.com> wrote: > > On 6/25/21 12:45 PM, John Snow wrote: > > This is a *third* way to run the Python tests. Unlike the first two > > (check-pipenv, check-tox), this version does not require any specific > > interpreter version -- making it a lot easier to tell people to run it > > as a quick smoketest prior to submission to GitLab CI. > > > > Summary: > > > > Checked via GitLab CI: > > - check-pipenv: tests our oldest python & dependencies > > - check-tox: tests newest dependencies on all non-EOL python > versions > > Executed only incidentally: > > - check-venv: tests newest dependencies on whichever python version > > > > ('make check' does not set up any environment at all, it just runs the > > tests in your current environment. All four invocations perform the > > exact same tests, just in different execution environments.) > > > > Signed-off-by: John Snow > > --- > > python/Makefile | 35 ++++++++++++++++++++++++++++++++--- > > 1 file changed, 32 insertions(+), 3 deletions(-) > > > > diff --git a/python/Makefile b/python/Makefile > > index 5cb8378b81..76bb24e671 100644 > > --- a/python/Makefile > > +++ b/python/Makefile > > @@ -1,4 +1,6 @@ > > -.PHONY: help pipenv check-pipenv check clean distclean develop > > +.PHONY: help pipenv venv check-venv check-pipenv check clean distclean > develop > > + > btw, check-tox is missed here ^ > Oops, thanks! I am not sure it winds up mattering, but writing Makefiles feels like religion. I just follow the same steps and pray at the altar. > > +QEMU_VENV_DIR=~/.cache/qemu-pyvenv > > A few suggestions: > > 1. For the sake of consistence with others temporary directories > created, use QEMU_VENV_DIR=/.devvenv > > Sure, straight in this folder, like .tox and .venv you mean? (I'd rename .venv to .pipenv, but pipenv doesn't let you name this folder, annoyingly ...) > 2. Reword to 'devvenv' or 'dev-venv' (or something similar), instead of > 'venv', the directories and Make targets. IMHO it will make the purpose > of the targets a bit clear. > > Sure, I'll do that -- .dev-venv works for me. > > What do you think John? > > I think that it's hot outside :) > - Wainer > Thanks! --js --000000000000ef533205c5e97f97 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Jun 28, 2021 at 5:40 PM Waine= r dos Santos Moschetta <wainersm@= redhat.com> wrote:

On 6/25/21 12:45 PM, John Snow wrote:
> This is a *third* way to run the Python tests. Unlike the first two > (check-pipenv, check-tox), this version does not require any specific<= br> > interpreter version -- making it a lot easier to tell people to run it=
> as a quick smoketest prior to submission to GitLab CI.
>
> Summary:
>
>=C2=A0 =C2=A0 Checked via GitLab CI:
>=C2=A0 =C2=A0 =C2=A0 - check-pipenv: tests our oldest python & depe= ndencies
>=C2=A0 =C2=A0 =C2=A0 - check-tox: tests newest dependencies on all non-= EOL python versions
>=C2=A0 =C2=A0 Executed only incidentally:
>=C2=A0 =C2=A0 =C2=A0 - check-venv: tests newest dependencies on whichev= er python version
>
> ('make check' does not set up any environment at all, it just = runs the
> tests in your current environment. All four invocations perform the > exact same tests, just in different execution environments.)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>=C2=A0 =C2=A0python/Makefile | 35 ++++++++++++++++++++++++++++++++--- >=C2=A0 =C2=A01 file changed, 32 insertions(+), 3 deletions(-)
>
> diff --git a/python/Makefile b/python/Makefile
> index 5cb8378b81..76bb24e671 100644
> --- a/python/Makefile
> +++ b/python/Makefile
> @@ -1,4 +1,6 @@
> -.PHONY: help pipenv check-pipenv check clean distclean develop
> +.PHONY: help pipenv venv check-venv check-pipenv check clean distclea= n develop
> +
btw, check-tox is missed here ^

Oops, t= hanks! I am not sure it winds up mattering, but writing Makefiles feels lik= e religion. I just follow the same steps and pray at the altar.
=C2=A0
> +QEMU_VENV_DIR=3D~/.cache/qemu-pyvenv

A few suggestions:

1. For the sake of consistence with others temporary directories
created, use QEMU_VENV_DIR=3D<path-to-qemu-src>/.devvenv


Sure, straight in this folder, like .t= ox and .venv you mean?

(I'd rename .venv to .p= ipenv, but pipenv doesn't let you name this folder, annoyingly ...)
=
=C2=A0
2. Reword to 'devvenv' or 'dev-venv' (or something similar)= , instead of
'venv', the directories and Make targets. IMHO it will make the pur= pose
of the targets a bit clear.


Sure, I'll do that -- .dev-venv wo= rks for me.
=C2=A0
- Wainer

Thanks!
--js
--000000000000ef533205c5e97f97--