From: John Snow <jsnow@redhat.com>
To: G S Niteesh Babu <niteesh.gs@gmail.com>
Cc: Cleber Rosa <crosa@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/6] python: disable pylint errors for aqmp-tui
Date: Tue, 20 Jul 2021 14:30:47 -0400 [thread overview]
Message-ID: <CAFn=p-Yv6-gscr5-ECP0h1r-iM1HT6AJWvuPzcrtbMFzz5VqOQ@mail.gmail.com> (raw)
In-Reply-To: <CAFn=p-b3gOzFtcGCH3amNTyzosMqP2HkYFSiaX04e9yVWhfgBw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]
On Tue, Jul 20, 2021 at 2:00 PM John Snow <jsnow@redhat.com> wrote:
>
>
> On Fri, Jul 2, 2021 at 5:26 PM G S Niteesh Babu <niteesh.gs@gmail.com>
> wrote:
>
>> Disable missing-docstring and fixme pylint warnings.
>> This is because since the AQMP is just a prototype
>> it is currently not documented properly and lot
>> of todo and fixme's are still in place.
>>
>> Signed-off-by: G S Niteesh Babu <niteesh.gs@gmail.com>
>> ---
>> python/setup.cfg | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/python/setup.cfg b/python/setup.cfg
>> index bce8807702..1a552d672a 100644
>> --- a/python/setup.cfg
>> +++ b/python/setup.cfg
>> @@ -89,6 +89,8 @@ ignore_missing_imports = True
>> # no Warning level messages displayed, use "--disable=all
>> --enable=classes
>> # --disable=W".
>> disable=too-many-function-args, # mypy handles this with less false
>> positives.
>> + missing-docstring, # FIXME
>> + fixme, # FIXME
>>
>
> You aren't actually using any FIXME statements in this branch right now
> that I can see, so you don't need that suppression. It could be removed in
> V3.
>
>
Sorry, I was mistaken, this will trigger on the TODO entries that you *are*
using.
--js
[-- Attachment #2: Type: text/html, Size: 2029 bytes --]
next prev parent reply other threads:[~2021-07-20 18:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 21:25 [PATCH 0/6] python: AQMP-TUI Prototype G S Niteesh Babu
2021-07-02 21:25 ` [PATCH 1/6] python: disable pylint errors for aqmp-tui G S Niteesh Babu
2021-07-20 18:00 ` John Snow
2021-07-20 18:30 ` John Snow [this message]
2021-07-02 21:25 ` [PATCH 2/6] python: Add dependencies for AQMP TUI G S Niteesh Babu
2021-07-08 1:39 ` John Snow
2021-07-02 21:26 ` [PATCH 3/6] python/aqmp-tui: Add AQMP TUI draft G S Niteesh Babu
2021-07-08 3:20 ` John Snow
2021-07-08 17:20 ` John Snow
2021-07-13 22:08 ` Niteesh G. S.
2021-07-02 21:26 ` [PATCH 4/6] python: add optional pygments dependency G S Niteesh Babu
2021-07-02 21:26 ` [PATCH 5/6] python/aqmp-tui: add syntax highlighting G S Niteesh Babu
2021-07-02 21:26 ` [PATCH 6/6] python: add entry point for aqmp-tui G S Niteesh Babu
2021-07-08 2:14 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-Yv6-gscr5-ECP0h1r-iM1HT6AJWvuPzcrtbMFzz5VqOQ@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=niteesh.gs@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.