On Thu, Dec 16, 2021 at 5:09 AM Vladimir Sementsov-Ogievskiy <
vsementsov@virtuozzo.com> wrote:

> 15.12.2021 22:39, John Snow wrote:
> > This is in preparation for renaming qemu.aqmp to qemu.qmp. I should have
> > done this from this from the very beginning, but it's a convenient time
> > to make sure this churn is taken care of.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
>
> Honestly, I don't want to check how it intersects with exising QMPError
> from old library, as it's going to be removed anyway. Hope, everything is
> OK:
>
>
it's all namespaced, and it doesn't appear to conflict in practice.


> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
> ---
> >   python/qemu/aqmp/__init__.py   |  6 +++---
> >   python/qemu/aqmp/error.py      | 12 ++++++------
> >   python/qemu/aqmp/events.py     |  4 ++--
> >   python/qemu/aqmp/legacy.py     |  4 ++--
> >   python/qemu/aqmp/protocol.py   |  8 ++++----
> >   python/qemu/aqmp/qmp_client.py |  8 ++++----
> >   6 files changed, 21 insertions(+), 21 deletions(-)
> >
> > diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py
> > index c6fa2dda58..e1efab00af 100644
> > --- a/python/qemu/aqmp/__init__.py
> > +++ b/python/qemu/aqmp/__init__.py
> > @@ -6,7 +6,7 @@
> >   QEMU Guest Agent, and the QEMU Storage Daemon.
> >
> >   `QMPClient` provides the main functionality of this package. All errors
> > -raised by this library dervive from `AQMPError`, see `aqmp.error` for
> > +raised by this library dervive from `QMPError`, see `aqmp.error` for
>
> preexisting: s/dervive/derive/
>
>
Whoops. I'll add a patch to fix it. Thanks.