All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Maximum QMP reply size
Date: Tue, 6 Sep 2022 15:38:54 -0400	[thread overview]
Message-ID: <CAFn=p-ZkKLQtYAwzkQb7srFf_fF8ij+g5wkZiRofx4U+kSZ7Rw@mail.gmail.com> (raw)

Hi, I suspect I have asked this before, but I didn't write it down in
a comment, so I forget my justification...

In the QMP lib, we need to set a buffering limit for how big a QMP
message can be -- In practice, I found that the largest possible
response was the QAPI schema reply, and I set the code to this:

    # Maximum allowable size of read buffer
    _limit = (64 * 1024)

However, I didn't document if this was a reasonable limit or just a
"worksforme" one. I assume that there's no hard limit for the protocol
or the implementation thereof in QEMU. Is there any kind of value here
that would be more sensible than another?

I'm worried that if replies get bigger in the future (possibly in some
degenerate case I am presently unaware of) that the library default
will become nonsensical.

Any pointers/tips?

--js



             reply	other threads:[~2022-09-06 19:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 19:38 John Snow [this message]
2022-09-06 20:29 ` Maximum QMP reply size Peter Maydell
2022-09-15 15:21   ` Dr. David Alan Gilbert
2022-09-16 15:12     ` Peter Maydell
2022-09-16 15:36       ` Daniel P. Berrangé
2022-09-19  6:45         ` Markus Armbruster
2022-09-20  8:14           ` Daniel P. Berrangé
2022-09-20 15:52       ` Dr. David Alan Gilbert
2022-09-07  7:16 ` Daniel P. Berrangé
2022-09-07  7:57 ` Daniel P. Berrangé
2022-09-07 11:54 ` Markus Armbruster
2022-09-23 19:51   ` John Snow
2022-09-26  8:17     ` Daniel P. Berrangé
2022-09-26  8:08   ` Daniel P. Berrangé
2022-09-26 10:43     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFn=p-ZkKLQtYAwzkQb7srFf_fF8ij+g5wkZiRofx4U+kSZ7Rw@mail.gmail.com' \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.