From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BEF2C6377A for ; Wed, 21 Jul 2021 20:20:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C6A161248 for ; Wed, 21 Jul 2021 20:20:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C6A161248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Ihm-0007Gj-Cl for qemu-devel@archiver.kernel.org; Wed, 21 Jul 2021 16:20:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6IRQ-0000zw-9d for qemu-devel@nongnu.org; Wed, 21 Jul 2021 16:03:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6IRN-0007tH-EQ for qemu-devel@nongnu.org; Wed, 21 Jul 2021 16:03:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626897815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pyj+h5yVmQVl71XrDhZZqer9Clxdw3GrFULMfTer75E=; b=Ei43gwvzAk5THpCoaD7W8Temi++MB/zOEmBLmfoqOn9kwyYKmxvZgii/73pywo87IaPwnq GqwVaE65CnuRt8snb/biFg/KCp7pdJDxu6LeNCaeWnV5kWmVLP+uV8+yjZUA3LiCxYCKwg WcaBb3tayysNV2JCxYmaZcaxgf9AXlc= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-nXEBLsC-P6W91aAoNPbBeQ-1; Wed, 21 Jul 2021 16:03:32 -0400 X-MC-Unique: nXEBLsC-P6W91aAoNPbBeQ-1 Received: by mail-oi1-f198.google.com with SMTP id q199-20020aca75d00000b029025a3cb2429bso2399643oic.20 for ; Wed, 21 Jul 2021 13:03:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pyj+h5yVmQVl71XrDhZZqer9Clxdw3GrFULMfTer75E=; b=FfsE9Gs4xy6qg+S1xiNQmxC94YZ2bs6GheORRVsoXcHCJfu/ozZy/ojTN1ASSnObJ9 O5Rdki6MZO6pZZvqaLLjquF2msZhXj+W/t2a0VXL4kqi7qnYclUO1mf/eg8FTe5oUpeR poH2B1EZVSIyQJZ9aAhX55AUVREPmjj2XngTTO6i2xSaLAfWidrbZ5fLaTSQkufrjR1t P2YCCLUnYXVMv92IlX+x0e76CBKbHfl6ClKX/SUJCMOo5GayhmWl3rwA6mJcMn7L/QKL ZGfpM7bXw8pr91GPQRlqCrw9leu7ygPZvtwbDTxNDnZD2RscsReV39pEhrWl5nXlzR1d P0qg== X-Gm-Message-State: AOAM530e8JFHAHznhVoUB41+dqsg7zFSohS3K4JiY17X3Szp/Jyb30yR k7FuyLudzlfgI6kDJUNY0aBKzfvxh6HPkgo3ElI4akL+VkcMhNnUkVBfVo9LJAB01IxWK2kguSC kNE+shWPaV0tXfAkgi9BsUHniQbFndvE= X-Received: by 2002:a05:6808:1309:: with SMTP id y9mr3637862oiv.112.1626897812007; Wed, 21 Jul 2021 13:03:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymPu+/2ok59b03x0T4eQJK25c9wN+CNXDIVoATu//5tARDwiKiUoNxnZCsJamdVwYxUDaJL9QmJoABCx1rhkk= X-Received: by 2002:a05:6808:1309:: with SMTP id y9mr3637837oiv.112.1626897811575; Wed, 21 Jul 2021 13:03:31 -0700 (PDT) MIME-Version: 1.0 References: <20210713220734.26302-1-niteesh.gs@gmail.com> In-Reply-To: From: John Snow Date: Wed, 21 Jul 2021 16:03:20 -0400 Message-ID: Subject: Re: [PATCH v2 0/6] python: AQMP-TUI Prototype To: "Niteesh G. S." Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000002527a805c7a7aae8" Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.459, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cleber Rosa , qemu-devel , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000002527a805c7a7aae8 Content-Type: text/plain; charset="UTF-8" On Wed, Jul 21, 2021 at 2:09 PM Niteesh G. S. wrote: > On Wed, Jul 21, 2021 at 12:39 AM John Snow wrote: > >> On Wed, Jul 14, 2021 at 3:07 PM Niteesh G. S. >> wrote: >> >> Why not? >> > I have already updated the status of this > https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg04059.html > Sorry, I missed this. Thanks Niteesh, a few general comments that don't relate directly to the >> code: >> >> 1. It would be nice to be able to highlight/copy-paste things out of the >> history window, I seemingly can't right now. >> >> 2. It would be nice if the mouse scroll wheel worked on the history panel. >> >> 3. A greeting message like the old qmp-shell might be nice to see. It >> would be good if it explained how to quit the program (esc, ctrl^c) and >> send messages (alt+enter). >> >> 4. Some control hints or reminder text in the footer might be nice, for >> how to quit, send a message, etc. >> > > I'll update the status here as I start working on them one by one. > > OK - They don't need to go into this series, these are just some observations. All of these items seem like good candidates for standalone follow-up patches to happen in another series that follows this one. > For the next revision, I may ask you to start looking into making sure >> that mypy and pylint pass without exemptions. Do the best you can, and get >> as far as you are able. You can leave the warnings disabled for V3, but I'd >> like you to start taking a look now so that you know where the trouble >> spots are. >> > > Sure. > > I'll be on PTO for the next three business days, returning 2021-07-27 -- If you get blocked on other tasks, try adding mypy type hints using this downtime. Thanks again, --js --0000000000002527a805c7a7aae8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jul 21, 2021 at 2:09 PM Nitee= sh G. S. <niteesh.gs@gmail.com> wrote:
On Wed, Jul 21, 2021 at 12:39 AM John Snow <jsnow@redhat.com> wrote:
On Wed, Jul 14, 2021= at 3:07 PM Niteesh G. S. <niteesh.gs@gmail.com> wrote:

Why not?=
I have already updated the status of this
=

Sorry, I= missed this.

Thanks Niteesh, a few general comments that don't relate directl= y to the code:

1. It would be nice to be able to = highlight/copy-paste things out of the history window, I seemingly can'= t right now.

2. It would be nice if the mouse scroll wheel worked on= the history panel.

3. A greeting message like the old qmp-shell mig= ht be nice to see. It would be good if it explained how to quit the program= (esc, ctrl^c) and send messages (alt+enter).

4. Some control hints = or reminder text in the footer might be nice, for how to quit, send a messa= ge, etc.
=C2=A0=
I'll updat= e the status here as I start working on them one by one.


<= div>OK - They don't need to go into this series, these are just some ob= servations. All of these items seem like good candidates for standalone fol= low-up patches to happen in another series that follows this one.
=
=C2=A0
For the next revision, I may ask you to start looking= into making sure that mypy and pylint pass without exemptions. Do the best= you can, and get as far as you are able. You can leave the warnings disabl= ed for V3, but I'd like you to start taking a look now so that you know= where the trouble spots are.
=C2=A0
Sure.


I&= #39;ll be on PTO for the next three business days, returning 2021-07-27 -- = If you get blocked on other tasks, try adding mypy type hints using this do= wntime.
=C2=A0
Thanks again,
--js
--0000000000002527a805c7a7aae8--