From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C603EC433F5 for ; Thu, 5 May 2022 12:10:08 +0000 (UTC) Received: from localhost ([::1]:47040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmaJ5-0000In-SB for qemu-devel@archiver.kernel.org; Thu, 05 May 2022 08:10:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmaHy-0007vG-R8 for qemu-devel@nongnu.org; Thu, 05 May 2022 08:08:58 -0400 Received: from us-smtp-delivery-74.mimecast.com ([170.10.133.74]:39251) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmaHw-00063C-HT for qemu-devel@nongnu.org; Thu, 05 May 2022 08:08:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651752534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YHx1KEjhZ4K9FqQPleuM1J4a/oUo9RcjvZC6RMrsvZE=; b=LCMuMXG9F6mWGeJmo1ulz2Q/wBi9penejbNPlOfatLwO1L04zDHejg2kEJfpKKdvhU/GIn iVY1KP50fiDUID8m69ds5ygRPSYxueC9jYO4T1YolCoYWJZZYE7VXFkVVxZoGml/71aC9t hQchEl2ESQvDL+aZBGJInwK9rfHzjjI= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-VAN3_cbIPTmRCnxMNHMuqQ-1; Thu, 05 May 2022 08:08:53 -0400 X-MC-Unique: VAN3_cbIPTmRCnxMNHMuqQ-1 Received: by mail-ua1-f72.google.com with SMTP id q34-20020a9f37a5000000b0036283ee1147so1796856uaq.4 for ; Thu, 05 May 2022 05:08:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YHx1KEjhZ4K9FqQPleuM1J4a/oUo9RcjvZC6RMrsvZE=; b=vUj2AJMTb9X5FbFiv5CjQAsQLL496lGrI0/fIpmhnvefkVTfBQzD9EE1MxIdd5Ow6b go+/SBFvfEULGpGlpEhGcrPBouoLdjvXofGfQJjDJkxjMVpdMvf3EzmC5Te5r553Qi19 TSWebl7SM/FmRptrxsFkqQoDWjaNJJ1yOPlrbvZ0xyx783emguwkyS5vP6YSO8lsm5OO Nfta7qf7x/8u6pY64U+/wd+OwaUEZ443n7oDr0uI5wmgHrRdPzloPxy7J4QaSdRXXNsf sX4MYZH7dv3eAriw7Lvxrs3Zje00CH6goyO443w4eV8qJMaqMPZFH0xI8/UT4ku4zuHR KJ2g== X-Gm-Message-State: AOAM5339+wa9oisVmvIaE/EMIOc5PwjQPV09DsPDcoQoj7v7Iq+l/SpE wNURuNVOWzWyncgVeX23k+rFzn2gBc6Ll+owGHUzBSPK+C7B9Dpm9ur8faIucmI3tGaS/v3uDL1 sa7m29DIoidSKoYt483yaWv0x2ssquQc= X-Received: by 2002:a67:fe17:0:b0:32c:e77e:c3b4 with SMTP id l23-20020a67fe17000000b0032ce77ec3b4mr8157946vsr.11.1651752533141; Thu, 05 May 2022 05:08:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhSvb4Eq5nwNBQqpdvC5wq5VteVtRs0YZOjT8jAfArgQQaejGD6qh37i27qOpVpLJEc6oMWg3QPLKeUmBWbAE= X-Received: by 2002:a67:fe17:0:b0:32c:e77e:c3b4 with SMTP id l23-20020a67fe17000000b0032ce77ec3b4mr8157936vsr.11.1651752532985; Thu, 05 May 2022 05:08:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: John Snow Date: Thu, 5 May 2022 08:08:42 -0400 Message-ID: Subject: Re: iotests and python dependencies To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= Cc: Qemu-block , qemu-devel , Kevin Wolf , Hanna Reitz , Vladimir Sementsov-Ogievskiy , Paolo Bonzini , Cleber Rosa Content-Type: multipart/alternative; boundary="000000000000fc611205de429a8d" Received-SPF: pass client-ip=170.10.133.74; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-74.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000fc611205de429a8d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 5, 2022, 4:09 AM Daniel P. Berrang=C3=A9 = wrote: > On Wed, May 04, 2022 at 03:38:45PM -0400, John Snow wrote: > > Howdy! > > > > So, I want to finally delete python/qemu/qmp from qemu.git, and this > > creates a small problem -- namely, iotests needs access to it in order > > to run the python-based tests. > > > > What I think needs to happen is that we create a virtual environment > > that installs python/qemu/. The reason this cannot be done with > > PYTHONPATH alone anymore is because the qmp package itself won't be > > there anymore, we need an installer like `pip` to actually fetch it > > for us and put it somewhere. (i.e., we need to process the > > dependencies of python/qemu now and can't treat it as a pre-installed > > location.) > > Having pip fetch it on the fly creates a problem for RPM builds, > because the koji build env has no network access. We will, however, > have an RPM of python-qemu-qmp installed on the host system though. > IOW we need to be able to run iotests using system python and its > installed libs, not a virtual env. So if we do anything with a > virtual env, it will need to be optional I believe. > Hm, do we need iotests during an rpm build? Is it because of "make check"? It's possible to create a venv and run pip in no-network mode, too. If the package we want is installed on the system or otherwise in pip's cache, it'll succeed without network. If the dependencies require a qemu.qmp that's too new, the pip install will just fail instead. I have to test a way to craft a pip statement that's network *optional* though. i.e. try to fetch and fall back to local otherwise. I think it's worth trying to keep the environment setup code unified, and always use a venv. I think this is tractable, though. --000000000000fc611205de429a8d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, May 5, 2022, 4:09 AM Daniel P. Berrang=C3=A9 &= lt;berrange@redhat.com> wrote= :
On Wed, May 04, 2022 at 03:38:45P= M -0400, John Snow wrote:
> Howdy!
>
> So, I want to finally delete python/qemu/qmp from qemu.git, and this > creates a small problem -- namely, iotests needs access to it in order=
> to run the python-based tests.
>
> What I think needs to happen is that we create a virtual environment > that installs python/qemu/. The reason this cannot be done with
> PYTHONPATH alone anymore is because the qmp package itself won't b= e
> there anymore, we need an installer like `pip` to actually fetch it > for us and put it somewhere. (i.e., we need to process the
> dependencies of python/qemu now and can't treat it as a pre-instal= led
> location.)

Having pip fetch it on the fly creates a problem for RPM builds,
because the koji build env has no network access. We will, however,
have an RPM of python-qemu-qmp installed on the host system though.
IOW we need to be able to run iotests using system python and its
installed libs, not a virtual env.=C2=A0 So if we do anything with a
virtual env, it will need to be optional I believe.
<= /div>

Hm, do we need iotests d= uring an rpm build? Is it because of "make check"?

It's possible to create a venv an= d run pip in no-network mode, too. If the package we want is installed on t= he system or otherwise in pip's cache, it'll succeed without networ= k. If the dependencies require a qemu.qmp that's too new, the pip insta= ll will just fail instead.

I have to test a way to craft a pip statement that's network *option= al* though. i.e. try to fetch and fall back to local otherwise. I think it&= #39;s worth trying to keep the environment setup code unified, and always u= se a venv.

I think this = is tractable, though.

--000000000000fc611205de429a8d--