From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C77DC433FE for ; Mon, 10 Jan 2022 18:15:20 +0000 (UTC) Received: from localhost ([::1]:39400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6zCR-0007dq-6Y for qemu-devel@archiver.kernel.org; Mon, 10 Jan 2022 13:15:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6z7V-0007Ax-0N for qemu-devel@nongnu.org; Mon, 10 Jan 2022 13:10:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:39676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6z7R-0000ob-Au for qemu-devel@nongnu.org; Mon, 10 Jan 2022 13:10:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641838208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w/QK7eXVlTY6YqofVDReUKCT0BobRz4TTDioq1E7w2g=; b=PJg3+XMgC+yMggl3jS7v0isn8fe7C5oll0c+emlNfLOZC5H1dVK7Uu9jKxhb1lBmVdf2Gn Jrq97Ps2RXfdRIRdnbG+WPz4RH2O7KF6w5wrVQZaLovqu7CjD4yXc1bRVXazplOoSQZWky yVBBexgnALeHxCCapZLOWx1jWsKOI5U= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-59-cjPRv_LfNG-HkJAsvt-JzQ-1; Mon, 10 Jan 2022 13:10:06 -0500 X-MC-Unique: cjPRv_LfNG-HkJAsvt-JzQ-1 Received: by mail-ua1-f69.google.com with SMTP id x9-20020ab05789000000b002fa60bdf012so8140504uaa.1 for ; Mon, 10 Jan 2022 10:10:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w/QK7eXVlTY6YqofVDReUKCT0BobRz4TTDioq1E7w2g=; b=4vNY9IzowRl6zQvCrWwnQAlDofT38bd5z/sOqR2YRPzwnUOyocmtaHdMeZtVH9TWbo /3+DgO4lIkb71qtee8NSasoCnH5VreEaFl0U8RobcigeR2wu0yKEgxkkYfZ0aidMcbbN 8zviKnpkX2472+c2LkSR1TvTsbl+pNo9Ande4NIIXljq3mhE7PkaNosAlX1SVDyczpHI NCPW4lrp6bsxUjJHsdjoIMFIVkIJ/IkoQTrW9MOrWs7A/dhUXOlm2+pqhTcbGv6w6GTf HJODAcopKRcm5UHk5ACNyRLHUk3unByKFIRDJRrBMPUUL6UleK75wvSyEQ8uNoxZtDht hmBg== X-Gm-Message-State: AOAM5324mh6wN6//3cyyAJ4KKp8dQ1LFHG9TGW195bSd7TejvFGIPSYb nUdRHNOouQ8/VNPehIBIqyhRPSrludxGfdrrIoTZBAGDDyP2hzmQMW6isSfS29RKafXxvXcRme6 NbFQONI/UGCQshSWgo6WOJCkr+WQq6RI= X-Received: by 2002:a05:6102:3714:: with SMTP id s20mr191673vst.61.1641838205868; Mon, 10 Jan 2022 10:10:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxM4FxRNlaY4Ow69pjmvB1uxwI/dxN0FD4zpztT/p608+3aGMSxisvLbhApUxXaLSdMM89pgyWnVMb50f6C50o= X-Received: by 2002:a05:6102:3714:: with SMTP id s20mr191668vst.61.1641838205699; Mon, 10 Jan 2022 10:10:05 -0800 (PST) MIME-Version: 1.0 References: <20220107153019.504124-1-sw@weilnetz.de> <42ac8990-8733-fa68-c4b4-c54a82ce43f9@weilnetz.de> In-Reply-To: <42ac8990-8733-fa68-c4b4-c54a82ce43f9@weilnetz.de> From: John Snow Date: Mon, 10 Jan 2022 13:09:55 -0500 Message-ID: Subject: Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM) To: Stefan Weil Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000079b0505d53e3f6f" Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.597, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Vladimir Sementsov-Ogievskiy , qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000079b0505d53e3f6f Content-Type: text/plain; charset="UTF-8" On Mon, Jan 10, 2022 at 12:57 PM Stefan Weil wrote: > Am 10.01.22 um 18:08 schrieb John Snow: > > On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil wrote: > >> Signed-off-by: Stefan Weil >> --- >> scripts/simplebench/bench-example.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/simplebench/bench-example.py >> b/scripts/simplebench/bench-example.py >> index 4864435f39..fc370691e0 100644 >> --- a/scripts/simplebench/bench-example.py >> +++ b/scripts/simplebench/bench-example.py >> @@ -25,7 +25,7 @@ >> >> def bench_func(env, case): >> """ Handle one "cell" of benchmarking table. """ >> - return bench_block_copy(env['qemu_binary'], env['cmd'], {} >> + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, >> case['source'], case['target']) >> >> >> -- >> 2.30.2 >> > > Good spot. If it's not too late and not a hassle, can you add a fixes: > commit-id in the commit message? No big deal if not. > > Reviewed-by: John Snow > > > Maybe that can be added locally to avoid a V2 patch. Here it is: > > Fixes: b2fcb0c5754c2554b8406376e99a75e9e0a6b7bd > > Thanks, > > Stefan > > > Got it. I just got back from holiday today, so there's still lots of mail to catch up on. If nobody else has staged this, I will do so as part of my python fixes this week. Thanks! --js --000000000000079b0505d53e3f6f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Jan 10, 2022 at 12:57 PM Stef= an Weil <sw@weilnetz.de> wrote:=
=20 =20 =20

Am 10.01.22 um 18:08 schrieb John Snow:

On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <sw@weilnetz.de> wrot= e:
Signed-off-by: Stefan Weil <sw@weil= netz.de>
---
=C2=A0scripts/simplebench/bench-example.py | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/simplebench/bench-example.py b/scripts/simplebench/bench-example.py
index 4864435f39..fc370691e0 100644
--- a/scripts/simplebench/bench-example.py
+++ b/scripts/simplebench/bench-example.py
@@ -25,7 +25,7 @@

=C2=A0def bench_func(env, case):
=C2=A0 =C2=A0 =C2=A0""" Handle one "cell&qu= ot; of benchmarking table. """
-=C2=A0 =C2=A0 return bench_block_copy(env['qemu_binary'= ;], env['cmd'], {}
+=C2=A0 =C2=A0 return bench_block_copy(env['qemu_binary'= ;], env['cmd'], {},
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case['source'], case['= target'])


--
2.30.2

Good spot. If it's not too late and not a hassle, can yo= u add a fixes: commit-id in the commit message? No big deal if not.

Reviewed-by: John Snow <jsnow@redhat.com>


Maybe that can be added locally to avoid a V2 patch. Here it is:

Fixes: b2fcb0c5754c2554b8406376e99a75e9e0a6b7bd

Thanks,

Stefan


Got it. I just got back from holiday= today, so there's still lots of mail to catch up on. If nobody else ha= s staged this, I will do so as part of my python fixes this week. Thanks!

--js
--000000000000079b0505d53e3f6f--