From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 486CCC433EF for ; Fri, 17 Sep 2021 19:22:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94B8A604E9 for ; Fri, 17 Sep 2021 19:22:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 94B8A604E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:55872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRJRa-00029G-Fb for qemu-devel@archiver.kernel.org; Fri, 17 Sep 2021 15:22:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRJQf-0000Vj-R3 for qemu-devel@nongnu.org; Fri, 17 Sep 2021 15:21:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55526) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRJQc-0007v2-SX for qemu-devel@nongnu.org; Fri, 17 Sep 2021 15:21:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631906501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L10eqfImoG0JkDumWMOOFU+zLZ7pDq2PptNqw+Pr2K0=; b=FD8vLPaq3Fq/cjLBEC0py2WmfifZeRwWhLAnrgVBLYdnhSL33UoHJdIMYgL8MHndi4pttY GH7ghF68nq53N59l406r1c6JNbe2VvandtTF9oJg0dELqYNixCmKI0YHNJIe0pGHSebBH8 9lkXGDNdiWtok6rNSV9FRewQD1iIC6Y= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-FERbVD87N9a5UTeHOyIqbw-1; Fri, 17 Sep 2021 15:21:38 -0400 X-MC-Unique: FERbVD87N9a5UTeHOyIqbw-1 Received: by mail-ot1-f70.google.com with SMTP id q12-20020a05683033cc00b00521230773b1so39904360ott.4 for ; Fri, 17 Sep 2021 12:21:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L10eqfImoG0JkDumWMOOFU+zLZ7pDq2PptNqw+Pr2K0=; b=E7ICaXjV6qPz5YuMBtLgx/Lua2TcbJpDPUr0DaxMdKit5wF+MhTTRhA6EkLWSJg8g3 f6ZLyOcE9j485L0cxKNoPbYOnEcx+Vs+khYYja4dHPplh15jh5eUhOUY3+vtKohoSZge lWWIinrp0opw4AoI+rFOsb3fo2ouU7v3ZDIgM/CEmidh9YKqHg898pz5MftzCGgRV4S5 l0AGzqOHG8TtrJxHo0Zgf/bvG/01sK1UkdEBYKQN0E4T78tg2hg2bVeFWr6rRIHaR+5+ P9nO5TzQImvqV9m/LOmZ5OA6piO3udPjJQq8QYb8n5VxYmKymx4nCDIO60q73RZm2FVn G1Xw== X-Gm-Message-State: AOAM533GpiSKznTw//SHWHJk4tbt4doKCB+fxQERuuiKxHyxStmAlW80 tGHKbRUWczcHsbiuGMhU+noTbnlKv1BkBn75Vc1jOBSfvhc8eQPheWSwnAJ7Glcd44tc/bP4y6w 1uedqt4Z7PrnAAVxfGMoBBClwOr1nY5Y= X-Received: by 2002:a4a:615c:: with SMTP id u28mr10433388ooe.97.1631906497674; Fri, 17 Sep 2021 12:21:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3dPuDuInlcLbpWBTmN1P75tFABKgWLw2sw3cdsIJQbykCXjAO+5pTBNYa9v2n1Va5K/CJ6JuaEZ11BWMOe40= X-Received: by 2002:a4a:615c:: with SMTP id u28mr10433370ooe.97.1631906497471; Fri, 17 Sep 2021 12:21:37 -0700 (PDT) MIME-Version: 1.0 References: <20210917054047.2042843-1-jsnow@redhat.com> <20210917054047.2042843-9-jsnow@redhat.com> In-Reply-To: From: John Snow Date: Fri, 17 Sep 2021 15:21:26 -0400 Message-ID: Subject: Re: [PATCH 08/15] python/aqmp: Create MessageModel and StandaloneModel classes To: Hanna Reitz Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000016b94405cc35d7f7" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-block@nongnu.org, qemu-devel , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000016b94405cc35d7f7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 17, 2021, 9:39 AM Hanna Reitz wrote: > On 17.09.21 07:40, John Snow wrote: > > This allows 'Greeting' to be subclass of 'Message'. We need the adapter > > classes to avoid some typing problems that occur if we try to put too > > much into the 'Model' class itself; the exact details of why are left a= s > > an exercise to the reader. > > > > Why bother? This makes 'Greeting' =E2=8A=86 'Message', which is taxonom= ically > > true; but the real motivation is to be able to inherit and abuse all of > > the Mapping dunders so that we can call dict(greeting) or > > bytes(greeting), for example. > > > > Signed-off-by: John Snow > > --- > > python/qemu/aqmp/models.py | 67 ++++++++++++++++++++++++++++---------= - > > 1 file changed, 50 insertions(+), 17 deletions(-) > > (I feel like this is a bit much outside of my scope, so this=E2=80=99ll h= ave to > do without my R-b.) > It's a patch I like the least, too. I shouldn't have included it here in this series. It needs more time in the oven and it should be included ... somewhere else. Sorry about this one. > --00000000000016b94405cc35d7f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Sep 17, 2021, 9:39 AM Hanna Reitz <hreitz@redhat.com> wrote:
On 17.09.21 07:40, John Snow wrote:
> This allows 'Greeting' to be subclass of 'Message'. We= need the adapter
> classes to avoid some typing problems that occur if we try to put too<= br> > much into the 'Model' class itself; the exact details of why a= re left as
> an exercise to the reader.
>
> Why bother? This makes 'Greeting' =E2=8A=86 'Message',= which is taxonomically
> true; but the real motivation is to be able to inherit and abuse all o= f
> the Mapping dunders so that we can call dict(greeting) or
> bytes(greeting), for example.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>=C2=A0 =C2=A0python/qemu/aqmp/models.py | 67 ++++++++++++++++++++++++++= ++----------
>=C2=A0 =C2=A01 file changed, 50 insertions(+), 17 deletions(-)

(I feel like this is a bit much outside of my scope, so this=E2=80=99ll hav= e to
do without my R-b.)

It's a patch I like the least, too. I shouldn't = have included it here in this series. It needs more time in the oven and it= should be included ... somewhere else.

Sorry about this one.
--00000000000016b94405cc35d7f7--