From: Matteo Croce <mcroce@linux.microsoft.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: ilias.apalodimas@linaro.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
Sven Auhagen <sven.auhagen@voleatech.de>,
Lorenzo Bianconi <lorenzo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Stefan Chulski <stefanc@marvell.com>,
Marcin Wojtas <mw@semihalf.com>,
maxime.chevallier@bootlin.com, antoine.tenart@bootlin.com,
thomas.petazzoni@bootlin.com
Subject: Re: [PATCH net-next 3/4] mvpp2: add basic XDP support
Date: Thu, 2 Jul 2020 12:19:10 +0200 [thread overview]
Message-ID: <CAFnufp1yB8Cqxy=KqWan+E0ukiEDwq=aSWt1hYFYXdqoW9P4Sg@mail.gmail.com> (raw)
In-Reply-To: <20200702090956.GA7682@ranger.igk.intel.com>
On Thu, Jul 2, 2020 at 11:14 AM Maciej Fijalkowski
<maciej.fijalkowski@intel.com> wrote:
> > > + if (port->dev->mtu > ETH_DATA_LEN) {
> > > + netdev_err(port->dev, "Jumbo frames are not supported by XDP, current MTU %d.\n",
> > > + port->dev->mtu);
> >
> > ditto
>
> Here I agree and for every other netdev_err within mvpp2_xdp_setup().
>
Nice idea, I'll add extack error reporting where possible.
--
per aspera ad upstream
next prev parent reply other threads:[~2020-07-02 10:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 18:09 [PATCH net-next 0/4] mvpp2: XDP support Matteo Croce
2020-06-30 18:09 ` [PATCH net-next 1/4] mvpp2: refactor BM pool init percpu code Matteo Croce
2020-06-30 18:09 ` [PATCH net-next 2/4] mvpp2: use page_pool allocator Matteo Croce
2020-07-02 7:31 ` ilias.apalodimas
2020-07-02 9:42 ` Matteo Croce
2020-06-30 18:09 ` [PATCH net-next 3/4] mvpp2: add basic XDP support Matteo Croce
2020-07-02 8:08 ` ilias.apalodimas
2020-07-02 9:09 ` Maciej Fijalkowski
2020-07-02 10:19 ` Matteo Croce [this message]
2020-06-30 18:09 ` [PATCH net-next 4/4] mvpp2: XDP TX support Matteo Croce
2020-07-01 19:18 ` [PATCH net-next 0/4] mvpp2: XDP support Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFnufp1yB8Cqxy=KqWan+E0ukiEDwq=aSWt1hYFYXdqoW9P4Sg@mail.gmail.com' \
--to=mcroce@linux.microsoft.com \
--cc=antoine.tenart@bootlin.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=sven.auhagen@voleatech.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.