From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com [209.85.217.176]) by mail.openembedded.org (Postfix) with ESMTP id A98796013D for ; Fri, 13 Mar 2015 17:03:40 +0000 (UTC) Received: by lbvp9 with SMTP id p9so24141889lbv.8 for ; Fri, 13 Mar 2015 10:03:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=RwsO0zP47QnvZzEnGm1u/A9W3XvPB7ABTnIzR0ena3U=; b=PPe1ElNIiZWke/hsxgYRM0aglDE3wiVyryYujz2rgP0kI+ShzmO5IPzvcPFZEbFC2F rBAs4f0CQhsGcZQmgk3HjHcKiMruD1mx7W1B7RkpGvFoKOQ2/5jAd4beOmP4zm6de7Vq RZrQQs36+y87RNG2WLU6qQ7vn9mt6gRQV/f95HpvTjlPeL+3unXLce4hMD9mNmvabdPC KfY9KHNoOvbNeXSgayf9m59G8h3yRRO5XwQ8w/kaHct9vW66H+e9Yhn4ZqISzKnpsCM6 4Uoe4xWR7P8Zy5xCqRwaEdwk6ff9Tzv5JHTlsnHFV11aD5fiZzj0SolH56VI1N6wAE2M 3Wyg== X-Gm-Message-State: ALoCoQmNKSvURyS9+FQq82OnpceUg5PHW2F2FSND8Nf2h0WYWANVvfPy8Ilh2cYfi200+gJY79ww MIME-Version: 1.0 X-Received: by 10.152.204.42 with SMTP id kv10mr37425426lac.52.1426266220157; Fri, 13 Mar 2015 10:03:40 -0700 (PDT) Received: by 10.112.5.73 with HTTP; Fri, 13 Mar 2015 10:03:40 -0700 (PDT) In-Reply-To: <1426262354.9114.211.camel@linuxfoundation.org> References: <1426258527-2329-1-git-send-email-naresh.bhat@linaro.org> <1426258527-2329-3-git-send-email-naresh.bhat@linaro.org> <1426262354.9114.211.camel@linuxfoundation.org> Date: Fri, 13 Mar 2015 22:33:40 +0530 Message-ID: From: Naresh Bhat To: Richard Purdie Cc: Matt Fleming , oe-core Subject: Re: [OE-core v1 PATCH 2/5] syslinux: Remove bootimg dependency on aarch64 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2015 17:03:43 -0000 Content-Type: multipart/alternative; boundary=001a1135fae268729605112e7b26 --001a1135fae268729605112e7b26 Content-Type: text/plain; charset=UTF-8 On 13 March 2015 at 21:29, Richard Purdie < richard.purdie@linuxfoundation.org> wrote: > On Fri, 2015-03-13 at 20:25 +0530, Naresh Bhat wrote: > > Remove the bootimg dependency as syslinux for aarch64. The reason to > skip the syslinux package > > - syslinux package contains x86 assembly code. Hence it cannot be > compiled on aarch64. > > - There is no BIOS on aarch64 to answer syscalls. > > > > Signed-off-by: Naresh Bhat > > --- > > meta/classes/syslinux.bbclass | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/meta/classes/syslinux.bbclass > b/meta/classes/syslinux.bbclass > > index d6498d9..7bd8fed 100644 > > --- a/meta/classes/syslinux.bbclass > > +++ b/meta/classes/syslinux.bbclass > > @@ -17,7 +17,15 @@ > > # ${SYSLINUX_SERIAL_TTY} - Set alternate console=tty... kernel boot > argument > > # ${SYSLINUX_KERNEL_ARGS} - Add additional kernel arguments > > > > -do_bootimg[depends] += "${MLPREFIX}syslinux:do_populate_sysroot \ > > +def boot_image_depends(bb, d): > > + import re > > + deps = bb.data.getVar('TARGET_PREFIX', d, True) > > + if re.search("(x86_64|i.86).*",deps): > > + return "${MLPREFIX}syslinux:do_populate_sysroot" > > + if re.search("aarch64",deps): > > + return "" > > +BIMGDEP = "${@boot_image_depends(bb, d)}" > > +do_bootimg[depends] += "${BIMGDEP} \ > > syslinux-native:do_populate_sysroot" > > How about something simpler like: > > EXTRABOOTIMGDEPS = "" > EXTRABOOTIMGDEPS_x86 = "${MLPREFIX}syslinux:do_populate_sysroot" > EXTRABOOTIMGDEPS_x86-64 = "${MLPREFIX}syslinux:do_populate_sysroot" > > ? > Thank you very much. Yes, it is more simple. I will test the same implementation and make the changes in the next series. > > Cheers, > > Richard > > --001a1135fae268729605112e7b26 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 13 March 2015 at 21:29, Richard Purdie <richard.pu= rdie@linuxfoundation.org> wrote:
On Fri, 2015-03-13 at 20:25 += 0530, Naresh Bhat wrote:
> Remove the bootimg dependency as syslinux for aarch64. The reason to s= kip the syslinux package
> - syslinux package contains x86 assembly code. Hence it cannot be comp= iled on aarch64.
> - There is no BIOS on aarch64 to answer syscalls.
>
> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
> ---
>=C2=A0 meta/classes/syslinux.bbclass |=C2=A0 =C2=A010 +++++++++-
>=C2=A0 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/syslinux.bbclass b/meta/classes/syslinux.bbc= lass
> index d6498d9..7bd8fed 100644
> --- a/meta/classes/syslinux.bbclass
> +++ b/meta/classes/syslinux.bbclass
> @@ -17,7 +17,15 @@
>=C2=A0 # ${SYSLINUX_SERIAL_TTY} - Set alternate console=3Dtty... kernel= boot argument
>=C2=A0 # ${SYSLINUX_KERNEL_ARGS} - Add additional kernel arguments
>
> -do_bootimg[depends] +=3D "${MLPREFIX}syslinux:do_populate_sysroo= t \
> +def boot_image_depends(bb, d):
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0import re
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0deps =3D bb.data.getVar('TARGET= _PREFIX', d, True)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if re.search("(x86_64|i.86).*&= quot;,deps):
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return = "${MLPREFIX}syslinux:do_populate_sysroot"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if re.search("aarch64",de= ps):
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return = ""
> +BIMGDEP =3D "${@boot_image_depends(bb, d)}"
> +do_bootimg[depends] +=3D "${BIMGDEP} \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 syslinux-native:do_populate_sysroot"

How about something simpler like:

EXTRABOOTIMGDEPS =3D ""
EXTRABOOTIMGDEPS_x86 =3D "${MLPREFIX}syslinux:do_populate_sysroot"= ;
EXTRABOOTIMGDEPS_x86-64 =3D "${MLPREFIX}syslinux:do_populate_sysroot&q= uot;

?
Thank you very much.=C2=A0 Yes, it is more simple. I= will test the same implementation and make the changes in the next series.= =C2=A0

Cheers,

Richard


--001a1135fae268729605112e7b26--