From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005AbbFYQ0G (ORCPT ); Thu, 25 Jun 2015 12:26:06 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:35059 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751932AbbFYQ0B (ORCPT ); Thu, 25 Jun 2015 12:26:01 -0400 MIME-Version: 1.0 In-Reply-To: <20150625115618.GC13366@sudip-PC> References: <1435163120-3253-11-git-send-email-juston.h.li@gmail.com> <20150625115618.GC13366@sudip-PC> Date: Thu, 25 Jun 2015 09:26:00 -0700 X-Google-Sender-Auth: aeocRc6OvBj11d6FVw63VdmigL4 Message-ID: Subject: Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators From: Juston Li To: Sudip Mukherjee Cc: teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Dan Carpenter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee wrote: > On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote: >> fixes checkpatch.pl error: >> ERROR: need consistent spacing around '' > little bit confused. > 1) Your subject says consistent space around operators but here it says > around '' The specific checkpatch.pl error was different for each error, the quotes were suppose to contain the specific operator but I left it out so that there would be one generic error message. The quotes left behind were confusing, sorry. > 2) Considering that you are giving consitent space around operators, then > i think you have missed few operators like '|','&',':' in this > patch. > These were the only instances the checkpatch.pl error came up. This patch only fixes even spacing around a specific operator. Other operators either have even or no spacing around them with PATCH 11/19 fixing any operators with spacing around required. This leaves operators that checkpatch deems spacing as optional which I left as a separate issue to be addressed of making optional spacing of operators consistent with each other. Thanks Juston From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juston Li Date: Thu, 25 Jun 2015 16:26:00 +0000 Subject: Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators Message-Id: List-Id: References: <1435163120-3253-11-git-send-email-juston.h.li@gmail.com> <20150625115618.GC13366@sudip-PC> In-Reply-To: <20150625115618.GC13366@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sudip Mukherjee Cc: teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Dan Carpenter On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee wrote: > On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote: >> fixes checkpatch.pl error: >> ERROR: need consistent spacing around '' > little bit confused. > 1) Your subject says consistent space around operators but here it says > around '' The specific checkpatch.pl error was different for each error, the quotes were suppose to contain the specific operator but I left it out so that there would be one generic error message. The quotes left behind were confusing, sorry. > 2) Considering that you are giving consitent space around operators, then > i think you have missed few operators like '|','&',':' in this > patch. > These were the only instances the checkpatch.pl error came up. This patch only fixes even spacing around a specific operator. Other operators either have even or no spacing around them with PATCH 11/19 fixing any operators with spacing around required. This leaves operators that checkpatch deems spacing as optional which I left as a separate issue to be addressed of making optional spacing of operators consistent with each other. Thanks Juston