From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986AbbFZFxk (ORCPT ); Fri, 26 Jun 2015 01:53:40 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:34469 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbbFZFxd (ORCPT ); Fri, 26 Jun 2015 01:53:33 -0400 MIME-Version: 1.0 In-Reply-To: References: <1435163120-3253-11-git-send-email-juston.h.li@gmail.com> <20150625115618.GC13366@sudip-PC> <20150626040543.GB3050@sudip-PC> Date: Thu, 25 Jun 2015 22:53:33 -0700 X-Google-Sender-Auth: UOuIJ0A5J4h0pV_9007lKtxSK9M Message-ID: Subject: Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators From: Juston Li To: Sudip Mukherjee Cc: teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Dan Carpenter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee wrote: > Usually I use the checkpatch which is in linux-next. That will be the > latest version. If you compare, last commit on checkpatch of staging > tree was on April 16th, where as last commit in linux-next is on > June 19th. And if you use this checkpatch you will see these warnings > also. :) Just wanted to clarify. So even with the linux-next checkpatch.pl, no errors/warnings show for me. Only when I run checkpatch.pl with the '--strict' option does it give the following checks for various operators: CHECK: space preferred before that '|' (ctx:VxE) Are these the warnings you are referring too? Do you want me to fix all of these for this patch? Regards Juston From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juston Li Date: Fri, 26 Jun 2015 05:53:33 +0000 Subject: Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators Message-Id: List-Id: References: <1435163120-3253-11-git-send-email-juston.h.li@gmail.com> <20150625115618.GC13366@sudip-PC> <20150626040543.GB3050@sudip-PC> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sudip Mukherjee Cc: teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Dan Carpenter On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee wrote: > Usually I use the checkpatch which is in linux-next. That will be the > latest version. If you compare, last commit on checkpatch of staging > tree was on April 16th, where as last commit in linux-next is on > June 19th. And if you use this checkpatch you will see these warnings > also. :) Just wanted to clarify. So even with the linux-next checkpatch.pl, no errors/warnings show for me. Only when I run checkpatch.pl with the '--strict' option does it give the following checks for various operators: CHECK: space preferred before that '|' (ctx:VxE) Are these the warnings you are referring too? Do you want me to fix all of these for this patch? Regards Juston