From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Gautam Subject: Re: [Patch v15 4/5] dt-bindings: arm-smmu: Add bindings for qcom, smmu-v2 Date: Wed, 29 Aug 2018 16:53:25 +0530 Message-ID: References: <20180827105551.16346-1-vivek.gautam@codeaurora.org> <20180827105551.16346-5-vivek.gautam@codeaurora.org> <20180828203418.GA18366@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Rob Herring Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux PM , sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Will Deacon , "Rafael J. Wysocki" , open list , "list-Y9sIeH5OGRo@public.gmane.org:IOMMU DRIVERS , Joerg Roedel , " , alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-arm-msm , Andy Gross , freedreno , Robin Murphy List-Id: linux-arm-msm@vger.kernel.org T24gV2VkLCBBdWcgMjksIDIwMTggYXQgMjowNSBQTSBWaXZlayBHYXV0YW0KPHZpdmVrLmdhdXRh bUBjb2RlYXVyb3JhLm9yZz4gd3JvdGU6Cj4KPiBIaSBSb2IsCj4KPgo+IE9uIDgvMjkvMjAxOCAy OjA0IEFNLCBSb2IgSGVycmluZyB3cm90ZToKPiA+IE9uIE1vbiwgQXVnIDI3LCAyMDE4IGF0IDA0 OjI1OjUwUE0gKzA1MzAsIFZpdmVrIEdhdXRhbSB3cm90ZToKPiA+PiBBZGQgYmluZGluZ3MgZG9j IGZvciBRY29tJ3Mgc21tdS12MiBpbXBsZW1lbnRhdGlvbi4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYt Ynk6IFZpdmVrIEdhdXRhbSA8dml2ZWsuZ2F1dGFtQGNvZGVhdXJvcmEub3JnPgo+ID4+IFJldmll d2VkLWJ5OiBUb21hc3ogRmlnYSA8dGZpZ2FAY2hyb21pdW0ub3JnPgo+ID4+IFRlc3RlZC1ieTog U3Jpbml2YXMgS2FuZGFnYXRsYSA8c3Jpbml2YXMua2FuZGFnYXRsYUBsaW5hcm8ub3JnPgo+ID4+ IC0tLQo+ID4+Cj4gPj4gQ2hhbmdlcyBzaW5jZSB2MTQ6Cj4gPj4gICAtIFRoaXMgaXMgYSBuZXcg cGF0Y2ggYWRkZWQgaW4gdjE1IGFmdGVyIG5vdGljaW5nIHRoZSBuZXcKPiA+PiAgICAgY2hlY2tw YXRjaCB3YXJuaW5nIGZvciBzZXBhcmF0ZSBkdC1iaW5kaW5ncyBkb2MuCj4gPj4gICAtIFRoaXMg cGF0Y2ggYWxzbyBhZGRyZXNzZXMgY29tbWVudHMgZ2l2ZW4gYnkgUm9iIGFuZCBSb2JpbiB0byBh ZGQKPiA+PiAgICAgYSBsaXN0IG9mIHZhbGlkIHZhbHVlcyBvZiAnPHNvYz4nIGluICJxY29tLDxz b2M+LXNtbXUtdjIiCj4gPj4gICAgIGNvbXBhdGlibGUgc3RyaW5nLgo+ID4+Cj4gPj4gICAuLi4v ZGV2aWNldHJlZS9iaW5kaW5ncy9pb21tdS9hcm0sc21tdS50eHQgICAgICAgICB8IDQ3ICsrKysr KysrKysrKysrKysrKysrKysKPiA+PiAgIDEgZmlsZSBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCsp Cj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2lvbW11L2FybSxzbW11LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9p b21tdS9hcm0sc21tdS50eHQKPiA+PiBpbmRleCA4YTZmZmNlMTJhZjUuLjUyMTk4YTUzOTYwNiAx MDA2NDQKPiA+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaW9tbXUv YXJtLHNtbXUudHh0Cj4gPj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2lvbW11L2FybSxzbW11LnR4dAo+ID4+IEBAIC0xNywxMCArMTcsMjQgQEAgY29uZGl0aW9ucy4K PiA+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICJhcm0sbW11LTQwMSIKPiA+PiAgICAgICAg ICAgICAgICAgICAgICAgICAgICJhcm0sbW11LTUwMCIKPiA+PiAgICAgICAgICAgICAgICAgICAg ICAgICAgICJjYXZpdW0sc21tdS12MiIKPiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgInFj b20sPHNvYz4tc21tdS12MiIsICJxY29tLHNtbXUtdjIiCj4gPiBUaGUgdjIgaW4gdGhlIGNvbXBh dGlibGUgc3RyaW5nIGlzIGtpbmQgb2YgcmVkdW5kYW50IHVubGVzcyB0aGUgU29DIGhhcwo+ID4g b3RoZXIgU01NVSB0eXBlcy4KPgo+IHNkbTg0NSBoYXMgc21tdS12MiwgYW5kIHNtbXUtNTAwIFsx XS4KPgo+ID4+Cj4gPj4gICAgICAgICAgICAgICAgICAgICBkZXBlbmRpbmcgb24gdGhlIHBhcnRp Y3VsYXIgaW1wbGVtZW50YXRpb24gYW5kL29yIHRoZQo+ID4+ICAgICAgICAgICAgICAgICAgICAg dmVyc2lvbiBvZiB0aGUgYXJjaGl0ZWN0dXJlIGltcGxlbWVudGVkLgo+ID4+Cj4gPj4gKyAgICAg ICAgICAgICAgICAgIEEgbnVtYmVyIG9mIFFjb20gU29DcyB1c2UgcWNvbSxzbW11LXYyIHZlcnNp b24gb2YgdGhlIElQLgo+ID4+ICsgICAgICAgICAgICAgICAgICAicWNvbSw8c29jPi1zbW11LXYy IiByZXByZXNlbnRzIGEgc29jIHNwZWNpZmljIGNvbXBhdGlibGUKPiA+PiArICAgICAgICAgICAg ICAgICAgc3RyaW5nIHRoYXQgc2hvdWxkIGJlIHByZXNlbnQgYWxvbmcgd2l0aCB0aGUgInFjb20s c21tdS12MiIKPiA+PiArICAgICAgICAgICAgICAgICAgdG8gZmFjaWxpdGF0ZSBTb0Mgc3BlY2lm aWMgY2xvY2tzL3Bvd2VyIGNvbm5lY3Rpb25zIGFuZCB0bwo+ID4+ICsgICAgICAgICAgICAgICAg ICBhZGRyZXNzIHNwZWNpZmljIGJ1ZyBmaXhlcy4KPiA+PiArICAgICAgICAgICAgICAgICAgJzxz b2M+JyBzdHJpbmcgaW4gInFjb20sPHNvYz4tc21tdS12MiIgc2hvdWxkIGJlIG9uZSBvZiB0aGUK PiA+PiArICAgICAgICAgICAgICAgICAgZm9sbG93aW5nOgo+ID4+ICsgICAgICAgICAgICAgICAg ICBtc204OTk2IC0gZm9yIG1zbTg5OTYgUWNvbSBTb0MuCj4gPj4gKyAgICAgICAgICAgICAgICAg IHNkbTg0NSAtIGZvciBzZG04NDUgUWNvbSBTb2MuCj4gPiBSYXRoZXIgdGhhbiBhbGwgdGhpcyBw cm9zZSwgaXQgd291bGQgYmUgc2ltcGxlciB0byBqdXN0IGFkZCAyIGxpbmVzIHdpdGgKPiA+IHRo ZSBmdWxsIGNvbXBhdGlibGVzIHJhdGhlciB0aGFuIDxzb2M+LiBUaGUgPHNvYz4gdGhpbmcgaXMg bm90IGdvaW5nIHRvCj4gPiB3b3JrIHdoZW4vaWYgd2UgbW92ZSBiaW5kaW5ncyB0byBqc29uLXNj aGVtYSBhbHNvLgo+Cj4gdGhlbiB3ZSBrZWVwIGFkZGluZwo+ICAgICAgICAgICAicWNvbSxtc204 OTk2LXNtbXUtdjIiLCAicWNvbSxzbW11LXYyIgo+ICAgICAgICAgICAicWNvbSxtc204OTk4LXNt bXUtdjIiLCAicWNvbSxzbW11LXYyIgo+ICAgICAgICAgICAicWNvbSxzZG04NDUtc21tdS12MiIs ICJxY29tLHNtbXUtdjIiLAo+IGFuZCBmcm9tIFsxXQo+ICAgICAgICAgICAicWNvbSxzZG04NDUt c21tdS01MDAiLCAiYXJtLG1tdS01MDAiLCBldGMuCj4gZm9yIGVhY2ggU29Dcz8KCkhvdyBhYm91 dCBmb2xsb3dpbmcgZGlmZiBvbiB0b3Agb2YgdGhpcyBwYXRjaD8KCmRpZmYgLS1naXQgYS9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaW9tbXUvYXJtLHNtbXUudHh0CmIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2lvbW11L2FybSxzbW11LnR4dAppbmRleCA1MjE5 OGE1Mzk2MDYuLjVlNmMwNDg3NjUzMyAxMDA2NDQKLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL2lvbW11L2FybSxzbW11LnR4dAorKysgYi9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvaW9tbXUvYXJtLHNtbXUudHh0CkBAIC0xNywyMyArMTcsMTggQEAgY29u ZGl0aW9ucy4KICAgICAgICAgICAgICAgICAgICAgICAgICJhcm0sbW11LTQwMSIKICAgICAgICAg ICAgICAgICAgICAgICAgICJhcm0sbW11LTUwMCIKICAgICAgICAgICAgICAgICAgICAgICAgICJj YXZpdW0sc21tdS12MiIKLSAgICAgICAgICAgICAgICAgICAgICAgICJxY29tLDxzb2M+LXNtbXUt djIiLCAicWNvbSxzbW11LXYyIgorICAgICAgICAgICAgICAgICAgICAgICAgInFjb20sc21tdS12 MiIKCiAgICAgICAgICAgICAgICAgICBkZXBlbmRpbmcgb24gdGhlIHBhcnRpY3VsYXIgaW1wbGVt ZW50YXRpb24gYW5kL29yIHRoZQogICAgICAgICAgICAgICAgICAgdmVyc2lvbiBvZiB0aGUgYXJj aGl0ZWN0dXJlIGltcGxlbWVudGVkLgoKLSAgICAgICAgICAgICAgICAgIEEgbnVtYmVyIG9mIFFj b20gU29DcyB1c2UgcWNvbSxzbW11LXYyIHZlcnNpb24gb2YgdGhlIElQLgotICAgICAgICAgICAg ICAgICAgInFjb20sPHNvYz4tc21tdS12MiIgcmVwcmVzZW50cyBhIHNvYyBzcGVjaWZpYyBjb21w YXRpYmxlCi0gICAgICAgICAgICAgICAgICBzdHJpbmcgdGhhdCBzaG91bGQgYmUgcHJlc2VudCBh bG9uZyB3aXRoIHRoZSAicWNvbSxzbW11LXYyIgotICAgICAgICAgICAgICAgICAgdG8gZmFjaWxp dGF0ZSBTb0Mgc3BlY2lmaWMgY2xvY2tzL3Bvd2VyIGNvbm5lY3Rpb25zIGFuZCB0bwotICAgICAg ICAgICAgICAgICAgYWRkcmVzcyBzcGVjaWZpYyBidWcgZml4ZXMuCi0gICAgICAgICAgICAgICAg ICAnPHNvYz4nIHN0cmluZyBpbiAicWNvbSw8c29jPi1zbW11LXYyIiBzaG91bGQgYmUgb25lIG9m IHRoZQotICAgICAgICAgICAgICAgICAgZm9sbG93aW5nOgotICAgICAgICAgICAgICAgICAgbXNt ODk5NiAtIGZvciBtc204OTk2IFFjb20gU29DLgotICAgICAgICAgICAgICAgICAgc2RtODQ1IC0g Zm9yIHNkbTg0NSBRY29tIFNvYy4KLQotICAgICAgICAgICAgICAgICAgQW4gZXhhbXBsZSBzdHJp bmcgd291bGQgYmUgLQotICAgICAgICAgICAgICAgICAgInFjb20sbXNtODk5Ni1zbW11LXYyIiwg InFjb20sc21tdS12MiIuCisgICAgICAgICAgICAgICAgICBRY29tIFNvQ3MgdXNpbmcgcWNvbSxz bW11LXYyIG11c3QgaGF2ZSBzb2Mgc3BlY2lmaWMKKyAgICAgICAgICAgICAgICAgIGNvbXBhdGli bGUgc3RyaW5nIGF0dGFjaGVkIHRvICJxY29tLHNtbXUtdjIiIHRvIHRha2UgY2FyZQorICAgICAg ICAgICAgICAgICAgb2YgU29DIHNwZWNpZmljIGNsb2Nrcy9wb3dlciBjb25uZWN0aW9ucyBhbmQg dG8gYWRkcmVzcworICAgICAgICAgICAgICAgICAgc3BlY2lmaWMgYnVnIGZpeGVzLgorICAgICAg ICAgICAgICAgICAgUHJlY2lzZWx5LCBpdCBzaG91bGQgYmUgb25lIG9mIHRoZSBmb2xsb3dpbmc6 CisgICAgICAgICAgICAgICAgICAicWNvbSxtc204OTk2LXNtbXUtdjIiLCAicWNvbSxzbW11LXYy IiwKKyAgICAgICAgICAgICAgICAgICJxY29tLHNkbTg0NS1zbW11LXYyIiwgInFjb20sc21tdS12 MiIuCgpUaGFua3MhCkJlc3QgcmVnYXJkcwpWaXZlawoKLS0gClFVQUxDT01NIElORElBLCBvbiBi ZWhhbGYgb2YgUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIKb2Yg Q29kZSBBdXJvcmEgRm9ydW0sIGhvc3RlZCBieSBUaGUgTGludXggRm91bmRhdGlvbgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGlu ZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D723C433F5 for ; Wed, 29 Aug 2018 11:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1650C20862 for ; Wed, 29 Aug 2018 11:23:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="dwXoBdTM"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="PUb76AGv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1650C20862 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728359AbeH2PUG (ORCPT ); Wed, 29 Aug 2018 11:20:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58636 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727264AbeH2PUF (ORCPT ); Wed, 29 Aug 2018 11:20:05 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 690F760265; Wed, 29 Aug 2018 11:23:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1535541819; bh=r79vgoWTCc/sRzXWAXFT8gFumJhInCWlKBcATlv6w7o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dwXoBdTMu0oD1EkB9eEiT7iGcRFMyEXjrW5siLhe3Z4DiPD4QPgCQb7fLhgEYzk3i XTTR+y3FiA+QDmN08fnmwZBHMq6RAJ8Igi3cNJNjNRBI9y9ODidcylPSmXVxjJsVcL 0mD6uHw/dTaRp6+K9WC0F6Hu1qyrqmr0nKxFsrp0= Received: from mail-qt0-f172.google.com (mail-qt0-f172.google.com [209.85.216.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vivek.gautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 17D3360385; Wed, 29 Aug 2018 11:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1535541818; bh=r79vgoWTCc/sRzXWAXFT8gFumJhInCWlKBcATlv6w7o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PUb76AGvft7Xi9Z118pXIByAacdOxfs1gZGWJHzeSI88Qdk1p2seLqUnRZr+Swzqv yFqeD/WhQH7ykWYVcttYfE+a07gGRhl5ORRIDfDxiiPhum5jSijqffUjQWXYSlh8as SRW1W3PVJLndQJXzFtYr+A0ZfCQG6XS/gCfWJdhM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 17D3360385 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org Received: by mail-qt0-f172.google.com with SMTP id j7-v6so5248700qtp.2; Wed, 29 Aug 2018 04:23:38 -0700 (PDT) X-Gm-Message-State: APzg51CLz/6xVlzI5WGUqihpk980C/70xPGhY8rIkfpa5Xl/8TUZsyvF VCm6mVx8BOCkjW85fNhN9VVLVPwc7DgtKm/mIdE= X-Google-Smtp-Source: ANB0VdYMfQgB/udt1DfZ5dRLKdHU/GbwyPLCobQQtNEsedXinVrVJMGhdlvny+b8pArUXkfIFUtUknm7KPeDtMrIqAQ= X-Received: by 2002:ac8:4596:: with SMTP id l22-v6mr6319184qtn.184.1535541817264; Wed, 29 Aug 2018 04:23:37 -0700 (PDT) MIME-Version: 1.0 References: <20180827105551.16346-1-vivek.gautam@codeaurora.org> <20180827105551.16346-5-vivek.gautam@codeaurora.org> <20180828203418.GA18366@bogus> In-Reply-To: From: Vivek Gautam Date: Wed, 29 Aug 2018 16:53:25 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Patch v15 4/5] dt-bindings: arm-smmu: Add bindings for qcom,smmu-v2 To: Rob Herring Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , alex.williamson@redhat.com, "Rafael J. Wysocki" , sboyd@kernel.org, freedreno , Linux PM , Will Deacon , open list , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , linux-arm-msm , Andy Gross , Robin Murphy Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 29, 2018 at 2:05 PM Vivek Gautam wrote: > > Hi Rob, > > > On 8/29/2018 2:04 AM, Rob Herring wrote: > > On Mon, Aug 27, 2018 at 04:25:50PM +0530, Vivek Gautam wrote: > >> Add bindings doc for Qcom's smmu-v2 implementation. > >> > >> Signed-off-by: Vivek Gautam > >> Reviewed-by: Tomasz Figa > >> Tested-by: Srinivas Kandagatla > >> --- > >> > >> Changes since v14: > >> - This is a new patch added in v15 after noticing the new > >> checkpatch warning for separate dt-bindings doc. > >> - This patch also addresses comments given by Rob and Robin to add > >> a list of valid values of '' in "qcom,-smmu-v2" > >> compatible string. > >> > >> .../devicetree/bindings/iommu/arm,smmu.txt | 47 ++++++++++++++++++++++ > >> 1 file changed, 47 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.txt b/Documentation/devicetree/bindings/iommu/arm,smmu.txt > >> index 8a6ffce12af5..52198a539606 100644 > >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.txt > >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.txt > >> @@ -17,10 +17,24 @@ conditions. > >> "arm,mmu-401" > >> "arm,mmu-500" > >> "cavium,smmu-v2" > >> + "qcom,-smmu-v2", "qcom,smmu-v2" > > The v2 in the compatible string is kind of redundant unless the SoC has > > other SMMU types. > > sdm845 has smmu-v2, and smmu-500 [1]. > > >> > >> depending on the particular implementation and/or the > >> version of the architecture implemented. > >> > >> + A number of Qcom SoCs use qcom,smmu-v2 version of the IP. > >> + "qcom,-smmu-v2" represents a soc specific compatible > >> + string that should be present along with the "qcom,smmu-v2" > >> + to facilitate SoC specific clocks/power connections and to > >> + address specific bug fixes. > >> + '' string in "qcom,-smmu-v2" should be one of the > >> + following: > >> + msm8996 - for msm8996 Qcom SoC. > >> + sdm845 - for sdm845 Qcom Soc. > > Rather than all this prose, it would be simpler to just add 2 lines with > > the full compatibles rather than . The thing is not going to > > work when/if we move bindings to json-schema also. > > then we keep adding > "qcom,msm8996-smmu-v2", "qcom,smmu-v2" > "qcom,msm8998-smmu-v2", "qcom,smmu-v2" > "qcom,sdm845-smmu-v2", "qcom,smmu-v2", > and from [1] > "qcom,sdm845-smmu-500", "arm,mmu-500", etc. > for each SoCs? How about following diff on top of this patch? diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.txt b/Documentation/devicetree/bindings/iommu/arm,smmu.txt index 52198a539606..5e6c04876533 100644 --- a/Documentation/devicetree/bindings/iommu/arm,smmu.txt +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.txt @@ -17,23 +17,18 @@ conditions. "arm,mmu-401" "arm,mmu-500" "cavium,smmu-v2" - "qcom,-smmu-v2", "qcom,smmu-v2" + "qcom,smmu-v2" depending on the particular implementation and/or the version of the architecture implemented. - A number of Qcom SoCs use qcom,smmu-v2 version of the IP. - "qcom,-smmu-v2" represents a soc specific compatible - string that should be present along with the "qcom,smmu-v2" - to facilitate SoC specific clocks/power connections and to - address specific bug fixes. - '' string in "qcom,-smmu-v2" should be one of the - following: - msm8996 - for msm8996 Qcom SoC. - sdm845 - for sdm845 Qcom Soc. - - An example string would be - - "qcom,msm8996-smmu-v2", "qcom,smmu-v2". + Qcom SoCs using qcom,smmu-v2 must have soc specific + compatible string attached to "qcom,smmu-v2" to take care + of SoC specific clocks/power connections and to address + specific bug fixes. + Precisely, it should be one of the following: + "qcom,msm8996-smmu-v2", "qcom,smmu-v2", + "qcom,sdm845-smmu-v2", "qcom,smmu-v2". Thanks! Best regards Vivek -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation