From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Gautam Subject: Re: [PATCH v2 1/4] dt-bindings: phy: Add support for QUSB2 phy Date: Tue, 29 Nov 2016 10:50:59 +0530 Message-ID: References: <1479816163-5260-1-git-send-email-vivek.gautam@codeaurora.org> <1479816163-5260-2-git-send-email-vivek.gautam@codeaurora.org> <20161128141944.4sfptmymh5kcpcwm@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:54392 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753066AbcK2FVQ (ORCPT ); Tue, 29 Nov 2016 00:21:16 -0500 In-Reply-To: <20161128141944.4sfptmymh5kcpcwm@rob-hp-laptop> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Rob Herring Cc: kishon , Mark Rutland , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Srinivas Kandagatla , Stephen Boyd , linux-arm-msm@vger.kernel.org Hi Rob, On Mon, Nov 28, 2016 at 7:49 PM, Rob Herring wrote: Thanks for reviewing the patch. > On Tue, Nov 22, 2016 at 05:32:40PM +0530, Vivek Gautam wrote: >> Qualcomm chipsets have QUSB2 phy controller that provides >> HighSpeed functionality for DWC3 controller. >> Adding dt binding information for the same. >> >> Signed-off-by: Vivek Gautam >> --- >> >> Changes since v1: >> - New patch, forked out of the original driver patch: >> "phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips" >> - Updated dt bindings to remove 'hstx-trim-bit-offset' and >> 'hstx-trim-bit-len' bindings. >> >> .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 55 ++++++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt >> new file mode 100644 >> index 0000000..38c8b30 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt >> @@ -0,0 +1,55 @@ >> +Qualcomm QUSB2 phy controller >> +============================= >> + >> +QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. >> + >> +Required properties: >> + - compatible: compatible list, contains "qcom,msm8996-qusb2-phy". >> + - reg: offset and length of the PHY register set. >> + - #phy-cells: must be 0. >> + >> + - clocks: a list of phandles and clock-specifier pairs, >> + one for each entry in clock-names. >> + - clock-names: must be "cfg_ahb" for phy config clock, >> + "ref_clk" for 19.2 MHz ref clk, >> + "ref_clk_src" reference clock source. >> + "iface" for phy interface clock (Optional). >> + >> + - vdd-phy-supply: Phandle to a regulator supply to PHY core block. >> + - vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block. >> + - vdda-phy-dpdm: Phandle to 3.1V regulator supply to Dp/Dm port signals. > > Needs '-supply' sure, will add. > >> + >> + - resets: a list of phandles and reset controller specifier pairs, >> + one for each entry in reset-names. >> + - reset-names: must be "phy" for reset of phy block. >> + >> +Optional properties: >> + - nvmem-cells: a list of phandles to nvmem cells that contain fused >> + tuning parameters for qusb2 phy, one for each entry >> + in nvmem-cell-names. >> + - nvmem-cell-names: must be "tune2_hstx_trim_efuse" for cell containing >> + HS Tx trim value. >> + >> + - qcom,tcsr-syscon: Phandle to TCSR syscon register region. >> + >> +Example: >> + hsphy: qusb2phy@7411000 { > > usb-phy@... Or may be just 'phy' for the node name, and then label could be 'usb_hs_phy'? [...] Thanks Vivek -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project