From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC67C47082 for ; Thu, 3 Jun 2021 13:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58B96613F2 for ; Thu, 3 Jun 2021 13:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231220AbhFCN6L (ORCPT ); Thu, 3 Jun 2021 09:58:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbhFCN6K (ORCPT ); Thu, 3 Jun 2021 09:58:10 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65530C06174A for ; Thu, 3 Jun 2021 06:56:09 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id w9so3172582qvi.13 for ; Thu, 03 Jun 2021 06:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uged.al; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fFoCEkJHlYaCqbo7kftj3nQYJl4JAya0mNURfk0G9Fo=; b=iOGRGKMMJ7mjrGAdEcby7lsIBWbsY9FmTD/4P6CUXobrP5vRdX5NYZlmK1uLe9dvLm z1YBOrXjyC64sc+6mGqhkgxtKmepkCsmdBv5T1o8rkEUgNLLB3G1th843k76n+w7wHd+ wBxBLE9mapL58Sm8CD8BxlTz4dg7g3OzYg5zu1jJpMfAT1rIWGWNmJ6u55SGUEFkKclh HSKpx6Dyn20lsWeyWlv8dS05FWBs9MzSCS2jCUsGC3/IyBZrQVetFMVgDLEFwVPdDCmt VEFQd4XCnOAdznbWTJ7tKlTjnPFWvqvNoJk32txKZ4ZL09ETySALU4AfVW13V++mNOlH oRqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fFoCEkJHlYaCqbo7kftj3nQYJl4JAya0mNURfk0G9Fo=; b=EyEKpA50wqrhnvwUxAgoNnnZU1YZtc48e5Dza+R71t4q+P+U9aHvddhxAoNzZL2SZP lXwk+R3Ywo0S7bodConn9iluLNHr1FBm9tB69XaQhRUseUMfZ/6GuwzFgb6i4GeLTkAV kw9PPZJs2qmp8VDkDqPPiThJU4YU7omkqgW+aANrlL/1Coa/nsvrJQ6WQvySb5gvuKRq nxVcO0+80c/k8r2j1tJNAtKjv/wj0AidIPk6jw6vBK0IthEhqi3ZfHx1Mm6D+VK6iyzm G9xFJEv1m9JyqXHSnMcA+apZbVAMcTLMJqcgCZpdDZgY9ejelmXd8W1/QPIDJ7cKIt4g DUDQ== X-Gm-Message-State: AOAM531evN7LZHOIB9wgwpmb2uDMkYhd0IIJBgpvN5dhCkBQWWfjp2V/ RJIaiYr/j4IkysUZQAj44dotDDXB3lEBGtNCA0i6cw== X-Google-Smtp-Source: ABdhPJzgYoxPqkgvsYk9l6uq26oBNtV19sZUxDEha83osjjivigH/jyWaB4Pso/7pgj/Enw04BwYsAaKsWyd7xEPUvE= X-Received: by 2002:a0c:fa4a:: with SMTP id k10mr12353155qvo.18.1622728568553; Thu, 03 Jun 2021 06:56:08 -0700 (PDT) MIME-Version: 1.0 References: <20210603113847.163512-1-odin@uged.al> In-Reply-To: From: Odin Ugedal Date: Thu, 3 Jun 2021 15:55:29 +0200 Message-ID: Subject: Re: [PATCH v2] sched/fair: Correctly insert cfs_rq's to list on unthrottle To: Vincent Guittot Cc: Odin Ugedal , Ingo Molnar , Peter Zijlstra , Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , "open list:CONTROL GROUP (CGROUP)" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > If it's only a matter of waiting other PELT patches to be merged, we > should use cfs_rq_is_decayed(). ACK. will post a v3. > if load_avg!=0, we will update it periodically and sync > tg_load_avg_contrib with the former. So it's not a problem. > > The other way was a problem because we stop updating load_avg and > tg_load_avg_contrib when load_avg/load_sum is null so the > tg_load_avg_contrib is stalled with a possibly very old value Yeah, that makes sense. Thanks Odin