From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753223AbeDRJSe (ORCPT ); Wed, 18 Apr 2018 05:18:34 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:39919 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbeDRJSb (ORCPT ); Wed, 18 Apr 2018 05:18:31 -0400 X-Google-Smtp-Source: AB8JxZqZRgFUXbrtxXGSy2ndyJ2DJ4QKj5PavT86qAErkXV5w0BMa714YFAtTK5x0P/Rt92gGcfc4G+fcCVkLullEgs= MIME-Version: 1.0 In-Reply-To: References: <20180405095000.9756-1-enric.balletbo@collabora.com> <20180405095000.9756-29-enric.balletbo@collabora.com> From: Enric Balletbo Serra Date: Wed, 18 Apr 2018 11:18:30 +0200 Message-ID: Subject: Re: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier To: Tomasz Figa Cc: a.hajda@samsung.com, David Airlie , dri-devel , Douglas Anderson , Thierry Reding , Laurent Pinchart , Yakir Yang , kernel@collabora.com, Marek Szyprowski , linux-samsung-soc , rydberg@bitmath.org, Krzysztof Kozlowski , "open list:ARM/Rockchip SoC..." , Kukjin Kim , linux-input@vger.kernel.org, =?UTF-8?Q?=C3=98rjan_Eide?= , Caesar Wang , Jeffy , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Mark yao , =?UTF-8?B?546L5b6B5aKe?= , Lin Huang , Jingoo Han , Seung-Woo Kim , Linux Kernel Mailing List , Kyungmin Park , Enric Balletbo i Serra , kuankuan.y@gmail.com, Haixia Shi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrzej, Tomasz 2018-04-16 15:12 GMT+02:00 Tomasz Figa : > Hi Andrzej, > > On Mon, Apr 16, 2018 at 6:57 PM Andrzej Hajda wrote: > >> On 05.04.2018 11:49, Enric Balletbo i Serra wrote: >> > From: Tomasz Figa >> > >> > It looks like the driver subsystem detaches devices from power domains >> > at shutdown without consent of the drivers. > >> It looks bit strange. Could you elaborate more on it. Could you show the >> code performing the detach? > > It not only looks strange, but it is strange. The code was present in 4.4: > > https://elixir.bootlin.com/linux/v4.4.128/source/drivers/base/platform.c#L553 > > but was apparently removed in 4.5: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/base/platform.c?h=next-20180416&id=2d30bb0b3889adf09b342722b2ce596c0763bc93 > > So we might not need this patch anymore. > Right, seems that we don't need this patch anymore, I'll do more few tests and likely remove this patch from this series. Thanks for catching this. Best regards, Enric > Best regards, > Tomasz > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Enric Balletbo Serra Subject: Re: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier Date: Wed, 18 Apr 2018 11:18:30 +0200 Message-ID: References: <20180405095000.9756-1-enric.balletbo@collabora.com> <20180405095000.9756-29-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomasz Figa Cc: David Airlie , dri-devel , Linux Kernel Mailing List , Thierry Reding , Laurent Pinchart , Yakir Yang , kernel@collabora.com, Marek Szyprowski , linux-samsung-soc , rydberg@bitmath.org, Krzysztof Kozlowski , "open list:ARM/Rockchip SoC..." , Kukjin Kim , linux-input@vger.kernel.org, =?UTF-8?Q?=C3=98rjan_Eide?= , Caesar Wang , Jeffy , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Mark yao , =?UTF-8?B List-Id: linux-input@vger.kernel.org SGkgQW5kcnplaiwgVG9tYXN6CgoyMDE4LTA0LTE2IDE1OjEyIEdNVCswMjowMCBUb21hc3ogRmln YSA8dGZpZ2FAY2hyb21pdW0ub3JnPjoKPiBIaSBBbmRyemVqLAo+Cj4gT24gTW9uLCBBcHIgMTYs IDIwMTggYXQgNjo1NyBQTSBBbmRyemVqIEhhamRhIDxhLmhhamRhQHNhbXN1bmcuY29tPiB3cm90 ZToKPgo+PiBPbiAwNS4wNC4yMDE4IDExOjQ5LCBFbnJpYyBCYWxsZXRibyBpIFNlcnJhIHdyb3Rl Ogo+PiA+IEZyb206IFRvbWFzeiBGaWdhIDx0ZmlnYUBjaHJvbWl1bS5vcmc+Cj4+ID4KPj4gPiBJ dCBsb29rcyBsaWtlIHRoZSBkcml2ZXIgc3Vic3lzdGVtIGRldGFjaGVzIGRldmljZXMgZnJvbSBw b3dlciBkb21haW5zCj4+ID4gYXQgc2h1dGRvd24gd2l0aG91dCBjb25zZW50IG9mIHRoZSBkcml2 ZXJzLgo+Cj4+IEl0IGxvb2tzIGJpdCBzdHJhbmdlLiBDb3VsZCB5b3UgZWxhYm9yYXRlIG1vcmUg b24gaXQuIENvdWxkIHlvdSBzaG93IHRoZQo+PiBjb2RlIHBlcmZvcm1pbmcgdGhlIGRldGFjaD8K Pgo+IEl0IG5vdCBvbmx5IGxvb2tzIHN0cmFuZ2UsIGJ1dCBpdCBpcyBzdHJhbmdlLiBUaGUgY29k ZSB3YXMgcHJlc2VudCBpbiA0LjQ6Cj4KPiBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51 eC92NC40LjEyOC9zb3VyY2UvZHJpdmVycy9iYXNlL3BsYXRmb3JtLmMjTDU1Mwo+Cj4gYnV0IHdh cyBhcHBhcmVudGx5IHJlbW92ZWQgaW4gNC41Ogo+Cj4gaHR0cHM6Ly9naXQua2VybmVsLm9yZy9w dWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvbmV4dC9saW51eC1uZXh0LmdpdC9jb21taXQvZHJpdmVy cy9iYXNlL3BsYXRmb3JtLmM/aD1uZXh0LTIwMTgwNDE2JmlkPTJkMzBiYjBiMzg4OWFkZjA5YjM0 MjcyMmIyY2U1OTZjMDc2M2JjOTMKPgo+IFNvIHdlIG1pZ2h0IG5vdCBuZWVkIHRoaXMgcGF0Y2gg YW55bW9yZS4KPgoKUmlnaHQsIHNlZW1zIHRoYXQgd2UgZG9uJ3QgbmVlZCB0aGlzIHBhdGNoIGFu eW1vcmUsIEknbGwgZG8gbW9yZSBmZXcKdGVzdHMgYW5kIGxpa2VseSByZW1vdmUgdGhpcyBwYXRj aCBmcm9tIHRoaXMgc2VyaWVzLiBUaGFua3MgZm9yCmNhdGNoaW5nIHRoaXMuCgpCZXN0IHJlZ2Fy ZHMsCiAgRW5yaWMKCj4gQmVzdCByZWdhcmRzLAo+IFRvbWFzego+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+ IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: eballetbo@gmail.com (Enric Balletbo Serra) Date: Wed, 18 Apr 2018 11:18:30 +0200 Subject: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier In-Reply-To: References: <20180405095000.9756-1-enric.balletbo@collabora.com> <20180405095000.9756-29-enric.balletbo@collabora.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Andrzej, Tomasz 2018-04-16 15:12 GMT+02:00 Tomasz Figa : > Hi Andrzej, > > On Mon, Apr 16, 2018 at 6:57 PM Andrzej Hajda wrote: > >> On 05.04.2018 11:49, Enric Balletbo i Serra wrote: >> > From: Tomasz Figa >> > >> > It looks like the driver subsystem detaches devices from power domains >> > at shutdown without consent of the drivers. > >> It looks bit strange. Could you elaborate more on it. Could you show the >> code performing the detach? > > It not only looks strange, but it is strange. The code was present in 4.4: > > https://elixir.bootlin.com/linux/v4.4.128/source/drivers/base/platform.c#L553 > > but was apparently removed in 4.5: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/base/platform.c?h=next-20180416&id=2d30bb0b3889adf09b342722b2ce596c0763bc93 > > So we might not need this patch anymore. > Right, seems that we don't need this patch anymore, I'll do more few tests and likely remove this patch from this series. Thanks for catching this. Best regards, Enric > Best regards, > Tomasz > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel