From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Reimer Date: Mon, 2 Mar 2015 11:31:01 -0700 Subject: [U-Boot] [PATCH] mmc: sdhci: don't clobber adjacent registers In-Reply-To: <1424728618-5651-1-git-send-email-mreimer@sdgsystems.com> References: <59894801-EB21-4D2D-BB0F-173DB669610B@antoniou-consulting.com> <1424728618-5651-1-git-send-email-mreimer@sdgsystems.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Feb 23, 2015 at 2:56 PM, Matt Reimer wrote: > SDHCI_HOST_CONTROL is a byte-sized register, so don't write to it > as if it were a long, as that would result in clobbering the three > registers following. > > Signed-off-by: Matt Reimer > --- > drivers/mmc/sdhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c > index 82d7984..1f8917b 100644 > --- a/drivers/mmc/sdhci.c > +++ b/drivers/mmc/sdhci.c > @@ -412,7 +412,7 @@ static int sdhci_init(struct mmc *mmc) > if (host->quirks & SDHCI_QUIRK_NO_CD) { > unsigned int status; > > - sdhci_writel(host, SDHCI_CTRL_CD_TEST_INS | > SDHCI_CTRL_CD_TEST, > + sdhci_writeb(host, SDHCI_CTRL_CD_TEST_INS | > SDHCI_CTRL_CD_TEST, > SDHCI_HOST_CONTROL); > > status = sdhci_readl(host, SDHCI_PRESENT_STATE); > -- > 1.7.9.5 > > ping