From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A450C433FF for ; Mon, 29 Jul 2019 08:33:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26272206E0 for ; Mon, 29 Jul 2019 08:33:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yj2x/YP+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727733AbfG2IdJ (ORCPT ); Mon, 29 Jul 2019 04:33:09 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:41026 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726305AbfG2IdJ (ORCPT ); Mon, 29 Jul 2019 04:33:09 -0400 Received: by mail-lf1-f68.google.com with SMTP id 62so36568667lfa.8 for ; Mon, 29 Jul 2019 01:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fzjgi5IYwtgWKCD94QQKl1WKdW6R14NVG7cIaq5hNd0=; b=Yj2x/YP+GQx3u0ETLl95DFn76V+nUeZ0HgcyvoUS0J23BQZRtMVjzIjCk80uAnKs7Q HQlRZ1Ixt54mk2Xl0CPAS4hhA/sUUWDDv5/rRB2v+KHQ4C83QqlXf3PwcGVgrK44gXGK T8QwJf/xyMFHhs2/N13YRy+O5ZrAaWHzCrT+9uVBY8T0e9XoY4vKw0aMc3l5RNtlaUye 2VNkfpFLe1kIUERcSgFAVPZYdYW3WF1u+Y7yXdwTmDoI1JjojonOcWFQNJEu9zZ2L+Ms iR7gq/NDAQVjh7NAv7l7QBoZvm7uLNemt8yUQrhf5sdM60rK76dfCnEyAtS40qTLkvPy d9ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fzjgi5IYwtgWKCD94QQKl1WKdW6R14NVG7cIaq5hNd0=; b=qFqFX15699i5pVKnmvmgp6xCheXTbEIccEl9xPnjqstv88w2yDNg3Ov/52XHsUbZGk oMQD6c4Tj3CjOgr8joXF+IQ6XT8VEfKJi+RxMcdoKARh3USoL1JzTxLNaikXCN3Kt7Ng Mib1VbA4Eqw83Muf1G4HTXJ9sEzfDxtE/7yfj5osmn71avUjdNsiCrqekPabTmpY90ck bHBVuGWQywtfV7NEiSVOWpJ3HXXeq9s6j0v2wqbrvAbDT0s7P2ge0wclJhTFrQqevcX4 VzZsXfJ71p9sdVNq7VnFcsByxj3jsC+K4N8Y8lM919YIdCSO95anD7EkROXlX8KHnE3n rI3g== X-Gm-Message-State: APjAAAXu6R9o9H/Qac5peR9b6BOxxUAAGGPFUBTe3HY0MB9XVuvYBbap gPapBjODt/sL9nI93mr9XNhmwNpCL93Hg2+Lz5FHFw== X-Google-Smtp-Source: APXvYqxOB3hlBmp/ELmfdAvewRmPGBGlLy908aDcnO5gzCSlHvcgEUZGOZj5/xu4Z+SD47jako1Nt3Hob11dDINtGdM= X-Received: by 2002:a19:5e10:: with SMTP id s16mr49683043lfb.13.1564389186319; Mon, 29 Jul 2019 01:33:06 -0700 (PDT) MIME-Version: 1.0 References: <20190215024830.GA26477@jordon-HP-15-Notebook-PC> <20190728180611.GA20589@mail-itl> In-Reply-To: From: Souptick Joarder Date: Mon, 29 Jul 2019 14:02:54 +0530 Message-ID: Subject: Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev.c: Convert to use vm_map_pages() To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Andrew Morton , Matthew Wilcox , Michal Hocko , Boris Ostrovsky , Juergen Gross , Russell King - ARM Linux , robin.murphy@arm.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 29, 2019 at 1:35 PM Souptick Joarder wro= te: > > On Sun, Jul 28, 2019 at 11:36 PM Marek Marczykowski-G=C3=B3recki > wrote: > > > > On Fri, Feb 15, 2019 at 08:18:31AM +0530, Souptick Joarder wrote: > > > Convert to use vm_map_pages() to map range of kernel > > > memory to user vma. > > > > > > map->count is passed to vm_map_pages() and internal API > > > verify map->count against count ( count =3D vma_pages(vma)) > > > for page array boundary overrun condition. > > > > This commit breaks gntdev driver. If vma->vm_pgoff > 0, vm_map_pages > > will: > > - use map->pages starting at vma->vm_pgoff instead of 0 > > The actual code ignores vma->vm_pgoff > 0 scenario and mapped > the entire map->pages[i]. Why the entire map->pages[i] needs to be mapped > if vma->vm_pgoff > 0 (in original code) ? > > are you referring to set vma->vm_pgoff =3D 0 irrespective of value passed > from user space ? If yes, using vm_map_pages_zero() is an alternate > option. > > > > - verify map->count against vma_pages()+vma->vm_pgoff instead of just > > vma_pages(). > > In original code -> > > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c > index 559d4b7f807d..469dfbd6cf90 100644 > --- a/drivers/xen/gntdev.c > +++ b/drivers/xen/gntdev.c > @@ -1084,7 +1084,7 @@ static int gntdev_mmap(struct file *flip, struct > vm_area_struct *vma) > int index =3D vma->vm_pgoff; > int count =3D vma_pages(vma); > > Count is user passed value. > > struct gntdev_grant_map *map; > - int i, err =3D -EINVAL; > + int err =3D -EINVAL; > if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED)) > return -EINVAL; > @@ -1145,12 +1145,9 @@ static int gntdev_mmap(struct file *flip, > struct vm_area_struct *vma) > goto out_put_map; > if (!use_ptemod) { > - for (i =3D 0; i < count; i++) { > - err =3D vm_insert_page(vma, vma->vm_start + i*PAGE_SIZE, > - map->pages[i]); > > and when count > i , we end up with trying to map memory outside > boundary of map->pages[i], which was not correct. typo. s/count > i / count > map->count > > - if (err) > - goto out_put_map; > - } > + err =3D vm_map_pages(vma, map->pages, map->count); > + if (err) > + goto out_put_map; > > With this commit, inside __vm_map_pages(), we have addressed this scenari= o. > > +static int __vm_map_pages(struct vm_area_struct *vma, struct page **page= s, > + unsigned long num, unsigned long offset) > +{ > + unsigned long count =3D vma_pages(vma); > + unsigned long uaddr =3D vma->vm_start; > + int ret, i; > + > + /* Fail if the user requested offset is beyond the end of the object */ > + if (offset > num) > + return -ENXIO; > + > + /* Fail if the user requested size exceeds available object size */ > + if (count > num - offset) > + return -ENXIO; > > By checking count > num -offset. (considering vma->vm_pgoff !=3D 0 as wel= l). > So we will never cross the boundary of map->pages[i]. > > > > > > In practice, this breaks using a single gntdev FD for mapping multiple > > grants. > > How ? > > > > > It looks like vm_map_pages() is not a good fit for this code and IMO it > > should be reverted. > > Did you hit any issue around this code in real time ? > > > > > > > Signed-off-by: Souptick Joarder > > > Reviewed-by: Boris Ostrovsky > > > --- > > > drivers/xen/gntdev.c | 11 ++++------- > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c > > > index 5efc5ee..5d64262 100644 > > > --- a/drivers/xen/gntdev.c > > > +++ b/drivers/xen/gntdev.c > > > @@ -1084,7 +1084,7 @@ static int gntdev_mmap(struct file *flip, struc= t vm_area_struct *vma) > > > int index =3D vma->vm_pgoff; > > > int count =3D vma_pages(vma); > > > struct gntdev_grant_map *map; > > > - int i, err =3D -EINVAL; > > > + int err =3D -EINVAL; > > > > > > if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED)) > > > return -EINVAL; > > > @@ -1145,12 +1145,9 @@ static int gntdev_mmap(struct file *flip, stru= ct vm_area_struct *vma) > > > goto out_put_map; > > > > > > if (!use_ptemod) { > > > - for (i =3D 0; i < count; i++) { > > > - err =3D vm_insert_page(vma, vma->vm_start + i*P= AGE_SIZE, > > > - map->pages[i]); > > > - if (err) > > > - goto out_put_map; > > > - } > > > + err =3D vm_map_pages(vma, map->pages, map->count); > > > + if (err) > > > + goto out_put_map; > > > } else { > > > #ifdef CONFIG_X86 > > > /* > > > > -- > > Best Regards, > > Marek Marczykowski-G=C3=B3recki > > Invisible Things Lab > > A: Because it messes up the order in which people normally read text. > > Q: Why is top-posting such a bad thing? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B39C7618B for ; Mon, 29 Jul 2019 08:33:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EC8BC206E0 for ; Mon, 29 Jul 2019 08:33:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yj2x/YP+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC8BC206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8EE698E0006; Mon, 29 Jul 2019 04:33:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89FC78E0002; Mon, 29 Jul 2019 04:33:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B63B8E0006; Mon, 29 Jul 2019 04:33:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by kanga.kvack.org (Postfix) with ESMTP id 160E08E0002 for ; Mon, 29 Jul 2019 04:33:08 -0400 (EDT) Received: by mail-lj1-f199.google.com with SMTP id m2so13177770ljj.0 for ; Mon, 29 Jul 2019 01:33:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=fzjgi5IYwtgWKCD94QQKl1WKdW6R14NVG7cIaq5hNd0=; b=jeVi6Ww37OMF6tqarBtA+YvrLrv1TXHinDQdRIP7I8APZIvSAstvVGoYAgxuN0YerS v9yQxKHEzQbLjYiO4TH/R+7WIVvAFoAoEoyUEUZw1V1wFKwFiWZVIysPqda0VO0XdmPc M9cr7tuBKhIIC2zRAPnfwJCmeL2/f/XfuU+V7ND1Z+gCpEyQVv4jfrVBik0WhM3RW9lK vNertnOVznzHM7U3ZnnOpb8AVLLJQvAuiI+hsLtgITIOUK4+h1Udj7cCw+2RTHF0B01s vFSYVJlWWvI5cgMmZEatPScOCEHVh1G7WVeiUGVVlzeGBr3j9WRhzNZ3tZDNN97+Ej9i 1s7A== X-Gm-Message-State: APjAAAXEquYJJbPrQwD22GaeTWPkBcdBqH3IBj+8V1Bj1F7Pp/1pt/fz BFcyLHckL+i185Kn7fxS9wFNHN3hSa2AiA5qQo9cK1ZK7Qa25JfytJP1Iiz3hOkriAHhDxszVvn vhJwPklsi2tlm5ZRIn/HE+wGyFjCh8EeA5ctcifaJsIP0T1fQIpnJ7IW9auojPf0rew== X-Received: by 2002:a2e:96d0:: with SMTP id d16mr43788506ljj.14.1564389187492; Mon, 29 Jul 2019 01:33:07 -0700 (PDT) X-Received: by 2002:a2e:96d0:: with SMTP id d16mr43788467ljj.14.1564389186659; Mon, 29 Jul 2019 01:33:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564389186; cv=none; d=google.com; s=arc-20160816; b=Ek64xVYwLvdCu44i4Qqt11v5sidNVc7YC/5Bq41y+PrJ3ggMWQvObbfHTuX1+dQ8qX Pzfkrg7SoUsTnqBxNevPGqWqO1CtqUfLWaH9EXu5mxVJDnSFbe23QeHXBh+awI4+JtxX ERgQtvaDaapMvS8C1yUYPpNJf3fHT9CzlxBdGAvgq6mGJuKIqkCq+R69PH2KIUVKj/xM 96q5IDTiHR27ePvVntJnkV7xN0BKR5dTusGOVocwzK6B1lm1DgaPtWO4xj4EKl7YPrbY ceP1ifhhPy11A1fXiizG/GybETVXIoiTd2Lnnqf5OM7Uu/fyMC7/gHzKZ9haDsEdZ9xJ BorQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=fzjgi5IYwtgWKCD94QQKl1WKdW6R14NVG7cIaq5hNd0=; b=IlYwU5gYE6L5XuLmuPZn+ycyAdLmHOdjxYBh74ACDr4vavikeaD4HZt0+hUhQPFBzM +550LNwgoYefEGxwYRMgXO6BpoS+vqjONCqhApuYo1TsY4nTzGz0K/GkHqde6uLrx7KH oQ6aygEnhohz05e3ZGWQxIFw3YwD/xML0GpEunu9nsfMchGZYGHJwwbHjQ076zMnkY1j B+DxVb/8ZSrT43wDalqefnWftqjuenBVLBMLDg/q5/jBwfo5POrn8aVphCSf8noFC7Ur LQ6Q0+Dbo15OyKveJIE1A6PlXSapvv7YwOoajf5bZY8N09CQsNLyqiciSzVSeTRL57+W +n5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Yj2x/YP+"; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id n5sor15358853lfi.73.2019.07.29.01.33.06 for (Google Transport Security); Mon, 29 Jul 2019 01:33:06 -0700 (PDT) Received-SPF: pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Yj2x/YP+"; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fzjgi5IYwtgWKCD94QQKl1WKdW6R14NVG7cIaq5hNd0=; b=Yj2x/YP+GQx3u0ETLl95DFn76V+nUeZ0HgcyvoUS0J23BQZRtMVjzIjCk80uAnKs7Q HQlRZ1Ixt54mk2Xl0CPAS4hhA/sUUWDDv5/rRB2v+KHQ4C83QqlXf3PwcGVgrK44gXGK T8QwJf/xyMFHhs2/N13YRy+O5ZrAaWHzCrT+9uVBY8T0e9XoY4vKw0aMc3l5RNtlaUye 2VNkfpFLe1kIUERcSgFAVPZYdYW3WF1u+Y7yXdwTmDoI1JjojonOcWFQNJEu9zZ2L+Ms iR7gq/NDAQVjh7NAv7l7QBoZvm7uLNemt8yUQrhf5sdM60rK76dfCnEyAtS40qTLkvPy d9ag== X-Google-Smtp-Source: APXvYqxOB3hlBmp/ELmfdAvewRmPGBGlLy908aDcnO5gzCSlHvcgEUZGOZj5/xu4Z+SD47jako1Nt3Hob11dDINtGdM= X-Received: by 2002:a19:5e10:: with SMTP id s16mr49683043lfb.13.1564389186319; Mon, 29 Jul 2019 01:33:06 -0700 (PDT) MIME-Version: 1.0 References: <20190215024830.GA26477@jordon-HP-15-Notebook-PC> <20190728180611.GA20589@mail-itl> In-Reply-To: From: Souptick Joarder Date: Mon, 29 Jul 2019 14:02:54 +0530 Message-ID: Subject: Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev.c: Convert to use vm_map_pages() To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Andrew Morton , Matthew Wilcox , Michal Hocko , Boris Ostrovsky , Juergen Gross , Russell King - ARM Linux , robin.murphy@arm.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 29, 2019 at 1:35 PM Souptick Joarder wro= te: > > On Sun, Jul 28, 2019 at 11:36 PM Marek Marczykowski-G=C3=B3recki > wrote: > > > > On Fri, Feb 15, 2019 at 08:18:31AM +0530, Souptick Joarder wrote: > > > Convert to use vm_map_pages() to map range of kernel > > > memory to user vma. > > > > > > map->count is passed to vm_map_pages() and internal API > > > verify map->count against count ( count =3D vma_pages(vma)) > > > for page array boundary overrun condition. > > > > This commit breaks gntdev driver. If vma->vm_pgoff > 0, vm_map_pages > > will: > > - use map->pages starting at vma->vm_pgoff instead of 0 > > The actual code ignores vma->vm_pgoff > 0 scenario and mapped > the entire map->pages[i]. Why the entire map->pages[i] needs to be mapped > if vma->vm_pgoff > 0 (in original code) ? > > are you referring to set vma->vm_pgoff =3D 0 irrespective of value passed > from user space ? If yes, using vm_map_pages_zero() is an alternate > option. > > > > - verify map->count against vma_pages()+vma->vm_pgoff instead of just > > vma_pages(). > > In original code -> > > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c > index 559d4b7f807d..469dfbd6cf90 100644 > --- a/drivers/xen/gntdev.c > +++ b/drivers/xen/gntdev.c > @@ -1084,7 +1084,7 @@ static int gntdev_mmap(struct file *flip, struct > vm_area_struct *vma) > int index =3D vma->vm_pgoff; > int count =3D vma_pages(vma); > > Count is user passed value. > > struct gntdev_grant_map *map; > - int i, err =3D -EINVAL; > + int err =3D -EINVAL; > if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED)) > return -EINVAL; > @@ -1145,12 +1145,9 @@ static int gntdev_mmap(struct file *flip, > struct vm_area_struct *vma) > goto out_put_map; > if (!use_ptemod) { > - for (i =3D 0; i < count; i++) { > - err =3D vm_insert_page(vma, vma->vm_start + i*PAGE_SIZE, > - map->pages[i]); > > and when count > i , we end up with trying to map memory outside > boundary of map->pages[i], which was not correct. typo. s/count > i / count > map->count > > - if (err) > - goto out_put_map; > - } > + err =3D vm_map_pages(vma, map->pages, map->count); > + if (err) > + goto out_put_map; > > With this commit, inside __vm_map_pages(), we have addressed this scenari= o. > > +static int __vm_map_pages(struct vm_area_struct *vma, struct page **page= s, > + unsigned long num, unsigned long offset) > +{ > + unsigned long count =3D vma_pages(vma); > + unsigned long uaddr =3D vma->vm_start; > + int ret, i; > + > + /* Fail if the user requested offset is beyond the end of the object */ > + if (offset > num) > + return -ENXIO; > + > + /* Fail if the user requested size exceeds available object size */ > + if (count > num - offset) > + return -ENXIO; > > By checking count > num -offset. (considering vma->vm_pgoff !=3D 0 as wel= l). > So we will never cross the boundary of map->pages[i]. > > > > > > In practice, this breaks using a single gntdev FD for mapping multiple > > grants. > > How ? > > > > > It looks like vm_map_pages() is not a good fit for this code and IMO it > > should be reverted. > > Did you hit any issue around this code in real time ? > > > > > > > Signed-off-by: Souptick Joarder > > > Reviewed-by: Boris Ostrovsky > > > --- > > > drivers/xen/gntdev.c | 11 ++++------- > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c > > > index 5efc5ee..5d64262 100644 > > > --- a/drivers/xen/gntdev.c > > > +++ b/drivers/xen/gntdev.c > > > @@ -1084,7 +1084,7 @@ static int gntdev_mmap(struct file *flip, struc= t vm_area_struct *vma) > > > int index =3D vma->vm_pgoff; > > > int count =3D vma_pages(vma); > > > struct gntdev_grant_map *map; > > > - int i, err =3D -EINVAL; > > > + int err =3D -EINVAL; > > > > > > if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED)) > > > return -EINVAL; > > > @@ -1145,12 +1145,9 @@ static int gntdev_mmap(struct file *flip, stru= ct vm_area_struct *vma) > > > goto out_put_map; > > > > > > if (!use_ptemod) { > > > - for (i =3D 0; i < count; i++) { > > > - err =3D vm_insert_page(vma, vma->vm_start + i*P= AGE_SIZE, > > > - map->pages[i]); > > > - if (err) > > > - goto out_put_map; > > > - } > > > + err =3D vm_map_pages(vma, map->pages, map->count); > > > + if (err) > > > + goto out_put_map; > > > } else { > > > #ifdef CONFIG_X86 > > > /* > > > > -- > > Best Regards, > > Marek Marczykowski-G=C3=B3recki > > Invisible Things Lab > > A: Because it messes up the order in which people normally read text. > > Q: Why is top-posting such a bad thing? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC7AC433FF for ; Mon, 29 Jul 2019 08:33:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CEB4206E0 for ; Mon, 29 Jul 2019 08:33:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yj2x/YP+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CEB4206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hs15j-0005Z4-Kb; Mon, 29 Jul 2019 08:33:11 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hs15h-0005Yz-TX for xen-devel@lists.xenproject.org; Mon, 29 Jul 2019 08:33:09 +0000 X-Inumbo-ID: 7d3a73dd-b1db-11e9-8980-bc764e045a96 Received: from mail-lf1-x141.google.com (unknown [2a00:1450:4864:20::141]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 7d3a73dd-b1db-11e9-8980-bc764e045a96; Mon, 29 Jul 2019 08:33:07 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id c9so41394024lfh.4 for ; Mon, 29 Jul 2019 01:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fzjgi5IYwtgWKCD94QQKl1WKdW6R14NVG7cIaq5hNd0=; b=Yj2x/YP+GQx3u0ETLl95DFn76V+nUeZ0HgcyvoUS0J23BQZRtMVjzIjCk80uAnKs7Q HQlRZ1Ixt54mk2Xl0CPAS4hhA/sUUWDDv5/rRB2v+KHQ4C83QqlXf3PwcGVgrK44gXGK T8QwJf/xyMFHhs2/N13YRy+O5ZrAaWHzCrT+9uVBY8T0e9XoY4vKw0aMc3l5RNtlaUye 2VNkfpFLe1kIUERcSgFAVPZYdYW3WF1u+Y7yXdwTmDoI1JjojonOcWFQNJEu9zZ2L+Ms iR7gq/NDAQVjh7NAv7l7QBoZvm7uLNemt8yUQrhf5sdM60rK76dfCnEyAtS40qTLkvPy d9ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fzjgi5IYwtgWKCD94QQKl1WKdW6R14NVG7cIaq5hNd0=; b=ZyO+ZCCsYS5GlZTzYfOpqyjvOKWWOYG47Vuf/CpPFFU+1vX+92LwsNImK81sWCIqkL ZDmJ4Sl+hWmEDPBKv+tTteqipNwBjUmQrA+to3fvd6rJrFxOaa6RvJaBc/M5ddv3m4HL gSobzX327dQmJIPl2/HSSKTD5IIZVTyvDx1yGf/Fh+XAm23sWBl5V/38P8gGydWFPlp4 i01bCvUYj+HYUMkO3Z2WVa8NI3LtUnPPi3U+z9AKq7HGsNFHcHQY9LuLql2Jw8hQLsLV ZxgPcf1SWgz6UstFRYmOGccPcfEW9sI+fRaQVNDPMYWNO2Z+BmYDTx+gP8bnRr37t3Zf Amug== X-Gm-Message-State: APjAAAWh+eocGt2tgKwxktvirWmIeW2kgwHlqgXHjUmueEymfR/6h6PE 0eAuW/qMzp0AHQMq45RkT76ovxRvcizMdKWuUH8= X-Google-Smtp-Source: APXvYqxOB3hlBmp/ELmfdAvewRmPGBGlLy908aDcnO5gzCSlHvcgEUZGOZj5/xu4Z+SD47jako1Nt3Hob11dDINtGdM= X-Received: by 2002:a19:5e10:: with SMTP id s16mr49683043lfb.13.1564389186319; Mon, 29 Jul 2019 01:33:06 -0700 (PDT) MIME-Version: 1.0 References: <20190215024830.GA26477@jordon-HP-15-Notebook-PC> <20190728180611.GA20589@mail-itl> In-Reply-To: From: Souptick Joarder Date: Mon, 29 Jul 2019 14:02:54 +0530 Message-ID: To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Subject: Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev.c: Convert to use vm_map_pages() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Michal Hocko , Russell King - ARM Linux , Matthew Wilcox , linux-kernel@vger.kernel.org, Linux-MM , xen-devel@lists.xenproject.org, Andrew Morton , robin.murphy@arm.com, Boris Ostrovsky Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gTW9uLCBKdWwgMjksIDIwMTkgYXQgMTozNSBQTSBTb3VwdGljayBKb2FyZGVyIDxqcmRyLmxp bnV4QGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBPbiBTdW4sIEp1bCAyOCwgMjAxOSBhdCAxMTozNiBQ TSBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kKPiA8bWFybWFyZWtAaW52aXNpYmxldGhpbmdz bGFiLmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gRnJpLCBGZWIgMTUsIDIwMTkgYXQgMDg6MTg6MzFB TSArMDUzMCwgU291cHRpY2sgSm9hcmRlciB3cm90ZToKPiA+ID4gQ29udmVydCB0byB1c2Ugdm1f bWFwX3BhZ2VzKCkgdG8gbWFwIHJhbmdlIG9mIGtlcm5lbAo+ID4gPiBtZW1vcnkgdG8gdXNlciB2 bWEuCj4gPiA+Cj4gPiA+IG1hcC0+Y291bnQgaXMgcGFzc2VkIHRvIHZtX21hcF9wYWdlcygpIGFu ZCBpbnRlcm5hbCBBUEkKPiA+ID4gdmVyaWZ5IG1hcC0+Y291bnQgYWdhaW5zdCBjb3VudCAoIGNv dW50ID0gdm1hX3BhZ2VzKHZtYSkpCj4gPiA+IGZvciBwYWdlIGFycmF5IGJvdW5kYXJ5IG92ZXJy dW4gY29uZGl0aW9uLgo+ID4KPiA+IFRoaXMgY29tbWl0IGJyZWFrcyBnbnRkZXYgZHJpdmVyLiBJ ZiB2bWEtPnZtX3Bnb2ZmID4gMCwgdm1fbWFwX3BhZ2VzCj4gPiB3aWxsOgo+ID4gIC0gdXNlIG1h cC0+cGFnZXMgc3RhcnRpbmcgYXQgdm1hLT52bV9wZ29mZiBpbnN0ZWFkIG9mIDAKPgo+IFRoZSBh Y3R1YWwgY29kZSBpZ25vcmVzIHZtYS0+dm1fcGdvZmYgPiAwIHNjZW5hcmlvIGFuZCBtYXBwZWQK PiB0aGUgZW50aXJlIG1hcC0+cGFnZXNbaV0uIFdoeSB0aGUgZW50aXJlIG1hcC0+cGFnZXNbaV0g bmVlZHMgdG8gYmUgbWFwcGVkCj4gaWYgdm1hLT52bV9wZ29mZiA+IDAgKGluIG9yaWdpbmFsIGNv ZGUpID8KPgo+IGFyZSB5b3UgcmVmZXJyaW5nIHRvIHNldCB2bWEtPnZtX3Bnb2ZmID0gMCBpcnJl c3BlY3RpdmUgb2YgdmFsdWUgcGFzc2VkCj4gZnJvbSB1c2VyIHNwYWNlID8gSWYgeWVzLCB1c2lu ZyB2bV9tYXBfcGFnZXNfemVybygpIGlzIGFuIGFsdGVybmF0ZQo+IG9wdGlvbi4KPgo+Cj4gPiAg LSB2ZXJpZnkgbWFwLT5jb3VudCBhZ2FpbnN0IHZtYV9wYWdlcygpK3ZtYS0+dm1fcGdvZmYgaW5z dGVhZCBvZiBqdXN0Cj4gPiAgICB2bWFfcGFnZXMoKS4KPgo+IEluIG9yaWdpbmFsIGNvZGUgLT4K Pgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9nbnRkZXYuYyBiL2RyaXZlcnMveGVuL2dudGRl di5jCj4gaW5kZXggNTU5ZDRiN2Y4MDdkLi40NjlkZmJkNmNmOTAgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy94ZW4vZ250ZGV2LmMKPiArKysgYi9kcml2ZXJzL3hlbi9nbnRkZXYuYwo+IEBAIC0xMDg0 LDcgKzEwODQsNyBAQCBzdGF0aWMgaW50IGdudGRldl9tbWFwKHN0cnVjdCBmaWxlICpmbGlwLCBz dHJ1Y3QKPiB2bV9hcmVhX3N0cnVjdCAqdm1hKQo+IGludCBpbmRleCA9IHZtYS0+dm1fcGdvZmY7 Cj4gaW50IGNvdW50ID0gdm1hX3BhZ2VzKHZtYSk7Cj4KPiBDb3VudCBpcyB1c2VyIHBhc3NlZCB2 YWx1ZS4KPgo+IHN0cnVjdCBnbnRkZXZfZ3JhbnRfbWFwICptYXA7Cj4gLSBpbnQgaSwgZXJyID0g LUVJTlZBTDsKPiArIGludCBlcnIgPSAtRUlOVkFMOwo+IGlmICgodm1hLT52bV9mbGFncyAmIFZN X1dSSVRFKSAmJiAhKHZtYS0+dm1fZmxhZ3MgJiBWTV9TSEFSRUQpKQo+IHJldHVybiAtRUlOVkFM Owo+IEBAIC0xMTQ1LDEyICsxMTQ1LDkgQEAgc3RhdGljIGludCBnbnRkZXZfbW1hcChzdHJ1Y3Qg ZmlsZSAqZmxpcCwKPiBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiBnb3RvIG91dF9wdXRf bWFwOwo+IGlmICghdXNlX3B0ZW1vZCkgewo+IC0gZm9yIChpID0gMDsgaSA8IGNvdW50OyBpKysp IHsKPiAtIGVyciA9IHZtX2luc2VydF9wYWdlKHZtYSwgdm1hLT52bV9zdGFydCArIGkqUEFHRV9T SVpFLAo+IC0gbWFwLT5wYWdlc1tpXSk7Cj4KPiBhbmQgd2hlbiBjb3VudCA+IGkgLCB3ZSBlbmQg dXAgd2l0aCB0cnlpbmcgdG8gbWFwIG1lbW9yeSBvdXRzaWRlCj4gYm91bmRhcnkgb2YgbWFwLT5w YWdlc1tpXSwgd2hpY2ggd2FzIG5vdCBjb3JyZWN0LgoKdHlwby4Kcy9jb3VudCA+IGkgLyBjb3Vu dCA+IG1hcC0+Y291bnQKPgo+IC0gaWYgKGVycikKPiAtIGdvdG8gb3V0X3B1dF9tYXA7Cj4gLSB9 Cj4gKyBlcnIgPSB2bV9tYXBfcGFnZXModm1hLCBtYXAtPnBhZ2VzLCBtYXAtPmNvdW50KTsKPiAr IGlmIChlcnIpCj4gKyBnb3RvIG91dF9wdXRfbWFwOwo+Cj4gV2l0aCB0aGlzIGNvbW1pdCwgaW5z aWRlIF9fdm1fbWFwX3BhZ2VzKCksIHdlIGhhdmUgYWRkcmVzc2VkIHRoaXMgc2NlbmFyaW8uCj4K PiArc3RhdGljIGludCBfX3ZtX21hcF9wYWdlcyhzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwg c3RydWN0IHBhZ2UgKipwYWdlcywKPiArIHVuc2lnbmVkIGxvbmcgbnVtLCB1bnNpZ25lZCBsb25n IG9mZnNldCkKPiArewo+ICsgdW5zaWduZWQgbG9uZyBjb3VudCA9IHZtYV9wYWdlcyh2bWEpOwo+ ICsgdW5zaWduZWQgbG9uZyB1YWRkciA9IHZtYS0+dm1fc3RhcnQ7Cj4gKyBpbnQgcmV0LCBpOwo+ ICsKPiArIC8qIEZhaWwgaWYgdGhlIHVzZXIgcmVxdWVzdGVkIG9mZnNldCBpcyBiZXlvbmQgdGhl IGVuZCBvZiB0aGUgb2JqZWN0ICovCj4gKyBpZiAob2Zmc2V0ID4gbnVtKQo+ICsgcmV0dXJuIC1F TlhJTzsKPiArCj4gKyAvKiBGYWlsIGlmIHRoZSB1c2VyIHJlcXVlc3RlZCBzaXplIGV4Y2VlZHMg YXZhaWxhYmxlIG9iamVjdCBzaXplICovCj4gKyBpZiAoY291bnQgPiBudW0gLSBvZmZzZXQpCj4g KyByZXR1cm4gLUVOWElPOwo+Cj4gQnkgY2hlY2tpbmcgY291bnQgPiBudW0gLW9mZnNldC4gKGNv bnNpZGVyaW5nIHZtYS0+dm1fcGdvZmYgIT0gMCBhcyB3ZWxsKS4KPiBTbyB3ZSB3aWxsIG5ldmVy IGNyb3NzIHRoZSBib3VuZGFyeSBvZiBtYXAtPnBhZ2VzW2ldLgo+Cj4KPiA+Cj4gPiBJbiBwcmFj dGljZSwgdGhpcyBicmVha3MgdXNpbmcgYSBzaW5nbGUgZ250ZGV2IEZEIGZvciBtYXBwaW5nIG11 bHRpcGxlCj4gPiBncmFudHMuCj4KPiBIb3cgPwo+Cj4gPgo+ID4gSXQgbG9va3MgbGlrZSB2bV9t YXBfcGFnZXMoKSBpcyBub3QgYSBnb29kIGZpdCBmb3IgdGhpcyBjb2RlIGFuZCBJTU8gaXQKPiA+ IHNob3VsZCBiZSByZXZlcnRlZC4KPgo+IERpZCB5b3UgaGl0IGFueSBpc3N1ZSBhcm91bmQgdGhp cyBjb2RlIGluIHJlYWwgdGltZSA/Cj4KPgo+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogU291cHRp Y2sgSm9hcmRlciA8anJkci5saW51eEBnbWFpbC5jb20+Cj4gPiA+IFJldmlld2VkLWJ5OiBCb3Jp cyBPc3Ryb3Zza3kgPGJvcmlzLm9zdHJvdnNreUBvcmFjbGUuY29tPgo+ID4gPiAtLS0KPiA+ID4g IGRyaXZlcnMveGVuL2dudGRldi5jIHwgMTEgKysrKy0tLS0tLS0KPiA+ID4gIDEgZmlsZSBjaGFu Z2VkLCA0IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gPiA+Cj4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL3hlbi9nbnRkZXYuYyBiL2RyaXZlcnMveGVuL2dudGRldi5jCj4gPiA+IGlu ZGV4IDVlZmM1ZWUuLjVkNjQyNjIgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMveGVuL2dudGRl di5jCj4gPiA+ICsrKyBiL2RyaXZlcnMveGVuL2dudGRldi5jCj4gPiA+IEBAIC0xMDg0LDcgKzEw ODQsNyBAQCBzdGF0aWMgaW50IGdudGRldl9tbWFwKHN0cnVjdCBmaWxlICpmbGlwLCBzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiA+ID4gICAgICAgaW50IGluZGV4ID0gdm1hLT52bV9wZ29m ZjsKPiA+ID4gICAgICAgaW50IGNvdW50ID0gdm1hX3BhZ2VzKHZtYSk7Cj4gPiA+ICAgICAgIHN0 cnVjdCBnbnRkZXZfZ3JhbnRfbWFwICptYXA7Cj4gPiA+IC0gICAgIGludCBpLCBlcnIgPSAtRUlO VkFMOwo+ID4gPiArICAgICBpbnQgZXJyID0gLUVJTlZBTDsKPiA+ID4KPiA+ID4gICAgICAgaWYg KCh2bWEtPnZtX2ZsYWdzICYgVk1fV1JJVEUpICYmICEodm1hLT52bV9mbGFncyAmIFZNX1NIQVJF RCkpCj4gPiA+ICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gPiA+IEBAIC0xMTQ1LDEy ICsxMTQ1LDkgQEAgc3RhdGljIGludCBnbnRkZXZfbW1hcChzdHJ1Y3QgZmlsZSAqZmxpcCwgc3Ry dWN0IHZtX2FyZWFfc3RydWN0ICp2bWEpCj4gPiA+ICAgICAgICAgICAgICAgZ290byBvdXRfcHV0 X21hcDsKPiA+ID4KPiA+ID4gICAgICAgaWYgKCF1c2VfcHRlbW9kKSB7Cj4gPiA+IC0gICAgICAg ICAgICAgZm9yIChpID0gMDsgaSA8IGNvdW50OyBpKyspIHsKPiA+ID4gLSAgICAgICAgICAgICAg ICAgICAgIGVyciA9IHZtX2luc2VydF9wYWdlKHZtYSwgdm1hLT52bV9zdGFydCArIGkqUEFHRV9T SVpFLAo+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtYXAtPnBhZ2VzW2ldKTsK PiA+ID4gLSAgICAgICAgICAgICAgICAgICAgIGlmIChlcnIpCj4gPiA+IC0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGdvdG8gb3V0X3B1dF9tYXA7Cj4gPiA+IC0gICAgICAgICAgICAgfQo+ ID4gPiArICAgICAgICAgICAgIGVyciA9IHZtX21hcF9wYWdlcyh2bWEsIG1hcC0+cGFnZXMsIG1h cC0+Y291bnQpOwo+ID4gPiArICAgICAgICAgICAgIGlmIChlcnIpCj4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICBnb3RvIG91dF9wdXRfbWFwOwo+ID4gPiAgICAgICB9IGVsc2Ugewo+ID4gPiAg I2lmZGVmIENPTkZJR19YODYKPiA+ID4gICAgICAgICAgICAgICAvKgo+ID4KPiA+IC0tCj4gPiBC ZXN0IFJlZ2FyZHMsCj4gPiBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kKPiA+IEludmlzaWJs ZSBUaGluZ3MgTGFiCj4gPiBBOiBCZWNhdXNlIGl0IG1lc3NlcyB1cCB0aGUgb3JkZXIgaW4gd2hp Y2ggcGVvcGxlIG5vcm1hbGx5IHJlYWQgdGV4dC4KPiA+IFE6IFdoeSBpcyB0b3AtcG9zdGluZyBz dWNoIGEgYmFkIHRoaW5nPwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1k ZXZlbA==