From: Souptick Joarder <jrdr.linux@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: mawilcox@microsoft.com, airlied@linux.ie,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
briannorris@chromium.org, dri-devel@lists.freedesktop.org,
"Cihangir Aktürk" <cakturk@gmail.com>,
dan.carpenter@oracle.com
Subject: Re: [PATCH] drm/vgem: Replace drm_dev_unref with drm_dev_put
Date: Mon, 16 Jul 2018 14:37:58 +0530 [thread overview]
Message-ID: <CAFqt6zY-YX_f4i8yhX85xkgZVC65KSVQkxLLdK-rUpKhcOL4_Q@mail.gmail.com> (raw)
In-Reply-To: <20180716074624.7931-1-tzimmermann@suse.de>
On Mon, Jul 16, 2018 at 1:16 PM, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> This patch unifies the naming of DRM functions for reference counting
> of struct drm_device. The resulting code is more aligned with the rest
> of the Linux kernel interfaces.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index 0e5620f76ee0..ec6af8b920da 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -504,7 +504,7 @@ static int __init vgem_init(void)
> static void __exit vgem_exit(void)
> {
> drm_dev_unregister(&vgem_device->drm);
> - drm_dev_unref(&vgem_device->drm);
> + drm_dev_put(&vgem_device->drm);
> }
>
> module_init(vgem_init);
> --
> 2.18.0
>
There are other gpu/drm drivers where drm_dev_unref is used.
Do we need to replace drm_dev_unref with drm_dev_put in
other places as well ?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-16 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 7:46 [PATCH] drm/vgem: Replace drm_dev_unref with drm_dev_put Thomas Zimmermann
2018-07-16 9:07 ` Souptick Joarder [this message]
2018-07-16 9:12 ` Thomas Zimmermann
2018-08-09 12:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFqt6zY-YX_f4i8yhX85xkgZVC65KSVQkxLLdK-rUpKhcOL4_Q@mail.gmail.com \
--to=jrdr.linux@gmail.com \
--cc=airlied@linux.ie \
--cc=briannorris@chromium.org \
--cc=cakturk@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=mawilcox@microsoft.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.