From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41D3CC43461 for ; Sun, 13 Sep 2020 13:01:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBBF62158C for ; Sun, 13 Sep 2020 13:01:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U6zE07o7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725944AbgIMNBh (ORCPT ); Sun, 13 Sep 2020 09:01:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbgIMNB3 (ORCPT ); Sun, 13 Sep 2020 09:01:29 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C0CC061573; Sun, 13 Sep 2020 06:01:28 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id b19so16223358lji.11; Sun, 13 Sep 2020 06:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pPCmjlTrAmfqJleeRYsacvC5WOPQ/sV/9CQBQ+8u+kU=; b=U6zE07o780EAOLjlGW1oq7Cy8bRqvryTPnit0wgmyG3Yv+v6Ui5vGcIN9cqNo2tUa1 SY3RtJFeefEVvZmhhdzeSvDeD/QMSNGgHh7fiLc9IT2wgBTi3N6c4gxqKHVAtaoz1hNH xcNQuYc56ibDCJqP3r8Z4hNsPrIeriDyrMdcoAtjCQiSBzBpGijJLzLvmgj5haHnYwj6 HyRZTUnfWvYR6KqM2BMGATdGK5UBDb8xChfBT7PhITekQzlnV4wSuFjJzXUmsBt+jh6a OmW5XaT8vp8v0nlf/qEBLN3xCr4wNqx/JusRkwvihD4Ir9aqEmZaFYFXv3WHiMgA4gDi /kCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pPCmjlTrAmfqJleeRYsacvC5WOPQ/sV/9CQBQ+8u+kU=; b=e4Ur6HdYglFX+A41TNA/SyvzgSC3S+etE0P/MafLtfSefYnSCyf9VfRY9YL3VCRxJF 3vXp6jZfS7AknTYTBQoqgw1QWZoOw/OPVxURS7XJSMhiu/hjQCsM3OT5W47qh0vTdOrY c2AQauXinbClP5yYDV93qDmlULuU5U8CjjEv9scmzV5E6tsBuykBNlXgAVQYx88+PuSO gQDve+sn8OdLkmD4XTnDj+A1kfOwb8zdb/nhX6WkiC7VqC1cTe57EmwXVlVPeqN5Udng t+zD9VePT6hw9AqiwZmipeWRl3nHEMkhbiIZzkMLXDE4hzs5/aFdgpo5AQigfF/h0XXA UV8w== X-Gm-Message-State: AOAM5309ty1zPKAspZLIZ/LxluLq1B5ECJdVdXEUoUdta4NksL7xuV6u U4qlQURGf3SfqvQsoG+/tQI52TIc5j3K5eKQ847TiMBBPwU= X-Google-Smtp-Source: ABdhPJxtcS0zuYBGhcNSeg7Jb61875RnS1WA/gwxBi7KM7yl6LgvZYjjU8Var5PK4WqMhIXxjYOCRceevRMvKGtNGGM= X-Received: by 2002:a2e:a16c:: with SMTP id u12mr3468462ljl.266.1600002081028; Sun, 13 Sep 2020 06:01:21 -0700 (PDT) MIME-Version: 1.0 References: <641dfe3b-1de8-97ea-eac7-89d81846eab3@web.de> In-Reply-To: <641dfe3b-1de8-97ea-eac7-89d81846eab3@web.de> From: Souptick Joarder Date: Sun, 13 Sep 2020 18:31:08 +0530 Message-ID: Subject: Re: [PATCH] tee/tee_shm.c: Fix error handling path To: Markus Elfring Cc: op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Jens Wiklander , John Hubbard Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2020 at 2:00 PM Markus Elfring wrot= e: > > > When shm->num_pages <=3D 0, we should avoid calling > > release_registered_pages() in error handling path. > > * Would an imperative wording become helpful for the change description? > > * I suggest to add the tag =E2=80=9CFixes=E2=80=9D to the commit message. Sure. Will address both in v2. > > Regards, > Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Souptick Joarder Date: Sun, 13 Sep 2020 13:13:08 +0000 Subject: Re: [PATCH] tee/tee_shm.c: Fix error handling path Message-Id: List-Id: References: <641dfe3b-1de8-97ea-eac7-89d81846eab3@web.de> In-Reply-To: <641dfe3b-1de8-97ea-eac7-89d81846eab3@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Markus Elfring Cc: op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Jens Wiklander , John Hubbard On Sun, Sep 13, 2020 at 2:00 PM Markus Elfring wrote: > > > When shm->num_pages <= 0, we should avoid calling > > release_registered_pages() in error handling path. > > * Would an imperative wording become helpful for the change description? > > * I suggest to add the tag “Fixes” to the commit message. Sure. Will address both in v2. > > Regards, > Markus