From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CDFC07E96 for ; Tue, 6 Jul 2021 16:01:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C7A661A13 for ; Tue, 6 Jul 2021 16:01:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C7A661A13 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B54916B0036; Tue, 6 Jul 2021 12:01:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B04D06B005D; Tue, 6 Jul 2021 12:01:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A55E6B006C; Tue, 6 Jul 2021 12:01:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 762386B0036 for ; Tue, 6 Jul 2021 12:01:21 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CF90C1DAE7 for ; Tue, 6 Jul 2021 16:01:20 +0000 (UTC) X-FDA: 78332627520.38.B2FD5AF Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) by imf06.hostedemail.com (Postfix) with ESMTP id 527678029B40 for ; Tue, 6 Jul 2021 16:01:20 +0000 (UTC) Received: by mail-vk1-f177.google.com with SMTP id d7so4568502vkf.2 for ; Tue, 06 Jul 2021 09:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5dM0WZhxnvC+OTbayWwHIw8dE+y1dt6pru/6HbGv3Do=; b=Ns/TFArKFaoiJxVk9fHFola2MFFv/jqVRZE6uYUu9wmohso8s65hbyD6JL7m9uqKLK El3nn6TE4REIs2XnOS/8RJCkH7LVAky26IHDN+6nsd7CqATjkKzTdcg/pSZzlKxYk8ad I2hrNAkTuKuwWgS/ec+M2SqL78rDsrsZjjEDGxIwWHsTOGTePSgSpGnLl9B9Qg3EQtgF bXNP+ykOnJAvRAxXOBOFkc6h0+H9bhlaB+w9ncNN0wRWjxMzTDKEzZQz1sfmMVJuvhOK eOJtUuZRqUbmflxV7lAFZkfX8HWZKYk5X245G1WRhhMbNUguKCuykvLwerYVUAM1SCKw eJ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5dM0WZhxnvC+OTbayWwHIw8dE+y1dt6pru/6HbGv3Do=; b=Ne1GyA+2AUbxr6sq0S2JyRfkJWFQo5/Raq3Shw6qragT8EEeopqFCnggKa9LYbrmjL wTSeP+MFFQCqYB7qEHkBo6ZPRyCFx65sJhidJz5xH6ak97of93NTlu/9M677+lC3WYhZ cTAZMyk/zYN8NcZIEliCBoQfMOOfhQjHosuQC4Q0pJjskvCLL3UzjnhCEHUrdpTuXltu +4y12ROPlfQ8V2WpjTi+ruT0iprA+DkjWMHAxdq6Dz6wBDa24fV/wjktgecwVY/zYIOX Fw2+2Tn4H780KDVCM2gR4XLx4MxseAFLCkkInaL3aTs2WGM0Hd/VP43YXuHx79fqq1pF 9+oQ== X-Gm-Message-State: AOAM532C+gAhvZdyJYFZpsR8ncMFw2Mun4zlqiIwNXqjsKVX8LoshjFy CP3mDECbzq0qpw+/fd9pp2+4tryVqY34A9QIn9Q= X-Google-Smtp-Source: ABdhPJwQ1lZOGZmGqeWd7Y3ijjuwB1LPU1BDoaNJEE8eTtAX8JxNDwharFT8O8/7Onv4YCqe5svhUd9hBQE6fBSU0+M= X-Received: by 2002:a1f:da86:: with SMTP id r128mr14379438vkg.6.1625587241296; Tue, 06 Jul 2021 09:00:41 -0700 (PDT) MIME-Version: 1.0 References: <20210706025603.4059-1-apopple@nvidia.com> In-Reply-To: <20210706025603.4059-1-apopple@nvidia.com> From: Souptick Joarder Date: Tue, 6 Jul 2021 21:30:29 +0530 Message-ID: Subject: Re: [PATCH] lib/test_hmm: Remove set but unused page variable To: Alistair Popple Cc: Andrew Morton , Linux-MM , Ralph Campbell , Hulk Robot , kernel test robot , Yang Yingliang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="Ns/TFArK"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of jrdrlinux@gmail.com designates 209.85.221.177 as permitted sender) smtp.mailfrom=jrdrlinux@gmail.com X-Stat-Signature: ihure57bb4ubduxjat7jzusx1sqaiazq X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 527678029B40 X-HE-Tag: 1625587280-873414 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 6, 2021 at 8:26 AM Alistair Popple wrote: > > The HMM selftests use atomic_check_access() to check atomic access to a > page has been revoked. It doesn't matter if the page mapping has been > removed from the mirrored page tables as that also implies atomic access > has been revoked. Therefore remove the unused page variable to fix this > compiler warning: > > lib/test_hmm.c:631:16: warning: variable =E2=80=98page=E2=80=99 set but= not used [-Wunused-but-set-variable] > > Fixes: b659baea7546 ("mm: selftests for exclusive device memory") > Reported-by: Hulk Robot > Reported-by: kernel test robot > Reported-by: Yang Yingliang > Signed-off-by: Alistair Popple Acked-by: Souptick Joarder > --- > lib/test_hmm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/test_hmm.c b/lib/test_hmm.c > index 8c55c4723692..c259842f6d44 100644 > --- a/lib/test_hmm.c > +++ b/lib/test_hmm.c > @@ -628,10 +628,8 @@ static int dmirror_check_atomic(struct dmirror *dmir= ror, unsigned long start, > > for (pfn =3D start >> PAGE_SHIFT; pfn < (end >> PAGE_SHIFT); pfn+= +) { > void *entry; > - struct page *page; > > entry =3D xa_load(&dmirror->pt, pfn); > - page =3D xa_untag_pointer(entry); > if (xa_pointer_tag(entry) =3D=3D DPT_XA_TAG_ATOMIC) > return -EPERM; > } > -- > 2.20.1 > >