All of lore.kernel.org
 help / color / mirror / Atom feed
From: Souptick Joarder <jrdr.linux@gmail.com>
To: mcree@orcon.net.nz, Brajeswar Ghosh <brajeswar.linux@gmail.com>,
	rth@twiddle.net, ink@jurassic.park.msu.ru,
	Matt Turner <mattst88@gmail.com>,
	parri.andrea@gmail.com, mingo@kernel.org,
	paulmck@linux.vnet.ibm.com, linux-alpha@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Subject: Re: [PATCH] include/asm/cmpxchg.h: Remove duplicate header
Date: Sat, 3 Nov 2018 00:28:41 +0530	[thread overview]
Message-ID: <CAFqt6zYmBFQ7gDJJkYAhPzPYyLGsDqOdr8ctXmYbd7e9sv75xg@mail.gmail.com> (raw)
In-Reply-To: <20181102182905.3klrdw4dxapeoiib@tower>

Hi Michael,

On Fri, Nov 2, 2018 at 11:59 PM Michael Cree <mcree@orcon.net.nz> wrote:
>
> On Fri, Nov 02, 2018 at 08:56:37PM +0530, Brajeswar Ghosh wrote:
> > Remove asm/xchg.h which is included more than once
> >
> > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> > ---
> >  arch/alpha/include/asm/cmpxchg.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/alpha/include/asm/cmpxchg.h b/arch/alpha/include/asm/cmpxchg.h
> > index 6c7c39452471..bcbdac0744f9 100644
> > --- a/arch/alpha/include/asm/cmpxchg.h
> > +++ b/arch/alpha/include/asm/cmpxchg.h
> > @@ -36,7 +36,6 @@
> >  #undef ____cmpxchg
> >  #define ____xchg(type, args...)              __xchg ##type(args)
> >  #define ____cmpxchg(type, args...)   __cmpxchg ##type(args)
> > -#include <asm/xchg.h>
>
> It's amazing the number of times we get a patch to remove that.
>
> Instead of just automatically removing a second include of a
> header file, why don't you take a closer look to see what it
> actually does?

We run the static analyser "make includecheck" which list out files where
duplicate headers can be removed and based on that we thought to remove
from this file. Didn't understood about the existence of second include ??

  reply	other threads:[~2018-11-02 18:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02 15:26 [PATCH] include/asm/cmpxchg.h: Remove duplicate header Brajeswar Ghosh
2018-11-02 18:29 ` Michael Cree
2018-11-02 18:58   ` Souptick Joarder [this message]
2018-11-02 19:01     ` Matt Turner
2018-11-02 19:13       ` Souptick Joarder
2018-11-02 19:14         ` Matt Turner
2018-11-03  1:44 ` kbuild test robot
2018-11-03  1:51 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFqt6zYmBFQ7gDJJkYAhPzPYyLGsDqOdr8ctXmYbd7e9sv75xg@mail.gmail.com \
    --to=jrdr.linux@gmail.com \
    --cc=brajeswar.linux@gmail.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mcree@orcon.net.nz \
    --cc=mingo@kernel.org \
    --cc=parri.andrea@gmail.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rth@twiddle.net \
    --cc=sabyasachi.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.