From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00350C32750 for ; Tue, 30 Jul 2019 14:52:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA42220665 for ; Tue, 30 Jul 2019 14:52:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iuQpUu6a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728364AbfG3OwS (ORCPT ); Tue, 30 Jul 2019 10:52:18 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:40249 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726535AbfG3OwS (ORCPT ); Tue, 30 Jul 2019 10:52:18 -0400 Received: by mail-lf1-f66.google.com with SMTP id b17so44958096lff.7; Tue, 30 Jul 2019 07:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vLDKuH+/Y6R1wGAQGSCIi/9agKk/j9gR7pNqj2Ro2Ic=; b=iuQpUu6a8JnbGLjoBITZrEilnUrTWiH26PXOZvr0eJQhTGXYXPQKMEzNw2wB2Zdhwg O1s79fuH/+qKj9qM+F5N7WUORuY3bi2XPxK5gT8Guf2uZd9D6oyAtYDwhskz/FMsfn6o lKk6nD1IBmzrEbMo1z8fbSNSoKGZUfXjLfcnm5mKawQB8u+vap+bsQ1AUfdjGTiXN2ty tL6eFXIjDfZ571OcOPQwvXVAUX+46G+xpgSdufwNKOjBmDF3XP8A7mx0CfXSR6UXqbUn dguHNLtM+ir+qgid1b0WJ9SI3b8hxcX2P6U5NkAvYIDJKRzUwkVnKHJszs5C7d/SjcoV C0AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vLDKuH+/Y6R1wGAQGSCIi/9agKk/j9gR7pNqj2Ro2Ic=; b=NGKkLnA3hd2NE4ghB6+4hIJSTtb9cJr6cmxiq2kByYTcHaMMPuXfTna4e9gbFu71KV 0+2i8dk7lLBpKWbif4YO2GlQZDEHSmzC5x/AXN9o1R6D+DA3j16adeONyzHjihQl3Ate vXyUXu/Nk2VT/F9WV0kk5Rx1b3dOBo/b8mQOGnf+KkkfF754NYokhQsrG46G0FsFS6af 5FxhCh10lwiGL7r59EDa4u/OfcxWvWN5XXVhr6S9EgvZzJJK9/2CWxKGXzYs4n+9AIsI VR4Z1TrlLrMbpzCfl8JMkC8D6kAsneqVk+f5H7jzUzH4WDAjJx0bIu48WODzUb193Bjt +YOQ== X-Gm-Message-State: APjAAAURGDLiJx2rt9SaVWaZH/4vSPhunCbqFT8Yw94P4XM0Vxd03yba AK0mT27eiIhOokDDR+0ITTbx7mM9Yt3W/8VirXQQyg== X-Google-Smtp-Source: APXvYqwtNV8PHczquSPB8e+BmF7PEr+3WvMBui8pMbhp0rAOkLkZq6TteMkvwzTbZj0eIDgOEAic/3pWWOYVMC6LbUU= X-Received: by 2002:a19:c1cc:: with SMTP id r195mr53854149lff.95.1564498336043; Tue, 30 Jul 2019 07:52:16 -0700 (PDT) MIME-Version: 1.0 References: <20190215024830.GA26477@jordon-HP-15-Notebook-PC> <20190728180611.GA20589@mail-itl> <20190729133642.GQ1250@mail-itl> <20190730142233.GR1250@mail-itl> In-Reply-To: <20190730142233.GR1250@mail-itl> From: Souptick Joarder Date: Tue, 30 Jul 2019 20:22:02 +0530 Message-ID: Subject: Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev.c: Convert to use vm_map_pages() To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Boris Ostrovsky , Andrew Morton , Matthew Wilcox , Michal Hocko , Juergen Gross , Russell King - ARM Linux , robin.murphy@arm.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Linux-MM , stable@vger.kernel.org, Greg KH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 7:52 PM Marek Marczykowski-G=C3=B3recki wrote: > > On Tue, Jul 30, 2019 at 10:05:42AM -0400, Boris Ostrovsky wrote: > > On 7/30/19 2:03 AM, Souptick Joarder wrote: > > > On Mon, Jul 29, 2019 at 7:06 PM Marek Marczykowski-G=C3=B3recki > > > wrote: > > >> On Mon, Jul 29, 2019 at 02:02:54PM +0530, Souptick Joarder wrote: > > >>> On Mon, Jul 29, 2019 at 1:35 PM Souptick Joarder wrote: > > >>>> On Sun, Jul 28, 2019 at 11:36 PM Marek Marczykowski-G=C3=B3recki > > >>>> wrote: > > >>>>> On Fri, Feb 15, 2019 at 08:18:31AM +0530, Souptick Joarder wrote: > > >>>>>> Convert to use vm_map_pages() to map range of kernel > > >>>>>> memory to user vma. > > >>>>>> > > >>>>>> map->count is passed to vm_map_pages() and internal API > > >>>>>> verify map->count against count ( count =3D vma_pages(vma)) > > >>>>>> for page array boundary overrun condition. > > >>>>> This commit breaks gntdev driver. If vma->vm_pgoff > 0, vm_map_pa= ges > > >>>>> will: > > >>>>> - use map->pages starting at vma->vm_pgoff instead of 0 > > >>>> The actual code ignores vma->vm_pgoff > 0 scenario and mapped > > >>>> the entire map->pages[i]. Why the entire map->pages[i] needs to be= mapped > > >>>> if vma->vm_pgoff > 0 (in original code) ? > > >> vma->vm_pgoff is used as index passed to gntdev_find_map_index. It's > > >> basically (ab)using this parameter for "which grant reference to map= ". > > >> > > >>>> are you referring to set vma->vm_pgoff =3D 0 irrespective of value= passed > > >>>> from user space ? If yes, using vm_map_pages_zero() is an alternat= e > > >>>> option. > > >> Yes, that should work. > > > I prefer to use vm_map_pages_zero() to resolve both the issues. Alter= natively > > > the patch can be reverted as you suggested. Let me know you opinion a= nd wait > > > for feedback from others. > > > > > > Boris, would you like to give any feedback ? > > > > vm_map_pages_zero() looks good to me. Marek, does it work for you? > > Yes, replacing vm_map_pages() with vm_map_pages_zero() fixes the > problem for me. Marek, I can send a patch for the same if you are ok. We need to cc stable as this changes are available in 5.2.4. > > -- > Best Regards, > Marek Marczykowski-G=C3=B3recki > Invisible Things Lab > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82BA4C0650F for ; Tue, 30 Jul 2019 14:52:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C79120665 for ; Tue, 30 Jul 2019 14:52:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iuQpUu6a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C79120665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B86E28E0003; Tue, 30 Jul 2019 10:52:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0F8E8E0001; Tue, 30 Jul 2019 10:52:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FF7B8E0003; Tue, 30 Jul 2019 10:52:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by kanga.kvack.org (Postfix) with ESMTP id 37A728E0001 for ; Tue, 30 Jul 2019 10:52:18 -0400 (EDT) Received: by mail-lj1-f198.google.com with SMTP id t25so138811ljc.17 for ; Tue, 30 Jul 2019 07:52:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=vLDKuH+/Y6R1wGAQGSCIi/9agKk/j9gR7pNqj2Ro2Ic=; b=tDpJY/U7xOXcorN3kl8/ChU8AHYY+PRCiW3rzkl3hWtkBhEIqki5GK3zn9wdZWHLTq HVvT6LBTpm8Vh5GrjfszodYo0Cqdo7GOcg2RjrdkLzV6Nrz3Ejwv7FFPGm4zop6dk1Yc n62xatKNSC/A+RzPkI2dfUBotB6xTvso5+gf+0okOmg26zm0WEzS4nHdZ9/h5vGRKxY1 gmsI7qa2E8AuyZCe70I9AVMaVceDaRr7I/u8aJ+eUM6tYCCH9IqUj/zibSe6KPM+wMBK /jqYD2LkfehvdFCjZjIZ/bB47js/bUmf23yNRj9g7CTqH554KqXwR+1nKiQx5Ox9NlJk x7ig== X-Gm-Message-State: APjAAAWtkSO3t6scnfxbHlqWCGZNTUsqy5kfu45XfZctXH3hf7WYWKeR JiziFaVHcerEXEhLmSqMZwOefmqC0VgOT8kFnoyLeubI2yAAavoSya1rKjjwn4kojFzslgAby+0 5gn9Q3SJJSBbdd9nzJTJW/V9zOS3Zb56ES7EHA0Uzz1pIOY+OIrNjB8t4Q36/E9WF+g== X-Received: by 2002:a2e:5b0f:: with SMTP id p15mr59335233ljb.82.1564498337317; Tue, 30 Jul 2019 07:52:17 -0700 (PDT) X-Received: by 2002:a2e:5b0f:: with SMTP id p15mr59335200ljb.82.1564498336407; Tue, 30 Jul 2019 07:52:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564498336; cv=none; d=google.com; s=arc-20160816; b=EVSNLa1gZH6uN6GXiFBEHEDlhF32XNmotPpK1GFT5D1BYr/Q41NtHFEvi7nEjjlMsD i+g6dmGHNgDcWJ3EnWkvAY2VChsGIGfgGL9DJm7RYAiWhHFo1HNV/BTaIcZem7TzJitd m7eWKnGc4cqs2h2uXt2FdCByChkQYSdiFiHLHm7dSiGEDtgFSefAM7tqxKo6gjrPr7OK uXZD30Ya9GEEo/glLHLmqisjwiY7xlqFYWFffsYnBVkUku6iMjBW4vWspUMfslpkN2r1 HRmy4K2WocCcoRrdqyYBLded20vlHoAA5N7iXLst4BVQMPXJKriAvkqBzb3F+6ew18tj 5flg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=vLDKuH+/Y6R1wGAQGSCIi/9agKk/j9gR7pNqj2Ro2Ic=; b=U1rO2gI+2f9Cr2bvh6gGR4C+Sgyf7iFUlLIS/UkHnlsLGDViKH6qTj1B8PGkjdz1vW SvtBbdN/E4mTFp89S+OvGmaPqSdV+E7+sqzxDku88T9CQ2Vp62X4h97Xwsw1NUwKRHHP YqsnEbSMnQhOcivrf80Xq9tJVb6W33gFVfYg2mg/Hxx5gN4I8/FLgligSkbMgEO41vuB YHPCMUn69chKDxfGx2ExIqL/5AGUrNue7r5V2t5NRK3UEapQqkEqAu+N1fAu2MmtWhLw +68JmtaagPiqt4qsNAT4TBnIEb4Lmz4x5mMj5x9Z87BzpUY2poDYmR/c625x6eca+6N9 yqQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iuQpUu6a; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id v21sor16762854lfi.6.2019.07.30.07.52.16 for (Google Transport Security); Tue, 30 Jul 2019 07:52:16 -0700 (PDT) Received-SPF: pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iuQpUu6a; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vLDKuH+/Y6R1wGAQGSCIi/9agKk/j9gR7pNqj2Ro2Ic=; b=iuQpUu6a8JnbGLjoBITZrEilnUrTWiH26PXOZvr0eJQhTGXYXPQKMEzNw2wB2Zdhwg O1s79fuH/+qKj9qM+F5N7WUORuY3bi2XPxK5gT8Guf2uZd9D6oyAtYDwhskz/FMsfn6o lKk6nD1IBmzrEbMo1z8fbSNSoKGZUfXjLfcnm5mKawQB8u+vap+bsQ1AUfdjGTiXN2ty tL6eFXIjDfZ571OcOPQwvXVAUX+46G+xpgSdufwNKOjBmDF3XP8A7mx0CfXSR6UXqbUn dguHNLtM+ir+qgid1b0WJ9SI3b8hxcX2P6U5NkAvYIDJKRzUwkVnKHJszs5C7d/SjcoV C0AQ== X-Google-Smtp-Source: APXvYqwtNV8PHczquSPB8e+BmF7PEr+3WvMBui8pMbhp0rAOkLkZq6TteMkvwzTbZj0eIDgOEAic/3pWWOYVMC6LbUU= X-Received: by 2002:a19:c1cc:: with SMTP id r195mr53854149lff.95.1564498336043; Tue, 30 Jul 2019 07:52:16 -0700 (PDT) MIME-Version: 1.0 References: <20190215024830.GA26477@jordon-HP-15-Notebook-PC> <20190728180611.GA20589@mail-itl> <20190729133642.GQ1250@mail-itl> <20190730142233.GR1250@mail-itl> In-Reply-To: <20190730142233.GR1250@mail-itl> From: Souptick Joarder Date: Tue, 30 Jul 2019 20:22:02 +0530 Message-ID: Subject: Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev.c: Convert to use vm_map_pages() To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Boris Ostrovsky , Andrew Morton , Matthew Wilcox , Michal Hocko , Juergen Gross , Russell King - ARM Linux , robin.murphy@arm.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Linux-MM , stable@vger.kernel.org, Greg KH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 30, 2019 at 7:52 PM Marek Marczykowski-G=C3=B3recki wrote: > > On Tue, Jul 30, 2019 at 10:05:42AM -0400, Boris Ostrovsky wrote: > > On 7/30/19 2:03 AM, Souptick Joarder wrote: > > > On Mon, Jul 29, 2019 at 7:06 PM Marek Marczykowski-G=C3=B3recki > > > wrote: > > >> On Mon, Jul 29, 2019 at 02:02:54PM +0530, Souptick Joarder wrote: > > >>> On Mon, Jul 29, 2019 at 1:35 PM Souptick Joarder wrote: > > >>>> On Sun, Jul 28, 2019 at 11:36 PM Marek Marczykowski-G=C3=B3recki > > >>>> wrote: > > >>>>> On Fri, Feb 15, 2019 at 08:18:31AM +0530, Souptick Joarder wrote: > > >>>>>> Convert to use vm_map_pages() to map range of kernel > > >>>>>> memory to user vma. > > >>>>>> > > >>>>>> map->count is passed to vm_map_pages() and internal API > > >>>>>> verify map->count against count ( count =3D vma_pages(vma)) > > >>>>>> for page array boundary overrun condition. > > >>>>> This commit breaks gntdev driver. If vma->vm_pgoff > 0, vm_map_pa= ges > > >>>>> will: > > >>>>> - use map->pages starting at vma->vm_pgoff instead of 0 > > >>>> The actual code ignores vma->vm_pgoff > 0 scenario and mapped > > >>>> the entire map->pages[i]. Why the entire map->pages[i] needs to be= mapped > > >>>> if vma->vm_pgoff > 0 (in original code) ? > > >> vma->vm_pgoff is used as index passed to gntdev_find_map_index. It's > > >> basically (ab)using this parameter for "which grant reference to map= ". > > >> > > >>>> are you referring to set vma->vm_pgoff =3D 0 irrespective of value= passed > > >>>> from user space ? If yes, using vm_map_pages_zero() is an alternat= e > > >>>> option. > > >> Yes, that should work. > > > I prefer to use vm_map_pages_zero() to resolve both the issues. Alter= natively > > > the patch can be reverted as you suggested. Let me know you opinion a= nd wait > > > for feedback from others. > > > > > > Boris, would you like to give any feedback ? > > > > vm_map_pages_zero() looks good to me. Marek, does it work for you? > > Yes, replacing vm_map_pages() with vm_map_pages_zero() fixes the > problem for me. Marek, I can send a patch for the same if you are ok. We need to cc stable as this changes are available in 5.2.4. > > -- > Best Regards, > Marek Marczykowski-G=C3=B3recki > Invisible Things Lab > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62046C0650F for ; Tue, 30 Jul 2019 14:52:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33FC820665 for ; Tue, 30 Jul 2019 14:52:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iuQpUu6a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33FC820665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hsTUB-00031X-0X; Tue, 30 Jul 2019 14:52:19 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hsTUA-00031S-C2 for xen-devel@lists.xenproject.org; Tue, 30 Jul 2019 14:52:18 +0000 X-Inumbo-ID: 9f852380-b2d9-11e9-8980-bc764e045a96 Received: from mail-lf1-x141.google.com (unknown [2a00:1450:4864:20::141]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 9f852380-b2d9-11e9-8980-bc764e045a96; Tue, 30 Jul 2019 14:52:17 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id v85so44902935lfa.6 for ; Tue, 30 Jul 2019 07:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vLDKuH+/Y6R1wGAQGSCIi/9agKk/j9gR7pNqj2Ro2Ic=; b=iuQpUu6a8JnbGLjoBITZrEilnUrTWiH26PXOZvr0eJQhTGXYXPQKMEzNw2wB2Zdhwg O1s79fuH/+qKj9qM+F5N7WUORuY3bi2XPxK5gT8Guf2uZd9D6oyAtYDwhskz/FMsfn6o lKk6nD1IBmzrEbMo1z8fbSNSoKGZUfXjLfcnm5mKawQB8u+vap+bsQ1AUfdjGTiXN2ty tL6eFXIjDfZ571OcOPQwvXVAUX+46G+xpgSdufwNKOjBmDF3XP8A7mx0CfXSR6UXqbUn dguHNLtM+ir+qgid1b0WJ9SI3b8hxcX2P6U5NkAvYIDJKRzUwkVnKHJszs5C7d/SjcoV C0AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vLDKuH+/Y6R1wGAQGSCIi/9agKk/j9gR7pNqj2Ro2Ic=; b=HDTgRG4EmVTPGa96tQ5/HcXr1fWYOnufmNSJuovNPAcEZORmUG9CVfg5S9QFMiEE2R SWO+Q9y73m9EYKwBiSc6ZqfFhUaO1Y7pXPVF9VTbW1V72pXHw+PdjnzYsdo4ckqLYSvl k6b8ROQN9jDEa+OyPCDJJOBlmkFyt9EQIFpglg94Idjru0vR9llSfRf13hHpbcflGbNk swY8ZEFlMf8zOvk6A8MhBJySJvTryiKxSKA35XeOaLTPrFbn3Ggrn7YuIeriBuMEP7DF 00SozL+h6n2dUri8iiSHtIUN/2+VkFI9bqw5aLcVoNGCYiUTxun9a8hiVtG3o5+kAO1W l2WQ== X-Gm-Message-State: APjAAAVhxLkRU/QJrQJBf4W2Hug0PCD/FqA3P/UHXxo0nQR1Sn/fDPe4 LpgAb6fYCBb3Z8YGiiImkcw9ZKAYqPAZX5htf2s= X-Google-Smtp-Source: APXvYqwtNV8PHczquSPB8e+BmF7PEr+3WvMBui8pMbhp0rAOkLkZq6TteMkvwzTbZj0eIDgOEAic/3pWWOYVMC6LbUU= X-Received: by 2002:a19:c1cc:: with SMTP id r195mr53854149lff.95.1564498336043; Tue, 30 Jul 2019 07:52:16 -0700 (PDT) MIME-Version: 1.0 References: <20190215024830.GA26477@jordon-HP-15-Notebook-PC> <20190728180611.GA20589@mail-itl> <20190729133642.GQ1250@mail-itl> <20190730142233.GR1250@mail-itl> In-Reply-To: <20190730142233.GR1250@mail-itl> From: Souptick Joarder Date: Tue, 30 Jul 2019 20:22:02 +0530 Message-ID: To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Subject: Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev.c: Convert to use vm_map_pages() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Michal Hocko , Greg KH , Russell King - ARM Linux , Matthew Wilcox , linux-kernel@vger.kernel.org, Linux-MM , stable@vger.kernel.org, xen-devel@lists.xenproject.org, Boris Ostrovsky , robin.murphy@arm.com, Andrew Morton Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gVHVlLCBKdWwgMzAsIDIwMTkgYXQgNzo1MiBQTSBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVj a2kKPG1hcm1hcmVrQGludmlzaWJsZXRoaW5nc2xhYi5jb20+IHdyb3RlOgo+Cj4gT24gVHVlLCBK dWwgMzAsIDIwMTkgYXQgMTA6MDU6NDJBTSAtMDQwMCwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOgo+ ID4gT24gNy8zMC8xOSAyOjAzIEFNLCBTb3VwdGljayBKb2FyZGVyIHdyb3RlOgo+ID4gPiBPbiBN b24sIEp1bCAyOSwgMjAxOSBhdCA3OjA2IFBNIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraQo+ ID4gPiA8bWFybWFyZWtAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4gd3JvdGU6Cj4gPiA+PiBPbiBN b24sIEp1bCAyOSwgMjAxOSBhdCAwMjowMjo1NFBNICswNTMwLCBTb3VwdGljayBKb2FyZGVyIHdy b3RlOgo+ID4gPj4+IE9uIE1vbiwgSnVsIDI5LCAyMDE5IGF0IDE6MzUgUE0gU291cHRpY2sgSm9h cmRlciA8anJkci5saW51eEBnbWFpbC5jb20+IHdyb3RlOgo+ID4gPj4+PiBPbiBTdW4sIEp1bCAy OCwgMjAxOSBhdCAxMTozNiBQTSBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kKPiA+ID4+Pj4g PG1hcm1hcmVrQGludmlzaWJsZXRoaW5nc2xhYi5jb20+IHdyb3RlOgo+ID4gPj4+Pj4gT24gRnJp LCBGZWIgMTUsIDIwMTkgYXQgMDg6MTg6MzFBTSArMDUzMCwgU291cHRpY2sgSm9hcmRlciB3cm90 ZToKPiA+ID4+Pj4+PiBDb252ZXJ0IHRvIHVzZSB2bV9tYXBfcGFnZXMoKSB0byBtYXAgcmFuZ2Ug b2Yga2VybmVsCj4gPiA+Pj4+Pj4gbWVtb3J5IHRvIHVzZXIgdm1hLgo+ID4gPj4+Pj4+Cj4gPiA+ Pj4+Pj4gbWFwLT5jb3VudCBpcyBwYXNzZWQgdG8gdm1fbWFwX3BhZ2VzKCkgYW5kIGludGVybmFs IEFQSQo+ID4gPj4+Pj4+IHZlcmlmeSBtYXAtPmNvdW50IGFnYWluc3QgY291bnQgKCBjb3VudCA9 IHZtYV9wYWdlcyh2bWEpKQo+ID4gPj4+Pj4+IGZvciBwYWdlIGFycmF5IGJvdW5kYXJ5IG92ZXJy dW4gY29uZGl0aW9uLgo+ID4gPj4+Pj4gVGhpcyBjb21taXQgYnJlYWtzIGdudGRldiBkcml2ZXIu IElmIHZtYS0+dm1fcGdvZmYgPiAwLCB2bV9tYXBfcGFnZXMKPiA+ID4+Pj4+IHdpbGw6Cj4gPiA+ Pj4+PiAgLSB1c2UgbWFwLT5wYWdlcyBzdGFydGluZyBhdCB2bWEtPnZtX3Bnb2ZmIGluc3RlYWQg b2YgMAo+ID4gPj4+PiBUaGUgYWN0dWFsIGNvZGUgaWdub3JlcyB2bWEtPnZtX3Bnb2ZmID4gMCBz Y2VuYXJpbyBhbmQgbWFwcGVkCj4gPiA+Pj4+IHRoZSBlbnRpcmUgbWFwLT5wYWdlc1tpXS4gV2h5 IHRoZSBlbnRpcmUgbWFwLT5wYWdlc1tpXSBuZWVkcyB0byBiZSBtYXBwZWQKPiA+ID4+Pj4gaWYg dm1hLT52bV9wZ29mZiA+IDAgKGluIG9yaWdpbmFsIGNvZGUpID8KPiA+ID4+IHZtYS0+dm1fcGdv ZmYgaXMgdXNlZCBhcyBpbmRleCBwYXNzZWQgdG8gZ250ZGV2X2ZpbmRfbWFwX2luZGV4LiBJdCdz Cj4gPiA+PiBiYXNpY2FsbHkgKGFiKXVzaW5nIHRoaXMgcGFyYW1ldGVyIGZvciAid2hpY2ggZ3Jh bnQgcmVmZXJlbmNlIHRvIG1hcCIuCj4gPiA+Pgo+ID4gPj4+PiBhcmUgeW91IHJlZmVycmluZyB0 byBzZXQgdm1hLT52bV9wZ29mZiA9IDAgaXJyZXNwZWN0aXZlIG9mIHZhbHVlIHBhc3NlZAo+ID4g Pj4+PiBmcm9tIHVzZXIgc3BhY2UgPyBJZiB5ZXMsIHVzaW5nIHZtX21hcF9wYWdlc196ZXJvKCkg aXMgYW4gYWx0ZXJuYXRlCj4gPiA+Pj4+IG9wdGlvbi4KPiA+ID4+IFllcywgdGhhdCBzaG91bGQg d29yay4KPiA+ID4gSSBwcmVmZXIgdG8gdXNlIHZtX21hcF9wYWdlc196ZXJvKCkgdG8gcmVzb2x2 ZSBib3RoIHRoZSBpc3N1ZXMuIEFsdGVybmF0aXZlbHkKPiA+ID4gdGhlIHBhdGNoIGNhbiBiZSBy ZXZlcnRlZCBhcyB5b3Ugc3VnZ2VzdGVkLiBMZXQgbWUga25vdyB5b3Ugb3BpbmlvbiBhbmQgd2Fp dAo+ID4gPiBmb3IgZmVlZGJhY2sgZnJvbSBvdGhlcnMuCj4gPiA+Cj4gPiA+IEJvcmlzLCB3b3Vs ZCB5b3UgbGlrZSB0byBnaXZlIGFueSBmZWVkYmFjayA/Cj4gPgo+ID4gdm1fbWFwX3BhZ2VzX3pl cm8oKSBsb29rcyBnb29kIHRvIG1lLiBNYXJlaywgZG9lcyBpdCB3b3JrIGZvciB5b3U/Cj4KPiBZ ZXMsIHJlcGxhY2luZyB2bV9tYXBfcGFnZXMoKSB3aXRoIHZtX21hcF9wYWdlc196ZXJvKCkgZml4 ZXMgdGhlCj4gcHJvYmxlbSBmb3IgbWUuCgpNYXJlaywgSSBjYW4gc2VuZCBhIHBhdGNoIGZvciB0 aGUgc2FtZSBpZiB5b3UgYXJlIG9rLgpXZSBuZWVkIHRvIGNjIHN0YWJsZSBhcyB0aGlzIGNoYW5n ZXMgYXJlIGF2YWlsYWJsZSBpbiA1LjIuNC4KCj4KPiAtLQo+IEJlc3QgUmVnYXJkcywKPiBNYXJl ayBNYXJjenlrb3dza2ktR8OzcmVja2kKPiBJbnZpc2libGUgVGhpbmdzIExhYgo+IEE6IEJlY2F1 c2UgaXQgbWVzc2VzIHVwIHRoZSBvcmRlciBpbiB3aGljaCBwZW9wbGUgbm9ybWFsbHkgcmVhZCB0 ZXh0Lgo+IFE6IFdoeSBpcyB0b3AtcG9zdGluZyBzdWNoIGEgYmFkIHRoaW5nPwoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcg bGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9q ZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==