* [PATCH] hwtracing: intel_th: Change return type to vm_fault_t
@ 2018-04-17 14:15 Souptick Joarder
2018-05-02 5:44 ` Souptick Joarder
0 siblings, 1 reply; 5+ messages in thread
From: Souptick Joarder @ 2018-04-17 14:15 UTC (permalink / raw)
To: alexander.shishkin; +Cc: linux-kernel, willy
Use new return type vm_fault_t for fault handler. For
now, this is just documenting that the function returns
a VM_FAULT value rather than an errno. Once all instances
are converted, vm_fault_t will become a distinct type.
Reference id -> 1c8f422059ae ("mm: change return type to
vm_fault_t")
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/hwtracing/intel_th/msu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
index dfb57ea..0ac84eb 100644
--- a/drivers/hwtracing/intel_th/msu.c
+++ b/drivers/hwtracing/intel_th/msu.c
@@ -1190,7 +1190,7 @@ static void msc_mmap_close(struct vm_area_struct *vma)
mutex_unlock(&msc->buf_mutex);
}
-static int msc_mmap_fault(struct vm_fault *vmf)
+static vm_fault_t msc_mmap_fault(struct vm_fault *vmf)
{
struct msc_iter *iter = vmf->vma->vm_file->private_data;
struct msc *msc = iter->msc;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault_t
2018-04-17 14:15 [PATCH] hwtracing: intel_th: Change return type to vm_fault_t Souptick Joarder
@ 2018-05-02 5:44 ` Souptick Joarder
2018-05-02 13:58 ` Alexander Shishkin
0 siblings, 1 reply; 5+ messages in thread
From: Souptick Joarder @ 2018-05-02 5:44 UTC (permalink / raw)
To: alexander.shishkin; +Cc: linux-kernel, Matthew Wilcox
Any comment for this patch ?
On Tue, Apr 17, 2018 at 7:45 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Reference id -> 1c8f422059ae ("mm: change return type to
> vm_fault_t")
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> drivers/hwtracing/intel_th/msu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
> index dfb57ea..0ac84eb 100644
> --- a/drivers/hwtracing/intel_th/msu.c
> +++ b/drivers/hwtracing/intel_th/msu.c
> @@ -1190,7 +1190,7 @@ static void msc_mmap_close(struct vm_area_struct *vma)
> mutex_unlock(&msc->buf_mutex);
> }
>
> -static int msc_mmap_fault(struct vm_fault *vmf)
> +static vm_fault_t msc_mmap_fault(struct vm_fault *vmf)
> {
> struct msc_iter *iter = vmf->vma->vm_file->private_data;
> struct msc *msc = iter->msc;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault_t
2018-05-02 5:44 ` Souptick Joarder
@ 2018-05-02 13:58 ` Alexander Shishkin
[not found] ` <CAFqt6zbSuVZjH0W6o7fMLpytk28y_4tZ7Mt1B36SX=+LkaUP3A@mail.gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Shishkin @ 2018-05-02 13:58 UTC (permalink / raw)
To: Souptick Joarder; +Cc: alexander.shishkin, linux-kernel, Matthew Wilcox
On Wed, May 02, 2018 at 11:14:48AM +0530, Souptick Joarder wrote:
> Any comment for this patch ?
Looks good, I'm queuing this one for the next merge window.
Thanks you!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault_t
[not found] ` <CAFqt6zbyCvknqkwnhQiyY1j32zufVk0rkPfxgKbytZcXY=xTVQ@mail.gmail.com>
@ 2018-06-17 5:54 ` Souptick Joarder
0 siblings, 0 replies; 5+ messages in thread
From: Souptick Joarder @ 2018-06-17 5:54 UTC (permalink / raw)
To: Alexander Shishkin; +Cc: Matthew Wilcox, linux-kernel
On Wed, May 2, 2018 at 7:32 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> On 02-May-2018 7:28 PM, "Alexander Shishkin"
> <alexander.shishkin@linux.intel.com> wrote:
>>
>> On Wed, May 02, 2018 at 11:14:48AM +0530, Souptick Joarder wrote:
>> > Any comment for this patch ?
>>
>> Looks good, I'm queuing this one for the next merge window.
>>
This patch is not merged in 4.18-rc-1.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] hwtracing: intel_th: Change return type to vm_fault_t
@ 2018-07-02 15:58 Souptick Joarder
0 siblings, 0 replies; 5+ messages in thread
From: Souptick Joarder @ 2018-07-02 15:58 UTC (permalink / raw)
To: akpm; +Cc: alexander.shishkin, willy, linux-kernel
Use new return type vm_fault_t for fault handler. For
now, this is just documenting that the function returns
a VM_FAULT value rather than an errno. Once all instances
are converted, vm_fault_t will become a distinct type.
see commit 1c8f422059ae ("mm: change return type to
vm_fault_t") for reference.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/hwtracing/intel_th/msu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
index dfb57ea..0ac84eb 100644
--- a/drivers/hwtracing/intel_th/msu.c
+++ b/drivers/hwtracing/intel_th/msu.c
@@ -1190,7 +1190,7 @@ static void msc_mmap_close(struct vm_area_struct *vma)
mutex_unlock(&msc->buf_mutex);
}
-static int msc_mmap_fault(struct vm_fault *vmf)
+static vm_fault_t msc_mmap_fault(struct vm_fault *vmf)
{
struct msc_iter *iter = vmf->vma->vm_file->private_data;
struct msc *msc = iter->msc;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-02 15:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17 14:15 [PATCH] hwtracing: intel_th: Change return type to vm_fault_t Souptick Joarder
2018-05-02 5:44 ` Souptick Joarder
2018-05-02 13:58 ` Alexander Shishkin
[not found] ` <CAFqt6zbSuVZjH0W6o7fMLpytk28y_4tZ7Mt1B36SX=+LkaUP3A@mail.gmail.com>
[not found] ` <CAFqt6zbyCvknqkwnhQiyY1j32zufVk0rkPfxgKbytZcXY=xTVQ@mail.gmail.com>
2018-06-17 5:54 ` Souptick Joarder
2018-07-02 15:58 Souptick Joarder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.