From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A9AC2D0A3 for ; Tue, 10 Nov 2020 03:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A8932065E for ; Tue, 10 Nov 2020 03:09:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X1YhCkfL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730010AbgKJDJh (ORCPT ); Mon, 9 Nov 2020 22:09:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728607AbgKJDJh (ORCPT ); Mon, 9 Nov 2020 22:09:37 -0500 Received: from mail-vk1-xa42.google.com (mail-vk1-xa42.google.com [IPv6:2607:f8b0:4864:20::a42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F333EC0613CF for ; Mon, 9 Nov 2020 19:09:36 -0800 (PST) Received: by mail-vk1-xa42.google.com with SMTP id v5so1186661vkn.12 for ; Mon, 09 Nov 2020 19:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pZgRoZ+grb92ReTPi7dMzerQ5xu8KZMINDDLao9Et84=; b=X1YhCkfLkBAdLES81GYvQ2P/eG9WAuzpSw2BTpSlbQPS89ByHWI60wyHh/DLjBZrJ4 cR1vmSHM+8kFQlBKLDUBOj2Lk6rwnA8Q0twgbnl7l8At0eaLgsoTbm8JwWVnwMVSr0zv 2PR383yye9ztHE1DkHiwlr1L0saSmGbAeVCAS2x6xWigteMNBaZtbp2EInx4SQj3WHxq NuaOnuxzbwrcs2u/7ZH1kvOEKsXfAznNu/6oOUnxK5iUeoJTWpU0BFxgCkNc9J+RiOn7 /cIRo+XRT4aNbqjwq8kHKJk/vjxk0pR/FYkJ+h4p1grm7yhuvE+QIlVL+yX3y+1xJ9Wx Kjag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pZgRoZ+grb92ReTPi7dMzerQ5xu8KZMINDDLao9Et84=; b=cV8DTpJ0BrMu4WKtS1VgOP9WFD8VlZmfieJF4WBBcSAoM1xRc7LfvDY+FpXoMV5Zbi YRuD44NK9rTDPre8dXzgVC+SIam2UFnkqIFW9ijRblcZliXV2oJBge5t7SXzZAsgQrnF kg/lXXkym+WYXavHUMPcmoblQMklQ3Cp33fci5s69AGL2NCYDG8zf+E/2oFHq9chbMCe KSCBp0O4d3ZgvZ26lQk62sBVGTpF4MpgHlLE6mI9f3f/deWfaI/brjNKjFhTBo+9ZyJd wZuiEABb4DBkKnYFxHQsUmeIoWo4ZpIWMiG7LRHOSY2kNFgz6CeVI0mJ8YhOcTxzNfah eVGQ== X-Gm-Message-State: AOAM530WF2Sz1Qw+U1F55PiEtgb1ANmbtIrxSR3Wae0iDiDkwlkDHmy/ 407rvEdiK2m5afCLSzJsTEyJHGR3pes9tvOczlzNbR05OQYTKQ== X-Google-Smtp-Source: ABdhPJwFDr8TJq/toHUkOnKi1ykAKJGxGTdhqxOky0WSpSGoJWGqFX6KCucvlvhorC6Ygt/8D6/Y92JNPg50jhRUwHA= X-Received: by 2002:a1f:c843:: with SMTP id y64mr9127731vkf.23.1604977776227; Mon, 09 Nov 2020 19:09:36 -0800 (PST) MIME-Version: 1.0 References: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> In-Reply-To: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> From: Souptick Joarder Date: Tue, 10 Nov 2020 08:39:24 +0530 Message-ID: Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked To: Alex Shi Cc: Andrew Morton , Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 6, 2020 at 4:55 PM Alex Shi wrote: > > Otherwise it cause gcc warning: > ^~~~~~~~~~~~~~~ > ../mm/filemap.c:830:14: warning: no previous prototype for > =E2=80=98__add_to_page_cache_locked=E2=80=99 [-Wmissing-prototypes] > noinline int __add_to_page_cache_locked(struct page *page, > ^~~~~~~~~~~~~~~~~~~~~~~~~~ Is CONFIG_DEBUG_INFO_BTF enabled in your .config ? > > Signed-off-by: Alex Shi > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > mm/filemap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index d90614f501da..249cf489f5df 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -827,7 +827,7 @@ int replace_page_cache_page(struct page *old, struct = page *new, gfp_t gfp_mask) > } > EXPORT_SYMBOL_GPL(replace_page_cache_page); > > -noinline int __add_to_page_cache_locked(struct page *page, > +static noinline int __add_to_page_cache_locked(struct page *page, > struct address_space *mapping, > pgoff_t offset, gfp_t gfp, > void **shadowp) > -- > 1.8.3.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B2CC5517A for ; Tue, 10 Nov 2020 03:09:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2B8282067B for ; Tue, 10 Nov 2020 03:09:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X1YhCkfL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B8282067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4D8346B0036; Mon, 9 Nov 2020 22:09:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4893B6B005C; Mon, 9 Nov 2020 22:09:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39F096B005D; Mon, 9 Nov 2020 22:09:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 0EBD76B0036 for ; Mon, 9 Nov 2020 22:09:38 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9F180181AEF1A for ; Tue, 10 Nov 2020 03:09:37 +0000 (UTC) X-FDA: 77467028394.28.wall85_0404249272f1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 6C4306D64 for ; Tue, 10 Nov 2020 03:09:37 +0000 (UTC) X-HE-Tag: wall85_0404249272f1 X-Filterd-Recvd-Size: 4096 Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com [209.85.221.195]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 03:09:36 +0000 (UTC) Received: by mail-vk1-f195.google.com with SMTP id o73so2391286vka.5 for ; Mon, 09 Nov 2020 19:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pZgRoZ+grb92ReTPi7dMzerQ5xu8KZMINDDLao9Et84=; b=X1YhCkfLkBAdLES81GYvQ2P/eG9WAuzpSw2BTpSlbQPS89ByHWI60wyHh/DLjBZrJ4 cR1vmSHM+8kFQlBKLDUBOj2Lk6rwnA8Q0twgbnl7l8At0eaLgsoTbm8JwWVnwMVSr0zv 2PR383yye9ztHE1DkHiwlr1L0saSmGbAeVCAS2x6xWigteMNBaZtbp2EInx4SQj3WHxq NuaOnuxzbwrcs2u/7ZH1kvOEKsXfAznNu/6oOUnxK5iUeoJTWpU0BFxgCkNc9J+RiOn7 /cIRo+XRT4aNbqjwq8kHKJk/vjxk0pR/FYkJ+h4p1grm7yhuvE+QIlVL+yX3y+1xJ9Wx Kjag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pZgRoZ+grb92ReTPi7dMzerQ5xu8KZMINDDLao9Et84=; b=VJZGexhiQFPlq6idOfLW1WX7HfPt8FC1N7JF10q4Zjycdoby10jxwtgSxMf/jTOHmc 18VYOpuy92hKUshwwOyx6/16g+FWoJsaLWT1AjpcCepIzUWG5bgU79acTYkCmO9TwOx2 FlrHrmiu8GhqO8M25Xvv6gS1x9XFKIxyKK8naT8fC3GX29An/EBY/2ECpk2XINY4+5nO x6kwO6gNSZVCe8kGUByezcG9/F8yEsQk0jiq1I5yDOS356l7yX1kb0x889swApNJncld uf17hZ+x1b1HEeP6Ee61qW6CITMN8NzU78AdPJrvLrS3ls1suev8rbdziprQNuSii97q nM7A== X-Gm-Message-State: AOAM533qDsfATLoDx0gNewY+4SqzmzJNqtO2vTBo+dFHtXW8hw2V2Jzd n3iCyZ8sux9Vimw7wdCB1bXx7ajaw/RSWY2oZQ4= X-Google-Smtp-Source: ABdhPJwFDr8TJq/toHUkOnKi1ykAKJGxGTdhqxOky0WSpSGoJWGqFX6KCucvlvhorC6Ygt/8D6/Y92JNPg50jhRUwHA= X-Received: by 2002:a1f:c843:: with SMTP id y64mr9127731vkf.23.1604977776227; Mon, 09 Nov 2020 19:09:36 -0800 (PST) MIME-Version: 1.0 References: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> In-Reply-To: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> From: Souptick Joarder Date: Tue, 10 Nov 2020 08:39:24 +0530 Message-ID: Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked To: Alex Shi Cc: Andrew Morton , Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 6, 2020 at 4:55 PM Alex Shi wrote: > > Otherwise it cause gcc warning: > ^~~~~~~~~~~~~~~ > ../mm/filemap.c:830:14: warning: no previous prototype for > =E2=80=98__add_to_page_cache_locked=E2=80=99 [-Wmissing-prototypes] > noinline int __add_to_page_cache_locked(struct page *page, > ^~~~~~~~~~~~~~~~~~~~~~~~~~ Is CONFIG_DEBUG_INFO_BTF enabled in your .config ? > > Signed-off-by: Alex Shi > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > mm/filemap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index d90614f501da..249cf489f5df 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -827,7 +827,7 @@ int replace_page_cache_page(struct page *old, struct = page *new, gfp_t gfp_mask) > } > EXPORT_SYMBOL_GPL(replace_page_cache_page); > > -noinline int __add_to_page_cache_locked(struct page *page, > +static noinline int __add_to_page_cache_locked(struct page *page, > struct address_space *mapping, > pgoff_t offset, gfp_t gfp, > void **shadowp) > -- > 1.8.3.1 > >