All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm: memcontrol: Assign boolean values to a bool variable
@ 2020-11-07  8:24 ` xiakaixu1987-Re5JQEeQqe8AvxtiuMwx3w
  0 siblings, 0 replies; 4+ messages in thread
From: xiakaixu1987 @ 2020-11-07  8:24 UTC (permalink / raw)
  To: hannes, mhocko, vdavydov.dev; +Cc: linux-mm, cgroups, Kaixu Xia

From: Kaixu Xia <kaixuxia@tencent.com>

Fix the following coccinelle warnings:

./mm/memcontrol.c:7341:2-22: WARNING: Assignment of 0/1 to bool variable
./mm/memcontrol.c:7343:2-22: WARNING: Assignment of 0/1 to bool variable

Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
 mm/memcontrol.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 3dcbf24d2227..60147cf9f0c0 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -7349,9 +7349,9 @@ bool mem_cgroup_swap_full(struct page *page)
 static int __init setup_swap_account(char *s)
 {
 	if (!strcmp(s, "1"))
-		cgroup_memory_noswap = 0;
+		cgroup_memory_noswap = false;
 	else if (!strcmp(s, "0"))
-		cgroup_memory_noswap = 1;
+		cgroup_memory_noswap = true;
 	return 1;
 }
 __setup("swapaccount=", setup_swap_account);
-- 
2.20.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] mm: memcontrol: Assign boolean values to a bool variable
@ 2020-11-07  8:24 ` xiakaixu1987-Re5JQEeQqe8AvxtiuMwx3w
  0 siblings, 0 replies; 4+ messages in thread
From: xiakaixu1987-Re5JQEeQqe8AvxtiuMwx3w @ 2020-11-07  8:24 UTC (permalink / raw)
  To: hannes-druUgvl0LCNAfugRpC6u6w, mhocko-DgEjT+Ai2ygdnm+yROfE0A,
	vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w
  Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg, cgroups-u79uwXL29TY76Z2rM5mHXA,
	Kaixu Xia

From: Kaixu Xia <kaixuxia-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>

Fix the following coccinelle warnings:

./mm/memcontrol.c:7341:2-22: WARNING: Assignment of 0/1 to bool variable
./mm/memcontrol.c:7343:2-22: WARNING: Assignment of 0/1 to bool variable

Reported-by: Tosk Robot <tencent_os_robot-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Kaixu Xia <kaixuxia-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
---
 mm/memcontrol.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 3dcbf24d2227..60147cf9f0c0 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -7349,9 +7349,9 @@ bool mem_cgroup_swap_full(struct page *page)
 static int __init setup_swap_account(char *s)
 {
 	if (!strcmp(s, "1"))
-		cgroup_memory_noswap = 0;
+		cgroup_memory_noswap = false;
 	else if (!strcmp(s, "0"))
-		cgroup_memory_noswap = 1;
+		cgroup_memory_noswap = true;
 	return 1;
 }
 __setup("swapaccount=", setup_swap_account);
-- 
2.20.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: memcontrol: Assign boolean values to a bool variable
@ 2020-11-07  8:28   ` Souptick Joarder
  0 siblings, 0 replies; 4+ messages in thread
From: Souptick Joarder @ 2020-11-07  8:28 UTC (permalink / raw)
  To: xiakaixu1987
  Cc: Johannes Weiner, Michal Hocko, Vladimir Davydov, Linux-MM,
	cgroups, Kaixu Xia

On Sat, Nov 7, 2020 at 1:55 PM <xiakaixu1987@gmail.com> wrote:
>
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> Fix the following coccinelle warnings:
>
> ./mm/memcontrol.c:7341:2-22: WARNING: Assignment of 0/1 to bool variable
> ./mm/memcontrol.c:7343:2-22: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>

Acked-by: Souptick Joarder <jrdr.linux@gmail.com>

> ---
>  mm/memcontrol.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 3dcbf24d2227..60147cf9f0c0 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -7349,9 +7349,9 @@ bool mem_cgroup_swap_full(struct page *page)
>  static int __init setup_swap_account(char *s)
>  {
>         if (!strcmp(s, "1"))
> -               cgroup_memory_noswap = 0;
> +               cgroup_memory_noswap = false;
>         else if (!strcmp(s, "0"))
> -               cgroup_memory_noswap = 1;
> +               cgroup_memory_noswap = true;
>         return 1;
>  }
>  __setup("swapaccount=", setup_swap_account);
> --
> 2.20.0
>
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: memcontrol: Assign boolean values to a bool variable
@ 2020-11-07  8:28   ` Souptick Joarder
  0 siblings, 0 replies; 4+ messages in thread
From: Souptick Joarder @ 2020-11-07  8:28 UTC (permalink / raw)
  To: xiakaixu1987-Re5JQEeQqe8AvxtiuMwx3w
  Cc: Johannes Weiner, Michal Hocko, Vladimir Davydov, Linux-MM,
	cgroups-u79uwXL29TY76Z2rM5mHXA, Kaixu Xia

On Sat, Nov 7, 2020 at 1:55 PM <xiakaixu1987-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> From: Kaixu Xia <kaixuxia-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
>
> Fix the following coccinelle warnings:
>
> ./mm/memcontrol.c:7341:2-22: WARNING: Assignment of 0/1 to bool variable
> ./mm/memcontrol.c:7343:2-22: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Tosk Robot <tencent_os_robot-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Kaixu Xia <kaixuxia-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>

Acked-by: Souptick Joarder <jrdr.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

> ---
>  mm/memcontrol.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 3dcbf24d2227..60147cf9f0c0 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -7349,9 +7349,9 @@ bool mem_cgroup_swap_full(struct page *page)
>  static int __init setup_swap_account(char *s)
>  {
>         if (!strcmp(s, "1"))
> -               cgroup_memory_noswap = 0;
> +               cgroup_memory_noswap = false;
>         else if (!strcmp(s, "0"))
> -               cgroup_memory_noswap = 1;
> +               cgroup_memory_noswap = true;
>         return 1;
>  }
>  __setup("swapaccount=", setup_swap_account);
> --
> 2.20.0
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-07  8:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-07  8:24 [PATCH] mm: memcontrol: Assign boolean values to a bool variable xiakaixu1987
2020-11-07  8:24 ` xiakaixu1987-Re5JQEeQqe8AvxtiuMwx3w
2020-11-07  8:28 ` Souptick Joarder
2020-11-07  8:28   ` Souptick Joarder

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.