From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0CFBC433EF for ; Mon, 20 Dec 2021 15:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xxcbYiwT+P+MWIUrSIkM3mz6SiYoBh0STkv/SnIQOXQ=; b=ucxqPsPWJv3NJO pshlBfijAuzokYEBmP+IL6o58T8D1RnyHA/HcRuQDs0YNTIGI9ilZVQfPvdz9TWyPt77gDoQ58UlU vNKj8heh0zSBsIvyw2LVgCnDxJVJtJ2N7XIt2j0xqcsjPIMCQLKgh6TJADRVXUQ0laRyJ6ZOQ78fR nDHXWjvHJj8x+n6W8ssG108jEu+ofnUlLCQSquT051pFOk1CMqYQLgJRdIf4veByNxG/EI5OtGcpM iO+iqwsN4uiOy/9RHPj8kVTP1DaEUztE6WWR/0PMm7N0GvwnTg65Iel8/9xMYK0ytFSFJildGhIHx SS33sGrM/0Kk8frLdjlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzK7v-002yoT-JN; Mon, 20 Dec 2021 14:58:59 +0000 Received: from mail-ua1-x934.google.com ([2607:f8b0:4864:20::934]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzK7r-002ymQ-S3 for linux-arm-kernel@lists.infradead.org; Mon, 20 Dec 2021 14:58:57 +0000 Received: by mail-ua1-x934.google.com with SMTP id 107so18112411uaj.10 for ; Mon, 20 Dec 2021 06:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QDssa22PhMGtbl20NqdUydglCsPzDhQ+/kIfIMV54VE=; b=VNARcXCfe63PrdPYsk3dsMjHDo34eHTOtCfDqLrExExXU3wO1DBiOP52cFcFmMtqic NbOPyzO2VDWuUqABih5Nm7vlUAOs0OXV2CKoMY7OWw3W2EJiZX1l5hNblqPvVSiOlSZ3 zCCFE2NeNypdjcj2dF2djKZuRjoRXHzEMzWS0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QDssa22PhMGtbl20NqdUydglCsPzDhQ+/kIfIMV54VE=; b=kJLTuqT+/8egbOTGGX8QTPuAD/ccQPNZyjO+UyewAgclly1WwphstRJkbZFVie/tAF RewLzizgQw2Y45riOnua+ttGeLpsizX0I9j2YJp6y70UwtI4xalG9gjpeohU8EpzY/bW I6mecA1LgpgkrPDnBQ6YaUHMivd6hvfwKtTwYcm6+roNkkO1DLXua1Fo2JLtYTyE3R1A apNtHdb5VMya09TKCJ5Kl3+KSOBiYL641Zcs/dZXyfw/yJMnwfMugYs0lfZzx36/n9+E XPEJ4OO0HAUznbxc/YBuSze2J2teMVIwqGC3FhO/MCmE2VnLjDP7S5tqd1eBHAxbVLte dBVw== X-Gm-Message-State: AOAM530p59tSg2+Lm6WjOhXUY1kSt5lptmNlhjFLlDEL6W3/h8YiKpjB 2GfTaUHTWcj5xPA2PtqauC9OWEyvuA0jK+cFgmSEVw== X-Google-Smtp-Source: ABdhPJyTQPfX4cHVqBvCyRUj4DqcBhzYOXOwS7xn4vLsweFAl3oW5gSqs6O2hZ7oAQ1/FsAxvoD3e28q68NQLEfwXYk= X-Received: by 2002:a05:6102:3a0c:: with SMTP id b12mr4955593vsu.48.1640012333603; Mon, 20 Dec 2021 06:58:53 -0800 (PST) MIME-Version: 1.0 References: <20211213094036.1787950-1-daniel@0x0f.com> <20211213094036.1787950-5-daniel@0x0f.com> In-Reply-To: From: Daniel Palmer Date: Tue, 21 Dec 2021 00:02:04 +0900 Message-ID: Subject: Re: [PATCH v3 4/5] gpio: msc313: Add support for SSD201 and SSD202D To: Bartosz Golaszewski Cc: Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux ARM , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211220_065856_050283_889D6C4D X-CRM114-Status: GOOD ( 13.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bartosz, On Mon, 20 Dec 2021 at 23:50, Bartosz Golaszewski wrote: > > On Mon, Dec 13, 2021 at 10:40 AM Daniel Palmer wrote: > > > > This adds GPIO support for the SSD201 and SSD202D chips. > > > > Signed-off-by: Daniel Palmer > > Reviewed-by: Linus Walleij > > --- > > I applied patches 1-3. This triggers a bunch of checkpatch errors. > Please address them and resend this single patch. The warnings about complex macros being wrapped in parentheses when the things it's complaining about are defined lists not macros? Not going to say I know better than checkpatch but I think the errors there are wrong. Putting parentheses around the lists would break the arrays they get put into. Cheers, Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF8E3C4332F for ; Mon, 20 Dec 2021 15:19:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238928AbhLTPTA (ORCPT ); Mon, 20 Dec 2021 10:19:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234933AbhLTPRr (ORCPT ); Mon, 20 Dec 2021 10:17:47 -0500 Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92669C08ECB4 for ; Mon, 20 Dec 2021 06:58:54 -0800 (PST) Received: by mail-ua1-x933.google.com with SMTP id i6so18164633uae.6 for ; Mon, 20 Dec 2021 06:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QDssa22PhMGtbl20NqdUydglCsPzDhQ+/kIfIMV54VE=; b=VNARcXCfe63PrdPYsk3dsMjHDo34eHTOtCfDqLrExExXU3wO1DBiOP52cFcFmMtqic NbOPyzO2VDWuUqABih5Nm7vlUAOs0OXV2CKoMY7OWw3W2EJiZX1l5hNblqPvVSiOlSZ3 zCCFE2NeNypdjcj2dF2djKZuRjoRXHzEMzWS0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QDssa22PhMGtbl20NqdUydglCsPzDhQ+/kIfIMV54VE=; b=jneGY4rft5Wzue6w0WevhvJJyDF2zD79AmrUrvAIhtRs75+E9EYaFe4jg8o0F9GO/a bKtW6zIORKgYvycYBg6uapZFFwgTJmWGjdyTcIwqKJkBfgtVR8WqWrTaCS77/o8PKKi9 CKlXbp9PitCJEM5IqlfagiNkQWscrewcPrz+wOxSl5av6TQDB68DQBCdYqWo2QlSkEM5 TMUpxjjKrbItRgdlpSvWK89giBBpIB1AieECQkixhKpKQNGs5X4iIAwrDMkBQhrJmIYb bykLmkVWpJia7tk5vIEnAzj9DgakZNvVcvD6MnXv2jYgpxqk+dGzxBPYWg5JAXuYzlqe 18Og== X-Gm-Message-State: AOAM533S5zAL2Fb1SHkbiZ0wolFuu9Ruyg80+JoV2gc6cRk1ojvcYymw x6gf47drOwY+7nqjMgSFOZ3xt3Uk+zCuk+qK4Zl9mw== X-Google-Smtp-Source: ABdhPJyTQPfX4cHVqBvCyRUj4DqcBhzYOXOwS7xn4vLsweFAl3oW5gSqs6O2hZ7oAQ1/FsAxvoD3e28q68NQLEfwXYk= X-Received: by 2002:a05:6102:3a0c:: with SMTP id b12mr4955593vsu.48.1640012333603; Mon, 20 Dec 2021 06:58:53 -0800 (PST) MIME-Version: 1.0 References: <20211213094036.1787950-1-daniel@0x0f.com> <20211213094036.1787950-5-daniel@0x0f.com> In-Reply-To: From: Daniel Palmer Date: Tue, 21 Dec 2021 00:02:04 +0900 Message-ID: Subject: Re: [PATCH v3 4/5] gpio: msc313: Add support for SSD201 and SSD202D To: Bartosz Golaszewski Cc: Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Bartosz, On Mon, 20 Dec 2021 at 23:50, Bartosz Golaszewski wrote: > > On Mon, Dec 13, 2021 at 10:40 AM Daniel Palmer wrote: > > > > This adds GPIO support for the SSD201 and SSD202D chips. > > > > Signed-off-by: Daniel Palmer > > Reviewed-by: Linus Walleij > > --- > > I applied patches 1-3. This triggers a bunch of checkpatch errors. > Please address them and resend this single patch. The warnings about complex macros being wrapped in parentheses when the things it's complaining about are defined lists not macros? Not going to say I know better than checkpatch but I think the errors there are wrong. Putting parentheses around the lists would break the arrays they get put into. Cheers, Daniel