[PATCH] gcc-runtime: do_check should execute before do_build

[PATCH] gcc-runtime: do_check should execute before do_build

[bkylerussell]

Otherwise, when rm_work is used, do_check may not execute before rm_work
causing do_check failures if the workdir has been removed underneath it.

Signed-off-by: Kyle Russell <bkylerussell@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-runtime.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc b/meta/recipes-devtools/gcc/gcc-runtime.inc
index 59d9a24686..607971adca 100644
--- a/meta/recipes-devtools/gcc/gcc-runtime.inc
+++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
@@ -314,5 +314,5 @@ do_check() {
 
     oe_runmake -i ${MAKE_CHECK_TARGETS} RUNTESTFLAGS="${MAKE_CHECK_RUNTESTFLAGS}"
 }
-addtask check after do_compile do_populate_sysroot
+addtask check after do_compile do_populate_sysroot before do_build
 
-- 
2.25.1

Re: [OE-core] [PATCH] gcc-runtime: do_check should execute before do_build

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

This will result in a behavior change, making it so `bitbake gcc-runtime`
will run the check task. Are there implications to this?

On Fri, Jul 30, 2021 at 12:04 PM <bkylerussell@gmail.com> wrote:

> Otherwise, when rm_work is used, do_check may not execute before rm_work
> causing do_check failures if the workdir has been removed underneath it.
>
> Signed-off-by: Kyle Russell <bkylerussell@gmail.com>
> ---
>  meta/recipes-devtools/gcc/gcc-runtime.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc
> b/meta/recipes-devtools/gcc/gcc-runtime.inc
> index 59d9a24686..607971adca 100644
> --- a/meta/recipes-devtools/gcc/gcc-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
> @@ -314,5 +314,5 @@ do_check() {
>
>      oe_runmake -i ${MAKE_CHECK_TARGETS}
> RUNTESTFLAGS="${MAKE_CHECK_RUNTESTFLAGS}"
>  }
> -addtask check after do_compile do_populate_sysroot
> +addtask check after do_compile do_populate_sysroot before do_build
>
> --
> 2.25.1
>
>
> 
>
>

-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1750 bytes --]

Re: [OE-core] [PATCH] gcc-runtime: do_check should execute before do_build

[Richard Purdie]

On Fri, 2021-07-30 at 14:16 -0700, Christopher Larson wrote:
> This will result in a behavior change, making it so `bitbake gcc-runtime` will
> run the check task. Are there implications to this?

We definitely do not want to do that. This is used to run the testsuite which
isn't part of a normal build.

Cheers,

Richard

Re: [OE-core] [PATCH] gcc-runtime: do_check should execute before do_build

[bkylerussell]

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

I see. I had forgotten that the autobuilders don't run do_check as part of
the normal build.

We have a customization in our distro layer to run do_check on normal
builds. Internally, we use that as a hook to allow per-package test suites
to fail our integration pipeline during our normal builds. Maybe there's a
way we can prevent this conflict with rm_work from our own layer.

Sorry for the confusion,

Kyle


On Fri, Jul 30, 2021, 5:06 PM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Fri, 2021-07-30 at 14:16 -0700, Christopher Larson wrote:
> > This will result in a behavior change, making it so `bitbake
> gcc-runtime` will
> > run the check task. Are there implications to this?
>
> We definitely do not want to do that. This is used to run the testsuite
> which
> isn't part of a normal build.
>
> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 1340 bytes --]