Re: [2011.03-maintenance] do_compile failed for cacao_0.99.3.bb

From: "George C. Huntington, III" <george.huntingtoniii@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [2011.03-maintenance] do_compile failed for cacao_0.99.3.bb
Date: Tue, 30 Aug 2011 11:25:45 -0400	[thread overview]
Message-ID: <CAFu+nvGj96aCyZdphiDL6Rw+VdY8Kpzbd_29Y4G-hLNuwYzTWQ@mail.gmail.com> (raw)
In-Reply-To: <1314707457.3796.19.camel@mattotaupa>

sorry about the format of the patch, I had not yet read the commit policy
when I wrote this.  actually when I wrote this I would have needed a pretty
detailed step-by-step, enter these commands, sort of guide.

On Tue, Aug 30, 2011 at 8:30 AM, Paul Menzel <
paulepanter@users.sourceforge.net> wrote:

> Am Dienstag, den 30.08.2011, 12:51 +0200 schrieb Steffen Sledz:
> > On 25.08.2011 16:09, Steffen Sledz wrote:
> > > On 25.08.2011 12:59, Steffen Sledz wrote:
> > >> On 24.08.2011 17:22, Jesse Gilles wrote:
> > >>> On Tue, 2011-08-23 at 13:16 -0400, George C. Huntington, III wrote:
> > >>>> I suspect that the problem is happening earlier, classpath isn't
> building.
> > >>>>  the javac wrapper eats the return code from a java compile.
> > >>>
> > >>> If George is right, then the following patch to the javac wrapper
> script
> > >>> may fix the issue.  It fixes building classpath as well as returns
> the
> > >>> error code if all javac attempts fail.
> > >>>
> > >>> http://patches.openembedded.org/patch/9521/
> > >>
> > >> In our case this patch helps.
> > >>
> > >> If nobody has objections i will commit this patch to oe-dev master and
> request a pull to 2011.03-maintenance.
> > >
> > > It would be still better if we can get some Acks from a java
> maintainer.
> >
> > No NACKs after another week. So i pushed the patch do oe-dev master.
>
> Next time it would be better to resend the patch with a appropriate
> subject line.
>
> Unfortunately the commit message [1] does not conform to our commit
> policy [2].
>
> Please make sure to check those things next time. I feel uncomfortable
> to ask new contributors to comply every time but when they look at the
> commit history they see that the policies are often not cared about.
>
>
> Thanks,
>
> Paul
>
>
> [1]
> http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=16a8a1e9175035b55d91a141d5302c38d63c16f1
> [2] http://openembedded.org/index.php/Category:Policy
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>