From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B2FC64E7B for ; Wed, 2 Dec 2020 15:56:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C34AE217A0 for ; Wed, 2 Dec 2020 15:56:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C34AE217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkUUu-0005jT-HV for qemu-devel@archiver.kernel.org; Wed, 02 Dec 2020 10:56:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkUSQ-0003RU-Ik; Wed, 02 Dec 2020 10:54:18 -0500 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:41052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kkUSO-0007eR-PA; Wed, 02 Dec 2020 10:54:18 -0500 Received: by mail-oi1-x243.google.com with SMTP id h3so2032702oie.8; Wed, 02 Dec 2020 07:54:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E/IhTDRmDq0oztEHfJSdNz9Iti+5+yrVTCm8k0V0yjM=; b=i0mNZ5/9l1L0hK8glqepawF60BRmPMhTc037fMrlO4Q2r4eLLsEuZW7jWaPnPUfcKk O6JAC6X348JrDBWYyzFnZGUlanKrS8/ymTIYGwG0HFJiUvo4JeweMb/ztmIX/m/OWE22 cwn+h8aVkTy8UAsDxiy5x67BYZBH7OCFfPHZEtHVbVGHjxIf+/G6wgJ3tfIoq4F7zBJ1 ChESTOYuoqwOG7BjOkQuxP8PtFMZkt6UwJ/y0SEKzrpzZ24wwVFIuPrKf1/N2G6Ea7FY X9wmQ52KgxgXQByhmO04M1jlVYPwihoH32hHgZ5yBIVIr5xGt/Pf1+JUkMoEyKyfYxpK oy3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E/IhTDRmDq0oztEHfJSdNz9Iti+5+yrVTCm8k0V0yjM=; b=pOzlaHQcCGA3X2knn1KnFx0h5rwVev6wPCjDQvUCDkoMBpQlTj9iAQ96V1qBRIwng8 Z4+A062l1VbloAygJDwDK7X41f5/ctqDHVX4YEaucV8XiAZzIVbd35LQGPpnLyVF3AXX yyM4FDgKAjFGndLpZAgHEWCAE5uTk8qim7SaxbgL+G8I9tieSx0mwexyc/lKfnae5g/F oHg9w/JSEk5dUmXVqQYUvWN3VOYMGe9JCFl4kWd3ylVBH7I0sKl0Iodrd2g52evTzbZY BaoV+HnGEOcv8GfQbfDlgk72uCqwpmKgsl3BfUnIk1/aEuRni/OpTGiZh2rk4fSD56nU DYqg== X-Gm-Message-State: AOAM530dhmyOD8hjVX4Jl8pGNQxhEnFzLD7nfUtlsXK76LjaYfCqObdl tNh09CIKaP+1PQV8YSo063DuHgtST9b3OlcKs/c= X-Google-Smtp-Source: ABdhPJxXWm7v2wlihU42EZc9l73xondCmwZUn8dxIvxQPFFwXVAt1MDZIIBr91UrV7if6gOPqlrmDwXsBiR8Tp8j2ic= X-Received: by 2002:aca:c492:: with SMTP id u140mr2013866oif.51.1606924452818; Wed, 02 Dec 2020 07:54:12 -0800 (PST) MIME-Version: 1.0 References: <20201202152611.677753-1-stefanha@redhat.com> <20201202152611.677753-2-stefanha@redhat.com> In-Reply-To: <20201202152611.677753-2-stefanha@redhat.com> From: Raphael Norwitz Date: Wed, 2 Dec 2020 10:54:02 -0500 Message-ID: Subject: Re: [PATCH v2 1/4] contrib/vhost-user-blk: avoid g_return_val_if() input validation To: Stefan Hajnoczi Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::243; envelope-from=raphael.s.norwitz@gmail.com; helo=mail-oi1-x243.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Coiby Xu , QEMU , Max Reitz , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Gerd Hoffmann , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Raphael Norwitz , Stefano Garzarella Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Dec 2, 2020 at 10:27 AM Stefan Hajnoczi wrote: > > Do not validate input with g_return_val_if(). This API is intended for > checking programming errors and is compiled out with -DG_DISABLE_CHECKS. > > Use an explicit if statement for input validation so it cannot > accidentally be compiled out. > > Suggested-by: Markus Armbruster > Signed-off-by: Stefan Hajnoczi Reviewed-by: Raphael Norwitz > --- > contrib/vhost-user-blk/vhost-user-blk.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/contrib/vhost-user-blk/vhost-user-blk.c b/contrib/vhost-user-blk/vhost-user-blk.c > index dc981bf945..60e3c9ed37 100644 > --- a/contrib/vhost-user-blk/vhost-user-blk.c > +++ b/contrib/vhost-user-blk/vhost-user-blk.c > @@ -404,7 +404,11 @@ vub_get_config(VuDev *vu_dev, uint8_t *config, uint32_t len) > VugDev *gdev; > VubDev *vdev_blk; > > - g_return_val_if_fail(len <= sizeof(struct virtio_blk_config), -1); > + if (len > sizeof(struct virtio_blk_config)) { > + fprintf(stderr, "Invalid get_config len %u, expected <= %zu\n", > + len, sizeof(struct virtio_blk_config)); > + return -1; > + } > > gdev = container_of(vu_dev, VugDev, parent); > vdev_blk = container_of(gdev, VubDev, parent); > -- > 2.28.0 >