From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C71C433DF for ; Fri, 31 Jul 2020 08:56:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E737F22CAF for ; Fri, 31 Jul 2020 08:56:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aE1OHoox" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732008AbgGaI4S (ORCPT ); Fri, 31 Jul 2020 04:56:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731968AbgGaI4R (ORCPT ); Fri, 31 Jul 2020 04:56:17 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B589C061574 for ; Fri, 31 Jul 2020 01:56:17 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id a5so17299033wrm.6 for ; Fri, 31 Jul 2020 01:56:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; b=aE1OHooxwN4CtoTfKoukXZmAijnt7lUt7g2YEmORS3cT7AcMzMNPBMqe8jdLYclZBm eOHaWEarxXuFCjto12aNCFolbMakz+DiEVyPF5mrDDnb4gRfoCRQPp7jBy5l2R7n/un1 nBoT11Vhvh4xhvgqwcqKCnGpBSQmKQyJHI6yE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; b=OnByCHFRXPuzRDkHuxLKZCd9Z/WV4C77v9JUeEezU8OONABVNWvO4Y5hmfqliutrQC V/pPOJjgLmTw6dNUVVWF/tbOfIA9NXxqgegOGxGH+fPVWn7vGXk7fvybWpY/F2ULYr9l a1AeP5rvDvGPLXXkEl/aHS6Z0JeUMqV3YIiV4J5urvNTJOhwEKF2F+djGhhJnwjJ6Ihe dH7Cs2zY+WGd7IoWGIlG5jJyrctn9s9GoegxkK3r1QuCBgwZxq2OR1daLdWgj2b+DkGc nEZNQjmCNnfcNC1NIQq6Xq3EE6gMGlogww87WYfQ/dH4IWrl60D6RMRrsiyTbq2qmQx8 8rDg== X-Gm-Message-State: AOAM532UNkyjOxLk2e4N+R5nUazSSHilnPZ/NowrfAp4M+mfoA+SdlOd PmiyNiB9DJDrnFyJLpt7ARpP/C/KVxbloRTkXkz5xQ== X-Google-Smtp-Source: ABdhPJzWn3jZhPtcamUMQKgiq4Q2WoIJL296BZio2qPps8qapt7QAgo3rn4E433qso7peWw9XBVW+myXjp0sLi36trw= X-Received: by 2002:adf:e486:: with SMTP id i6mr2505317wrm.258.1596185775852; Fri, 31 Jul 2020 01:56:15 -0700 (PDT) MIME-Version: 1.0 References: <20200721104422.369368-1-cychiang@chromium.org> <20200721104422.369368-3-cychiang@chromium.org> <20200723184432.GA321518@gerhold.net> In-Reply-To: <20200723184432.GA321518@gerhold.net> From: Cheng-yi Chiang Date: Fri, 31 Jul 2020 16:55:49 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration To: Stephan Gerhold Cc: Srinivas Kandagatla , linux-kernel , Mark Brown , Taniya Das , Rohit kumar , Banajit Goswami , Patrick Lai , Andy Gross , Bjorn Andersson , Liam Girdwood , Rob Herring , Jaroslav Kysela , Takashi Iwai , Doug Anderson , Dylan Reid , Tzung-Bi Shih , Linux ARM , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Ajit Pandey Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jul 24, 2020 at 2:45 AM Stephan Gerhold wrote: > > On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote: > > > +static int sc7180_parse_of(struct snd_soc_card *card) > > > +{ > > > > This code is getting duplicated in various places like apq8016_sbc_parse_of, > > it will be nice to common this up, if possible! > > > > FYI, I started work on making apq8016_sbc use qcom_snd_parse_of() > a while ago already, but didn't find the time to finish it up. > I have now sent it, this should make it possible to use the common > qcom_snd_parse_of() function in this driver as well. > > See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@gerhold.net/ > > Stephan > Hi Stephan, thanks a lot for jumping on this to help. It indeed makes this new driver much cleaner. I have tested with your patches and it works great. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D450AC433E0 for ; Fri, 31 Jul 2020 08:58:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B28720838 for ; Fri, 31 Jul 2020 08:58:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="iU0DbvrF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aE1OHoox" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B28720838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C1BCB1687; Fri, 31 Jul 2020 10:58:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C1BCB1687 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596185936; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iU0DbvrFHqCdWOoqLofbLvGfmfXUX30ytUtRo6uFyCSfP4AVDUSZQhO0PeTDxNnZv zA5t8aVQRI4t/c8v4bd/OxMvdF3vHtbqqc26WVEIyynKHCHO1lIa2nCQmN5geyM6BM ugF+g7hDuh5MGnUB3Dh/hS+zUx/a93lJcqlx9fSg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2D769F802E1; Fri, 31 Jul 2020 10:56:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 97A08F802E2; Fri, 31 Jul 2020 10:56:22 +0200 (CEST) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7885DF802DF for ; Fri, 31 Jul 2020 10:56:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7885DF802DF Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aE1OHoox" Received: by mail-wr1-x442.google.com with SMTP id r12so27217125wrj.13 for ; Fri, 31 Jul 2020 01:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; b=aE1OHooxwN4CtoTfKoukXZmAijnt7lUt7g2YEmORS3cT7AcMzMNPBMqe8jdLYclZBm eOHaWEarxXuFCjto12aNCFolbMakz+DiEVyPF5mrDDnb4gRfoCRQPp7jBy5l2R7n/un1 nBoT11Vhvh4xhvgqwcqKCnGpBSQmKQyJHI6yE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; b=h44Z88Hx5N5Z/YdmP9onFnhGBrc7hTSvqLTDG1KKG/3EXWOEqu48gfgwsu2G4yiW0q Oz0nXNDbcwwIE1EK2KH5lrGuVjHTNRpCa7K+SzTsg6nIWEqJaqeVVNhwb/sctYN3wXkq ebJxUM261EN9sL+9j+E4HqfqHtHl82Qan+TDCJKmpCrZHiQkeDT70vIs3JWcsAz7kIqc Vp2OLJAGjZAah9nYS0vx1Tf6NWqmxGbihsOImJ2L9SH/QTI/4MtmSOibU6lSXhAHjjJB Q2yjgp6CpDA8NB2ev7poYG970YZe9Pqv28C+rR/GpNOIlrl0QuuY2NOsSarDOiwcP/Qz XFWQ== X-Gm-Message-State: AOAM530EedZ6gGC6h2erTTUz7oZVU94pq35cgPhAaO0lKeuXBEFpp9Cj KbWSv1VWIbJmdzBsBLcFnaB3u6277Y+x/f5IzhyGDQ== X-Google-Smtp-Source: ABdhPJzWn3jZhPtcamUMQKgiq4Q2WoIJL296BZio2qPps8qapt7QAgo3rn4E433qso7peWw9XBVW+myXjp0sLi36trw= X-Received: by 2002:adf:e486:: with SMTP id i6mr2505317wrm.258.1596185775852; Fri, 31 Jul 2020 01:56:15 -0700 (PDT) MIME-Version: 1.0 References: <20200721104422.369368-1-cychiang@chromium.org> <20200721104422.369368-3-cychiang@chromium.org> <20200723184432.GA321518@gerhold.net> In-Reply-To: <20200723184432.GA321518@gerhold.net> From: Cheng-yi Chiang Date: Fri, 31 Jul 2020 16:55:49 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration To: Stephan Gerhold Content-Type: text/plain; charset="UTF-8" Cc: Taniya Das , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Banajit Goswami , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Liam Girdwood , linux-arm-msm , Patrick Lai , Takashi Iwai , linux-kernel , Rob Herring , Bjorn Andersson , Mark Brown , Rohit kumar , Andy Gross , Doug Anderson , Srinivas Kandagatla , Dylan Reid , Ajit Pandey , Linux ARM X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Jul 24, 2020 at 2:45 AM Stephan Gerhold wrote: > > On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote: > > > +static int sc7180_parse_of(struct snd_soc_card *card) > > > +{ > > > > This code is getting duplicated in various places like apq8016_sbc_parse_of, > > it will be nice to common this up, if possible! > > > > FYI, I started work on making apq8016_sbc use qcom_snd_parse_of() > a while ago already, but didn't find the time to finish it up. > I have now sent it, this should make it possible to use the common > qcom_snd_parse_of() function in this driver as well. > > See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@gerhold.net/ > > Stephan > Hi Stephan, thanks a lot for jumping on this to help. It indeed makes this new driver much cleaner. I have tested with your patches and it works great. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 823E8C433DF for ; Fri, 31 Jul 2020 08:58:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EA4320829 for ; Fri, 31 Jul 2020 08:58:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XGKyrIzR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aE1OHoox" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EA4320829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+vhdYIspWvqsquBb9TCIQiWEsqEx6cZsGypScVDQCFQ=; b=XGKyrIzRYrGCzJn2/SzdQUPgo qLf3cx+I6uiviT/UyBhXvqyEgPs+19WVKUeEBDKXZNLPRHJT/gcnxae2yga9qnAnodEFOapVFmBL7 7PBAs6WHsMAyzfpJ1l2llyx3zFMn9vJoDxUpDV23e3WSe4V9GNWve/GQswQe8NG2dklzI1vPDRovQ 4dCa1xdr8vfDflUmv8CQsK2aQLU5nry4tLyBvrgEE8DaXjcYE1nHHkv5MloSRTtz+S+5BjybNMYuU qeG99Vxj1MUanw363cAQ3Or1o2ZliVGO+pxPE7tIxb6SPdxwVnAu4cd+ryj9egAMnm3wm5tWO/RGz +ou/D4nXQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1QqF-0003I1-No; Fri, 31 Jul 2020 08:56:39 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Qps-0003BD-Vr for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 08:56:18 +0000 Received: by mail-wr1-x444.google.com with SMTP id 88so27242854wrh.3 for ; Fri, 31 Jul 2020 01:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; b=aE1OHooxwN4CtoTfKoukXZmAijnt7lUt7g2YEmORS3cT7AcMzMNPBMqe8jdLYclZBm eOHaWEarxXuFCjto12aNCFolbMakz+DiEVyPF5mrDDnb4gRfoCRQPp7jBy5l2R7n/un1 nBoT11Vhvh4xhvgqwcqKCnGpBSQmKQyJHI6yE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; b=dMnUOkxio/IQcCXb5jqCGrkhw7DPzi4j2kUY3Sx29ZlwfEQe9xf6oTh6nlSAjZyOmT dtKbZrwKBD/D4M8hWFQQil4LozNPRr6s0Tv4fO+d98K7jRx/FKLbQh+wn+/D3AEBHsK+ ByamXcawL7ZbX48wVb/iBm6GpkjxC0PUIJQTzqd2+3NnNkj2Mm3DKRxVXTRLY6l43yTk X7H+klCdeiKEjmrrets9MsWXsbqYeH18TWQK6ZE1Ov995j4mvaHn5keiuv/Du2qcNEZD OxmtN/Gv0CJMCeVJL6iRRt1T4egDzRiFL3F99U/ODkNB+byqCrZRqS1Xaiqb1jgoBk6M kgrQ== X-Gm-Message-State: AOAM5328B9YCxkj3Q2AW7yj1pwsj8/uGFl+h11y3tjUgAdvs0tSFQP0n PX1bzwm6qqpubXW/3IS7ujIqsliiBRQM3WIoi/onmw== X-Google-Smtp-Source: ABdhPJzWn3jZhPtcamUMQKgiq4Q2WoIJL296BZio2qPps8qapt7QAgo3rn4E433qso7peWw9XBVW+myXjp0sLi36trw= X-Received: by 2002:adf:e486:: with SMTP id i6mr2505317wrm.258.1596185775852; Fri, 31 Jul 2020 01:56:15 -0700 (PDT) MIME-Version: 1.0 References: <20200721104422.369368-1-cychiang@chromium.org> <20200721104422.369368-3-cychiang@chromium.org> <20200723184432.GA321518@gerhold.net> In-Reply-To: <20200723184432.GA321518@gerhold.net> From: Cheng-yi Chiang Date: Fri, 31 Jul 2020 16:55:49 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration To: Stephan Gerhold X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_045617_151377_622BA870 X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Banajit Goswami , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Liam Girdwood , linux-arm-msm , Patrick Lai , Takashi Iwai , linux-kernel , Rob Herring , Bjorn Andersson , Mark Brown , Rohit kumar , Andy Gross , Doug Anderson , Srinivas Kandagatla , Dylan Reid , Jaroslav Kysela , Ajit Pandey , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 24, 2020 at 2:45 AM Stephan Gerhold wrote: > > On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote: > > > +static int sc7180_parse_of(struct snd_soc_card *card) > > > +{ > > > > This code is getting duplicated in various places like apq8016_sbc_parse_of, > > it will be nice to common this up, if possible! > > > > FYI, I started work on making apq8016_sbc use qcom_snd_parse_of() > a while ago already, but didn't find the time to finish it up. > I have now sent it, this should make it possible to use the common > qcom_snd_parse_of() function in this driver as well. > > See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@gerhold.net/ > > Stephan > Hi Stephan, thanks a lot for jumping on this to help. It indeed makes this new driver much cleaner. I have tested with your patches and it works great. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel