From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D879CC388F2 for ; Tue, 20 Oct 2020 18:55:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72E2A22404 for ; Tue, 20 Oct 2020 18:55:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kC1bm7nz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437864AbgJTSzP (ORCPT ); Tue, 20 Oct 2020 14:55:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437854AbgJTSzP (ORCPT ); Tue, 20 Oct 2020 14:55:15 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0708BC0613CE for ; Tue, 20 Oct 2020 11:55:14 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id n18so3529310wrs.5 for ; Tue, 20 Oct 2020 11:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mScZ8ah2UgtXD/hHaoKN6/WZjy3yp0sHiaOHV6wLFW8=; b=kC1bm7nzh6+1h/Q0nN45KdnVbW/OI5uUooOLQ2Vs/LpFzRvJnYRUV+JwP0kcW7T4QR 41jNfWJ2Z9lO48O89PVVflQTzDH60CTncg14/nyfU9FIEeibQS8Vrf68eqVidtcHz3vp 3lByNPbOMsEb9+VEVy4e6EqFieABTbe7vnr3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mScZ8ah2UgtXD/hHaoKN6/WZjy3yp0sHiaOHV6wLFW8=; b=qnppVkYf0wKEnTwUEthR32oYrxnlSb/m7j+gn7qslT124UUv9JO9qwe+uQkLfIq7Od Pvd5zcLYO2lEv0A6In87CCSj/nN4vAw2GqTyjz/QW+FPB1EV5H3oyhVIyVV7RT0LAwX7 kxNpAk6aQXpUV7FJJh3wrnouLwXFHzh8IAmZiqqKSK0iOUvaW/Fgncz9IJhm+Jr/zrJ5 QXKHA+m5WIYgGyUWVBpHQjNFEy14OPwhMVypeQ+36Av/FxHVHWfRPsN2Bxcv2dYX+NCG 9XJzeDXhvCbEd2IXxfVOYGYhZTssnZW7KppqDmz5TeMK7bTA52njuLkDUj0YVU5fsinY 5PRQ== X-Gm-Message-State: AOAM532CFAwHMOFocuMVQ2OA0AIFNY+xBg705CCdoxsDNRSoG2k84Bxa JZ95ZdbS7HmWbYmdthDT55mYmxTZbC5NeMNG15uAwg== X-Google-Smtp-Source: ABdhPJxsMtKaYZKishW1LFkqqTjFYaAFJFl/nN/EX/ADY7U9joK0FSO7QV5LU0tzsLkN7u78bKqbrTQK/Z5k/u4nUP8= X-Received: by 2002:a5d:49ca:: with SMTP id t10mr5023373wrs.404.1603220112425; Tue, 20 Oct 2020 11:55:12 -0700 (PDT) MIME-Version: 1.0 References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> <20201015161251.GF4390@sirena.org.uk> <20201020143711.GC9448@sirena.org.uk> <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> In-Reply-To: <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> From: Cheng-yi Chiang Date: Wed, 21 Oct 2020 02:54:43 +0800 Message-ID: Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Srinivas Kandagatla Cc: Mark Brown , linux-kernel , Taniya Das , Rohit kumar , Banajit Goswami , Patrick Lai , Andy Gross , Bjorn Andersson , Liam Girdwood , Rob Herring , Jaroslav Kysela , Takashi Iwai , Stephan Gerhold , Matthias Brugger , Heiko Stuebner , Srinivasa Rao , Doug Anderson , Dylan Reid , Tzung-Bi Shih , Linux ARM , linux-arm-msm , Kuninori Morimoto , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , "moderated list:ARM/Mediatek SoC support" , "open list:ARM/Rockchip SoC..." , Ajye Huang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Oct 20, 2020 at 10:55 PM Srinivas Kandagatla wrote: > > > > On 20/10/2020 15:37, Mark Brown wrote: > > I don't understand what "logic scattered in various dtsi files" means, > > sorry. > > > >> Yes, that should work to describe the dailink we are using. > >> But a more tricky issue is how to do calls like setting PLL in dai startup ops. > > ... > > > >> I think that asking a generic machine driver to do configuration like > >> this with only a limited interface of device property > >> might be too much of an ask for the machine driver. > > Richard was looking at some basic configuration for PLLs. > > > >> Would you mind if I simplify the compatible string like Srinivas > >> suggested, and send a v12? > >> As for other two kinds of variations that I am aware of: > >> 1. front mic / rear mic > >> 2. replace alc5682 with adau7002 > > The CODEC change is going to be described in the DT no matter what - > > you'll have a reference to the CODEC node but it may make sense if > > there's enough custom code around it. For front vs rear mic the > > simplest thing would just be to not mention which if this is a hardware > > fixed thing, otherwise a control. > > > >> We can set different board names and different compatible strings to > >> achieve such variation. > >> So that it would make sense to describe configuration in compatible > >> strings like you suggested, and also provides UCM a way to distinguish > >> different boards. > > I don't recall having suggested distinguishing these things with a > > compatible string, especially not the microphones. UCM can already use > > the display names for the boards to distinguish things. > > > Not with the compatible string! > > Currently card name, and long name are exactly same in all Qualcomm > soundcards, which makes it very difficult to identify how those boards > re wired up at UCM2 level. So the plan is to properly populate card long > name with "model" property which can include details on how things are > wiredup on that board. > > --srini Hi Srini, Thanks for taking a look. Let me try to clarify your comments in case there is any misunderstanding. I understand your request on having different board variations using different sound card names through model property, and I totally agree with that. As for compatible strings, do you insist on having all the board variations using exactly the same compatible string ? Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15F61C388F7 for ; Tue, 20 Oct 2020 18:56:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C11D422244 for ; Tue, 20 Oct 2020 18:56:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Rpbfz/OT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kC1bm7nz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C11D422244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F01E81723; Tue, 20 Oct 2020 20:55:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F01E81723 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603220176; bh=0eduY0cqaWJ0sv3eMfB4fCNcAnTRn0bOLBt59kSe+0I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Rpbfz/OTxHenLTF6+n4aI/EwdvYuD1nJQKzVJe8wWypLqkxeL3BMx2a4Z6T1HrvFo HQAtcYWeulqef0TX8D9hup79VVX9fv6AQLZhIO7drLfJRaplSuvvdqm7pTdiXwQtOl VtzpX7wFx8VTxwEbsTzKwPY+14KBZNKHqpouXHko= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9465EF804AB; Tue, 20 Oct 2020 20:55:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 67341F804AC; Tue, 20 Oct 2020 20:55:24 +0200 (CEST) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8B78FF80475 for ; Tue, 20 Oct 2020 20:55:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8B78FF80475 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kC1bm7nz" Received: by mail-wr1-x443.google.com with SMTP id s9so3514955wro.8 for ; Tue, 20 Oct 2020 11:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mScZ8ah2UgtXD/hHaoKN6/WZjy3yp0sHiaOHV6wLFW8=; b=kC1bm7nzh6+1h/Q0nN45KdnVbW/OI5uUooOLQ2Vs/LpFzRvJnYRUV+JwP0kcW7T4QR 41jNfWJ2Z9lO48O89PVVflQTzDH60CTncg14/nyfU9FIEeibQS8Vrf68eqVidtcHz3vp 3lByNPbOMsEb9+VEVy4e6EqFieABTbe7vnr3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mScZ8ah2UgtXD/hHaoKN6/WZjy3yp0sHiaOHV6wLFW8=; b=M10sGvwzBYeBV0KqglqwSpfYJ4OI+SVr2jElle5Uc0Nt0c1h3Kp+JmlRv0iczGlSZ1 rzMR841FqQ057s0uAye+FGatihR7omI/6jKzSTBrkexLsnPLRYmno1bNKwQMiNqSrV/g OO54ACuEL8ueM4CY5NgK0Q0YKYdP6fScoXw+RFuo4NPxjIcX16rL+ZZBk4e3NCXb8Qd9 zhZzG1gpehlCjjABR+LS2To05zV9WlqFnj48zFd00veNMpkuzYxe+r7vCRkjnrW/DPSe z0QpC7CrREu3fzR6/cM5RSKOjHKGKDUvMrivWecERyEFyFz+jFDK1EUlyeQVbXP/yiWy CTrg== X-Gm-Message-State: AOAM532B4M411IyVyz9kCPjZRyGm47IXctTE8a0NembiEwGRA87qdEnz Y5uu43DjuGJC17s6kD5dKhrcFXE4qVKjzKPzs0pEZA== X-Google-Smtp-Source: ABdhPJxsMtKaYZKishW1LFkqqTjFYaAFJFl/nN/EX/ADY7U9joK0FSO7QV5LU0tzsLkN7u78bKqbrTQK/Z5k/u4nUP8= X-Received: by 2002:a5d:49ca:: with SMTP id t10mr5023373wrs.404.1603220112425; Tue, 20 Oct 2020 11:55:12 -0700 (PDT) MIME-Version: 1.0 References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> <20201015161251.GF4390@sirena.org.uk> <20201020143711.GC9448@sirena.org.uk> <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> In-Reply-To: <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> From: Cheng-yi Chiang Date: Wed, 21 Oct 2020 02:54:43 +0800 Message-ID: Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Srinivas Kandagatla Content-Type: text/plain; charset="UTF-8" Cc: Taniya Das , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Banajit Goswami , Heiko Stuebner , Kuninori Morimoto , Takashi Iwai , Rohit kumar , Ajye Huang , Patrick Lai , "open list:ARM/Rockchip SoC..." , Andy Gross , Dylan Reid , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Srinivasa Rao , Stephan Gerhold , linux-arm-msm , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Bjorn Andersson , Linux ARM , Doug Anderson , Liam Girdwood , linux-kernel , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Oct 20, 2020 at 10:55 PM Srinivas Kandagatla wrote: > > > > On 20/10/2020 15:37, Mark Brown wrote: > > I don't understand what "logic scattered in various dtsi files" means, > > sorry. > > > >> Yes, that should work to describe the dailink we are using. > >> But a more tricky issue is how to do calls like setting PLL in dai startup ops. > > ... > > > >> I think that asking a generic machine driver to do configuration like > >> this with only a limited interface of device property > >> might be too much of an ask for the machine driver. > > Richard was looking at some basic configuration for PLLs. > > > >> Would you mind if I simplify the compatible string like Srinivas > >> suggested, and send a v12? > >> As for other two kinds of variations that I am aware of: > >> 1. front mic / rear mic > >> 2. replace alc5682 with adau7002 > > The CODEC change is going to be described in the DT no matter what - > > you'll have a reference to the CODEC node but it may make sense if > > there's enough custom code around it. For front vs rear mic the > > simplest thing would just be to not mention which if this is a hardware > > fixed thing, otherwise a control. > > > >> We can set different board names and different compatible strings to > >> achieve such variation. > >> So that it would make sense to describe configuration in compatible > >> strings like you suggested, and also provides UCM a way to distinguish > >> different boards. > > I don't recall having suggested distinguishing these things with a > > compatible string, especially not the microphones. UCM can already use > > the display names for the boards to distinguish things. > > > Not with the compatible string! > > Currently card name, and long name are exactly same in all Qualcomm > soundcards, which makes it very difficult to identify how those boards > re wired up at UCM2 level. So the plan is to properly populate card long > name with "model" property which can include details on how things are > wiredup on that board. > > --srini Hi Srini, Thanks for taking a look. Let me try to clarify your comments in case there is any misunderstanding. I understand your request on having different board variations using different sound card names through model property, and I totally agree with that. As for compatible strings, do you insist on having all the board variations using exactly the same compatible string ? Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC317C4363A for ; Tue, 20 Oct 2020 18:55:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 543B32222D for ; Tue, 20 Oct 2020 18:55:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2M02fXU9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kC1bm7nz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 543B32222D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BEm6WTmNMTjLNWX75CLeU7Fi5O+O2MsjdfkXubPXshk=; b=2M02fXU9XyYYE1x+NYMdv30OZ gm/Upb8p5EPxirjzLxzK7BmLTbSdEVAqMj+xin9q6CwYGRcsC2vnDnSAp8swqujFe/wwHWbavlzEU bpxfK19SG2mkQFJf9F5aJn1EI5fyWGkiGDq7L7EFMQ8Q/3JCnwfvsLKLZLeTA+wC42ijVjkX5DUSW Yn77/mgaZGF1puPeztGkKaOwntobVSPP5ixamiZxpunr7BT9R3vcEUFKn0tEQFWlc/EWoH39PlZT6 c1gL/FEO6AIdtpzQPLKbRciTbTAFZI28AAFOCvmzV7KBg8e7Jygv2gUxZBJlTlbFaAO9N7mMW+Z5i Sd4uxyySw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUwn1-0005ru-7h; Tue, 20 Oct 2020 18:55:19 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUwmv-0005qF-Ut for linux-rockchip@lists.infradead.org; Tue, 20 Oct 2020 18:55:15 +0000 Received: by mail-wr1-x441.google.com with SMTP id n6so3503387wrm.13 for ; Tue, 20 Oct 2020 11:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mScZ8ah2UgtXD/hHaoKN6/WZjy3yp0sHiaOHV6wLFW8=; b=kC1bm7nzh6+1h/Q0nN45KdnVbW/OI5uUooOLQ2Vs/LpFzRvJnYRUV+JwP0kcW7T4QR 41jNfWJ2Z9lO48O89PVVflQTzDH60CTncg14/nyfU9FIEeibQS8Vrf68eqVidtcHz3vp 3lByNPbOMsEb9+VEVy4e6EqFieABTbe7vnr3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mScZ8ah2UgtXD/hHaoKN6/WZjy3yp0sHiaOHV6wLFW8=; b=abN2OBu5czN3CJa+bEVlzctPfnvDH2kr3lN5IVpEb8JIgvJAl5FfhtGYxU0/ZrYAP4 eB9HMe7WIOka2Mp3uKi4bIpka+G30/TnTBp+3OU85WcJifxl4My032N2mctHReviQ7qh vBP5E9EY5Y4mG7dtmlG44KhpDH4Jnp6ElfJ02NHhn6v/cIl3FlZO5w2B4uhQp3W5pAJy 8TIQOhQ/qH6rXUQmG79DZeXulljj9kkKbXbyLON0FS0+kknTby4f4Rn64CKvlS1LsJQj CAQDdEZcE/SoQ2NxY+CdAh35Pw95BQYcX/sQ5BPy/JCT7dI3MxsoX5AW0gH9q+h4mEMu HXWg== X-Gm-Message-State: AOAM531cjMFAMc1BNQzJcIyUX0TEzpjNZ1t3n3nPCdEXV+RmhQWVFubD 2ekbqJ06F4K1u/VbazOhBzl+G13sK+0YtTJuFkOc8g== X-Google-Smtp-Source: ABdhPJxsMtKaYZKishW1LFkqqTjFYaAFJFl/nN/EX/ADY7U9joK0FSO7QV5LU0tzsLkN7u78bKqbrTQK/Z5k/u4nUP8= X-Received: by 2002:a5d:49ca:: with SMTP id t10mr5023373wrs.404.1603220112425; Tue, 20 Oct 2020 11:55:12 -0700 (PDT) MIME-Version: 1.0 References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> <20201015161251.GF4390@sirena.org.uk> <20201020143711.GC9448@sirena.org.uk> <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> In-Reply-To: <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> From: Cheng-yi Chiang Date: Wed, 21 Oct 2020 02:54:43 +0800 Message-ID: Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Srinivas Kandagatla X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_145514_079856_3167C4C5 X-CRM114-Status: GOOD ( 28.93 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Banajit Goswami , Heiko Stuebner , Kuninori Morimoto , Takashi Iwai , Rohit kumar , Ajye Huang , Patrick Lai , "open list:ARM/Rockchip SoC..." , Andy Gross , Dylan Reid , Jaroslav Kysela , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Srinivasa Rao , Stephan Gerhold , linux-arm-msm , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Bjorn Andersson , Linux ARM , Doug Anderson , Liam Girdwood , linux-kernel , Mark Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Oct 20, 2020 at 10:55 PM Srinivas Kandagatla wrote: > > > > On 20/10/2020 15:37, Mark Brown wrote: > > I don't understand what "logic scattered in various dtsi files" means, > > sorry. > > > >> Yes, that should work to describe the dailink we are using. > >> But a more tricky issue is how to do calls like setting PLL in dai startup ops. > > ... > > > >> I think that asking a generic machine driver to do configuration like > >> this with only a limited interface of device property > >> might be too much of an ask for the machine driver. > > Richard was looking at some basic configuration for PLLs. > > > >> Would you mind if I simplify the compatible string like Srinivas > >> suggested, and send a v12? > >> As for other two kinds of variations that I am aware of: > >> 1. front mic / rear mic > >> 2. replace alc5682 with adau7002 > > The CODEC change is going to be described in the DT no matter what - > > you'll have a reference to the CODEC node but it may make sense if > > there's enough custom code around it. For front vs rear mic the > > simplest thing would just be to not mention which if this is a hardware > > fixed thing, otherwise a control. > > > >> We can set different board names and different compatible strings to > >> achieve such variation. > >> So that it would make sense to describe configuration in compatible > >> strings like you suggested, and also provides UCM a way to distinguish > >> different boards. > > I don't recall having suggested distinguishing these things with a > > compatible string, especially not the microphones. UCM can already use > > the display names for the boards to distinguish things. > > > Not with the compatible string! > > Currently card name, and long name are exactly same in all Qualcomm > soundcards, which makes it very difficult to identify how those boards > re wired up at UCM2 level. So the plan is to properly populate card long > name with "model" property which can include details on how things are > wiredup on that board. > > --srini Hi Srini, Thanks for taking a look. Let me try to clarify your comments in case there is any misunderstanding. I understand your request on having different board variations using different sound card names through model property, and I totally agree with that. As for compatible strings, do you insist on having all the board variations using exactly the same compatible string ? Thanks! _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 205C3C388F2 for ; Tue, 20 Oct 2020 18:55:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87F2B22244 for ; Tue, 20 Oct 2020 18:55:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3d3Q+SBr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kC1bm7nz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87F2B22244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kMjgshQ1OhVxm8IIwFi0H0DkgIllrmQPyHFuke7IZ8U=; b=3d3Q+SBrcqSNOL0zGJwearzYH chC53eWiPPXN5cHPAuJ1dZYV3RzE0jBn8HfQUZB+UgMlnaga64Xyt1aiTzn5V09RFM6ptgR2U83pz a/buJw0zij0bEfzvMge1ej40V6S6YKIaepK9jYfd86co+p8ISOzM4P7CfhkmSZQgnl9ir1RKWNcph cItLzj1SPR8RlRuE/B5sAS2yRLCGzGyt9S+L8BuSWir3CXPWIf3b9k4YzCIN4rDNAnzYkKL0bMQSh Kn1HtecBmDIoIWXiPKuZM+zIKP35zcCy+v0ZXRP/Ew0UVmeynt41pJHPC4+UMaoAnmIoNqo3wzoSn GwL4K4BuA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUwn0-0005ri-GJ; Tue, 20 Oct 2020 18:55:18 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUwmv-0005qE-Ut for linux-mediatek@lists.infradead.org; Tue, 20 Oct 2020 18:55:15 +0000 Received: by mail-wr1-x441.google.com with SMTP id n15so3538878wrq.2 for ; Tue, 20 Oct 2020 11:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mScZ8ah2UgtXD/hHaoKN6/WZjy3yp0sHiaOHV6wLFW8=; b=kC1bm7nzh6+1h/Q0nN45KdnVbW/OI5uUooOLQ2Vs/LpFzRvJnYRUV+JwP0kcW7T4QR 41jNfWJ2Z9lO48O89PVVflQTzDH60CTncg14/nyfU9FIEeibQS8Vrf68eqVidtcHz3vp 3lByNPbOMsEb9+VEVy4e6EqFieABTbe7vnr3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mScZ8ah2UgtXD/hHaoKN6/WZjy3yp0sHiaOHV6wLFW8=; b=kO1a+BB/LFsV7Aw0qrC7GvE1sFxMG2l28ptFXMWztA2k3PQZTugoeig5JcAh/OOk48 wbfigXsil9LJW9rx87E9Yd8iCSZDZZouXjGyMPVVLbrqsDU0Zai1M3CGacufzfmEmtX6 pIvt6apRZ+Ro7Eo5yQWfZ5L1P+bVmtWuchy6xYT/DWJt5tqt4vYUaeJ1ErkeEQojbOVs mX78z/UQCpc5F1sSuw958a+uwhucQNl59lR5MOSlQLHJmM6iXOToaw/31hhmdsH9zI1N Qxmb4sT5PKt9bdoTtaq+DuLrQfWcFK7Y7ReAB6GZPTZazIWTTISMJJg499Jl1K8N0Fw4 5r6w== X-Gm-Message-State: AOAM533syVTLM4+6TH1xTpD/pqmsNI83GjG5+3TRNHNh5kRoP5iEYFix RnVtTh6C7S0rEdyxB8UDLU6tz2lJNQL+pyy1qb8PRg== X-Google-Smtp-Source: ABdhPJxsMtKaYZKishW1LFkqqTjFYaAFJFl/nN/EX/ADY7U9joK0FSO7QV5LU0tzsLkN7u78bKqbrTQK/Z5k/u4nUP8= X-Received: by 2002:a5d:49ca:: with SMTP id t10mr5023373wrs.404.1603220112425; Tue, 20 Oct 2020 11:55:12 -0700 (PDT) MIME-Version: 1.0 References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> <20201015161251.GF4390@sirena.org.uk> <20201020143711.GC9448@sirena.org.uk> <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> In-Reply-To: <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> From: Cheng-yi Chiang Date: Wed, 21 Oct 2020 02:54:43 +0800 Message-ID: Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Srinivas Kandagatla X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_145514_079331_9E4FB229 X-CRM114-Status: GOOD ( 28.72 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Banajit Goswami , Heiko Stuebner , Kuninori Morimoto , Takashi Iwai , Rohit kumar , Ajye Huang , Patrick Lai , "open list:ARM/Rockchip SoC..." , Andy Gross , Dylan Reid , Jaroslav Kysela , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Srinivasa Rao , Stephan Gerhold , linux-arm-msm , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Bjorn Andersson , Linux ARM , Doug Anderson , Liam Girdwood , linux-kernel , Mark Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Oct 20, 2020 at 10:55 PM Srinivas Kandagatla wrote: > > > > On 20/10/2020 15:37, Mark Brown wrote: > > I don't understand what "logic scattered in various dtsi files" means, > > sorry. > > > >> Yes, that should work to describe the dailink we are using. > >> But a more tricky issue is how to do calls like setting PLL in dai startup ops. > > ... > > > >> I think that asking a generic machine driver to do configuration like > >> this with only a limited interface of device property > >> might be too much of an ask for the machine driver. > > Richard was looking at some basic configuration for PLLs. > > > >> Would you mind if I simplify the compatible string like Srinivas > >> suggested, and send a v12? > >> As for other two kinds of variations that I am aware of: > >> 1. front mic / rear mic > >> 2. replace alc5682 with adau7002 > > The CODEC change is going to be described in the DT no matter what - > > you'll have a reference to the CODEC node but it may make sense if > > there's enough custom code around it. For front vs rear mic the > > simplest thing would just be to not mention which if this is a hardware > > fixed thing, otherwise a control. > > > >> We can set different board names and different compatible strings to > >> achieve such variation. > >> So that it would make sense to describe configuration in compatible > >> strings like you suggested, and also provides UCM a way to distinguish > >> different boards. > > I don't recall having suggested distinguishing these things with a > > compatible string, especially not the microphones. UCM can already use > > the display names for the boards to distinguish things. > > > Not with the compatible string! > > Currently card name, and long name are exactly same in all Qualcomm > soundcards, which makes it very difficult to identify how those boards > re wired up at UCM2 level. So the plan is to properly populate card long > name with "model" property which can include details on how things are > wiredup on that board. > > --srini Hi Srini, Thanks for taking a look. Let me try to clarify your comments in case there is any misunderstanding. I understand your request on having different board variations using different sound card names through model property, and I totally agree with that. As for compatible strings, do you insist on having all the board variations using exactly the same compatible string ? Thanks! _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3043C4363A for ; Tue, 20 Oct 2020 18:56:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3848522244 for ; Tue, 20 Oct 2020 18:56:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jmOV7QN2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kC1bm7nz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3848522244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3CG/mh0bPvj7ffbKxheS2B8d3wp9EhFj1qGXLykZ8zQ=; b=jmOV7QN2VivVcZ2juHfT7veJd VK46AU6uZFSYRTdFtVkdzoUjUwC2RW2GPxLWm9g7JefigiMtMEcjzp1Qvqk/adWNYVqw/iSun3vZI dyb4XCu6KaHIp5Lby800ZpZzSKCFLcN4jHFCpU4UF0inFnNme8BzKuP+h/ZSFYiDi0wLUMtnj5/aL UyyFhE/2UomfSa6AcURV3en8JbHOquDJigsivcr9fGmas4ftrWy5a//Y+//7VllH592s9zZyUfIUU YkiMOkiuNJvgukTYRx8XEjAwEZtEFyQjNuHvSOQMgN/C/RNz1UoBQFTI0ofmlmaalf/fU6WSafuc/ Z2kSxvcPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUwmy-0005rD-PZ; Tue, 20 Oct 2020 18:55:16 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUwmv-0005qD-S5 for linux-arm-kernel@lists.infradead.org; Tue, 20 Oct 2020 18:55:14 +0000 Received: by mail-wr1-x444.google.com with SMTP id n15so3538874wrq.2 for ; Tue, 20 Oct 2020 11:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mScZ8ah2UgtXD/hHaoKN6/WZjy3yp0sHiaOHV6wLFW8=; b=kC1bm7nzh6+1h/Q0nN45KdnVbW/OI5uUooOLQ2Vs/LpFzRvJnYRUV+JwP0kcW7T4QR 41jNfWJ2Z9lO48O89PVVflQTzDH60CTncg14/nyfU9FIEeibQS8Vrf68eqVidtcHz3vp 3lByNPbOMsEb9+VEVy4e6EqFieABTbe7vnr3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mScZ8ah2UgtXD/hHaoKN6/WZjy3yp0sHiaOHV6wLFW8=; b=rkKSIWJ2arC/HO+64fVtbSQJjrYLgbbwoPcNVGnAWEFHYEuhrMDhz2h0ievFAxKdN/ udrrdzz/I89P4YirsrJTIJtlir5xXulbA/LD7qYjAZMZTbw0g3H4jql7L9BnNkPogr0M zXHtfC6CsUZYXJC1AgW57AfSL8dwTYs7rmUA6O6t8hXyeIPUmI6WB/ZxNraaIOXDcv9E W25HOncClzANPS7xizRQglPmlCD9+aOOCsHwjcenJ4oPpin8XzbIKQqcUSA9lfNAzXDV Dp7DUnDfdeBH5FHwKuJnBKlwoFlRaH0Pm3jq6uVq0unT4VzawyX4Ulge+4qFjsNtSXlx kElA== X-Gm-Message-State: AOAM530D9LZfyLjX14VpvSDikamus8mmKv7gymFd7n7IKazRUSmAE3aV fmQWtfnWCTdS1UWduq8Xfm5qtj1f9HwSC6VpDztxaQ== X-Google-Smtp-Source: ABdhPJxsMtKaYZKishW1LFkqqTjFYaAFJFl/nN/EX/ADY7U9joK0FSO7QV5LU0tzsLkN7u78bKqbrTQK/Z5k/u4nUP8= X-Received: by 2002:a5d:49ca:: with SMTP id t10mr5023373wrs.404.1603220112425; Tue, 20 Oct 2020 11:55:12 -0700 (PDT) MIME-Version: 1.0 References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> <20201015161251.GF4390@sirena.org.uk> <20201020143711.GC9448@sirena.org.uk> <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> In-Reply-To: <63f1a29c-0758-97b8-ce80-fe43d91630fa@linaro.org> From: Cheng-yi Chiang Date: Wed, 21 Oct 2020 02:54:43 +0800 Message-ID: Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Srinivas Kandagatla X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_145514_068395_954F2345 X-CRM114-Status: GOOD ( 30.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Banajit Goswami , Heiko Stuebner , Kuninori Morimoto , Takashi Iwai , Rohit kumar , Ajye Huang , Patrick Lai , "open list:ARM/Rockchip SoC..." , Andy Gross , Dylan Reid , Jaroslav Kysela , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Srinivasa Rao , Stephan Gerhold , linux-arm-msm , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Bjorn Andersson , Linux ARM , Doug Anderson , Liam Girdwood , linux-kernel , Mark Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 20, 2020 at 10:55 PM Srinivas Kandagatla wrote: > > > > On 20/10/2020 15:37, Mark Brown wrote: > > I don't understand what "logic scattered in various dtsi files" means, > > sorry. > > > >> Yes, that should work to describe the dailink we are using. > >> But a more tricky issue is how to do calls like setting PLL in dai startup ops. > > ... > > > >> I think that asking a generic machine driver to do configuration like > >> this with only a limited interface of device property > >> might be too much of an ask for the machine driver. > > Richard was looking at some basic configuration for PLLs. > > > >> Would you mind if I simplify the compatible string like Srinivas > >> suggested, and send a v12? > >> As for other two kinds of variations that I am aware of: > >> 1. front mic / rear mic > >> 2. replace alc5682 with adau7002 > > The CODEC change is going to be described in the DT no matter what - > > you'll have a reference to the CODEC node but it may make sense if > > there's enough custom code around it. For front vs rear mic the > > simplest thing would just be to not mention which if this is a hardware > > fixed thing, otherwise a control. > > > >> We can set different board names and different compatible strings to > >> achieve such variation. > >> So that it would make sense to describe configuration in compatible > >> strings like you suggested, and also provides UCM a way to distinguish > >> different boards. > > I don't recall having suggested distinguishing these things with a > > compatible string, especially not the microphones. UCM can already use > > the display names for the boards to distinguish things. > > > Not with the compatible string! > > Currently card name, and long name are exactly same in all Qualcomm > soundcards, which makes it very difficult to identify how those boards > re wired up at UCM2 level. So the plan is to properly populate card long > name with "model" property which can include details on how things are > wiredup on that board. > > --srini Hi Srini, Thanks for taking a look. Let me try to clarify your comments in case there is any misunderstanding. I understand your request on having different board variations using different sound card names through model property, and I totally agree with that. As for compatible strings, do you insist on having all the board variations using exactly the same compatible string ? Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel