All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jimmy Cheng-Yi Chiang <cychiang@google.com>
To: "Shuming [范書銘]" <shumingf@realtek.com>
Cc: "Oder Chiou" <oder_chiou@realtek.com>,
	"Jack Yu" <jack.yu@realtek.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Derek [方德義]" <derek.fang@realtek.com>,
	"Flove(HsinFu)" <flove@realtek.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: rt1011: export r0 and temperature config
Date: Mon, 14 Oct 2019 10:47:54 +0800	[thread overview]
Message-ID: <CAFv8NwKXm8-P=P9QST7nrYwsTvtTMBch_O3qOENk1cD5o-0G5Q@mail.gmail.com> (raw)
In-Reply-To: <408b28994a044dfd91b832e4cef1cadb@realtek.com>

On Mon, Oct 14, 2019 at 9:46 AM Shuming [范書銘] <shumingf@realtek.com> wrote:
>
> > On Tue, Oct 08, 2019 at 09:33:24AM +0000, Shuming [范書銘] wrote:
> > > In chromebook case, the machine driver will get the
> > > r0 calibration data and temperature from VPD.
> > > Therefore, the codec exports r0 and temperature config API for it.
> >
> > This doesn't seem to apply against current code, please check and resend.
>
> Thanks Mark. I will check with Google whether still using this method. If so, I will resend the patch.

Hi Mark and Shuming,
Thank you for the suggestion. I agree that it is better to use device
property to pass r0 and temperature through device property.
I am working on coreboot changes to parse data from VPD, and set device property
"rt1011,temperature_calib" and "realtek,r0_calib".
I think the patch in rt1011 driver will be much simpler once we have
that device property ready.
And there will be no machine driver change needed.

Thanks!


>
> > ------Please consider the environment before printing this e-mail.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

      reply	other threads:[~2019-10-17  6:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08  9:33 [alsa-devel] [PATCH] ASoC: rt1011: export r0 and temperature config Shuming [范書銘]
2019-10-08 10:51 ` Mark Brown
2019-10-08 10:59   ` Cheng-yi Chiang
2019-10-08 11:06     ` Mark Brown
2019-10-08 11:22       ` Cheng-yi Chiang
2019-10-08 12:38         ` Mark Brown
2019-10-14  3:28           ` Cheng-yi Chiang
2019-10-10 14:20 ` Mark Brown
2019-10-14  1:46   ` Shuming [范書銘]
2019-10-14  2:47     ` Jimmy Cheng-Yi Chiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFv8NwKXm8-P=P9QST7nrYwsTvtTMBch_O3qOENk1cD5o-0G5Q@mail.gmail.com' \
    --to=cychiang@google.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=derek.fang@realtek.com \
    --cc=flove@realtek.com \
    --cc=jack.yu@realtek.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=oder_chiou@realtek.com \
    --cc=shumingf@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.